SlevomatCsobGateway\Call\OneClick\OneClickEchoRequest::send()

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

<?php declare(strict_types = 1);
	public function send(ApiClient $apiClient): PaymentResponse
	{
		$requestData = [
			'merchantId' => $this->merchantId,
			'origPayId' => $this->origPayId,
		];

		$response = $apiClient->post(
			'oneclick/echo',
			$requestData,
			new SignatureDataFormatter([
				'merchantId' => null,
				'origPayId' => null,
				'dttm' => null,
			]),
			new SignatureDataFormatter([
				'origPayId' => null,
				'dttm' => null,
				'resultCode' => null,
				'resultMessage' => null,
			])
		);

		$data = $response->getData();

		return new PaymentResponse(
			$data['origPayId'],
			DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']),

It seems like DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']) can also be of type false; however, parameter $responseDateTime of SlevomatCsobGateway\Call\PaymentResponse::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

			ResultCode::get($data['resultCode']),
			$data['resultMessage'],
			null
		);