SlevomatCsobGateway\Call\CustomerInfoRequest::send()

Complexity

Conditions	1
Paths	1

Size

Total Lines	28
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types = 1);
	public function send(ApiClient $apiClient): CustomerInfoResponse
	{
		$response = $apiClient->get(
			'customer/echo/{merchantId}/{customerId}/{dttm}/{signature}',
			[
				'merchantId' => $this->merchantId,
				'customerId' => $this->customerId,
			],
			new SignatureDataFormatter([
				'merchantId' => null,
				'customerId' => null,
				'dttm' => null,
			]),
			new SignatureDataFormatter([
				'customerId' => null,
				'dttm' => null,
				'resultCode' => null,
				'resultMessage' => null,
			])
		);

		$data = $response->getData();

		return new CustomerInfoResponse(
			DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']),

It seems like DateTimeImmutable::createFromFormat('YmdHis', $data['dttm']) can also be of type false; however, parameter $responseDateTime of SlevomatCsobGateway\Call\CustomerInfoResponse::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

			ResultCode::get($data['resultCode']),
			$data['resultMessage'],
			$data['customerId'] ?? null
		);