App\Repository\ArticleRepository

Complexity

Total Complexity

12

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Test Coverage

Coverage

92%

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getArticlesListQueryBuilder()	0	29	4
A	getArticlesList()	0	13	1
A	getArticlesFeedCount()	0	11	2
A	getArticlesFeed()	0	8	1
A	__construct()	0	3	1
A	getArticlesListCount()	0	11	2
A	getArticlesFeedQueryBuilder()	0	8	1

<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\Article;
use App\Entity\User;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\ORM\NonUniqueResultException;
use Doctrine\ORM\NoResultException;
use Doctrine\ORM\QueryBuilder;
use Doctrine\Persistence\ManagerRegistry;

final class ArticleRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Article::class);
    }

    public function getArticlesListCount(?string $tag, ?string $authorUsername, ?string $favoritedByUsername): int
    {
        try {
            return (int) $this
                ->getArticlesListQueryBuilder($tag, $authorUsername, $favoritedByUsername)
                ->select('count(a.id) as total')
                ->getQuery()
                ->getSingleScalarResult()
            ;
        } catch (NonUniqueResultException | NoResultException $exception) {
            return 0;
        }
    }

    /**
     * @return Article[]
     */
    public function getArticlesList(
        int $offset,
        int $limit,
        ?string $tag,
        ?string $authorUsername,
        ?string $favoritedByUsername
    ): array {
        return $this

The expression return $this->getArticlesListQueryBuilder($tag, $authorUsername, $favoritedByUsername)->setFirstResult($offset)->setMaxResults($limit)->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->getArticlesListQueryBuilder($tag, $authorUsername, $favoritedByUsername)
            ->setFirstResult($offset)
            ->setMaxResults($limit)
            ->getQuery()
            ->getResult()
        ;
    }

    public function getArticlesFeedCount(User $user): int
    {
        try {
            return (int) $this
                ->getArticlesFeedQueryBuilder($user)
                ->select('count(a.id) as total')
                ->getQuery()
                ->getSingleScalarResult()
            ;
        } catch (NonUniqueResultException | NoResultException $exception) {
            return 0;
        }
    }

    /**
     * @return Article[]
     */
    public function getArticlesFeed(User $user, int $offset, int $limit): array
    {
        return $this

The expression return $this->getArticlesFeedQueryBuilder($user)->setFirstResult($offset)->setMaxResults($limit)->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->getArticlesFeedQueryBuilder($user)
            ->setFirstResult($offset)
            ->setMaxResults($limit)
            ->getQuery()
            ->getResult()
        ;
    }

    private function getArticlesListQueryBuilder(
        ?string $tag,
        ?string $authorUsername,
        ?string $favoritedByUsername
    ): QueryBuilder {
        $queryBuilder = $this
            ->createQueryBuilder('a')
            ->innerJoin('a.author', 'author')
            ->orderBy('a.id', 'desc')
        ;

        if ($tag) {
            $queryBuilder->innerJoin('a.tags', 't');
            $queryBuilder->andWhere('t.name = :tag');
            $queryBuilder->setParameter('tag', $tag);
        }

        if ($authorUsername) {
            $queryBuilder->andWhere('author.username = :author_username');
            $queryBuilder->setParameter('author_username', $authorUsername);
        }

        if ($favoritedByUsername) {
            $queryBuilder->innerJoin('a.favoritedBy', 'favoritedBy');
            $queryBuilder->andWhere('favoritedBy.username = :favoritedby_username');
            $queryBuilder->setParameter('favoritedby_username', $favoritedByUsername);
        }

        return $queryBuilder;
    }

    private function getArticlesFeedQueryBuilder(User $user): QueryBuilder
    {
        return $this
            ->createQueryBuilder('a')
            ->innerJoin('a.author', 'author')
            ->andWhere('author IN (:authors_ids)')
            ->setParameter('authors_ids', $user->getFolloweds())
            ->orderBy('a.id', 'desc')
        ;
    }
}