Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class BasicCancel extends Frame |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | private $consumerTag; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var bool |
||
| 25 | */ |
||
| 26 | private $noWait; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param int $channel |
||
| 30 | * @param string $consumerTag |
||
| 31 | * @param bool $noWait |
||
| 32 | */ |
||
| 33 | public function __construct($channel, $consumerTag, $noWait) |
||
| 34 | { |
||
| 35 | $this->consumerTag = $consumerTag; |
||
| 36 | $this->noWait = $noWait; |
||
| 37 | |||
| 38 | parent::__construct($channel); |
||
| 39 | } |
||
| 40 | |||
| 41 | /** |
||
| 42 | * ConsumerTag. |
||
| 43 | * |
||
| 44 | * @return string |
||
| 45 | */ |
||
| 46 | public function getConsumerTag() |
||
| 47 | { |
||
| 48 | return $this->consumerTag; |
||
| 49 | } |
||
| 50 | |||
| 51 | /** |
||
| 52 | * NoWait. |
||
| 53 | * |
||
| 54 | * @return bool |
||
| 55 | */ |
||
| 56 | public function isNoWait() |
||
| 57 | { |
||
| 58 | return $this->noWait; |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @return string |
||
| 63 | */ |
||
| 64 | public function encode() |
||
| 65 | { |
||
| 66 | $data = "\x00\x3C\x00\x1E". |
||
| 67 | Value\ShortStringValue::encode($this->consumerTag). |
||
| 68 | Value\BooleanValue::encode($this->noWait); |
||
| 69 | |||
| 70 | return "\x01".pack('nN', $this->channel, strlen($data)).$data."\xCE"; |
||
| 71 | } |
||
| 72 | } |
||
| 73 |