Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | class ShortStringValue extends AbstractValue |
|
8 | { |
||
9 | /** |
||
10 | * @param string $value |
||
11 | * |
||
12 | * @return string |
||
13 | */ |
||
14 | 23 | public static function encode($value) |
|
18 | |||
19 | /** |
||
20 | * @param Buffer $data |
||
21 | * |
||
22 | * @return string |
||
23 | */ |
||
24 | 23 | public static function decode(Buffer $data) |
|
28 | } |
||
29 |