WebServiceName::getAll() - Code Metrics - Inspection of "Merge pull request #85 from JindrichPilar/cleanup" - skaut/Skautis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 27c796...fe01f0 )

by Jindřich

created 2019-12-28 19:50 UTC

WebServiceName::getAll() A

↳ Parent: WebServiceName

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	2
rs	9.9666
c	0
b	0
f	0

<?php

declare(strict_types=1);


namespace Skautis\Wsdl;


use ReflectionClass;

/**
 * Dostupné webové služby SkautISu
 */
abstract class WebServiceName
{

  public const APPLICATION_MANAGEMENT = 'ApplicationManagement';

  public const CONTENT_MANAGEMENT = 'ContentManagement';

  public const DOCUMENT_STORAGE = 'DocumentStorage';

  public const EVALUATION = 'Evaluation';

  public const EVENTS = 'Events';

  public const EXPORTS = 'Exports';

  public const GOOGLE_APPS = 'GoogleApps';

  public const GRANTS = 'Grants';

  public const INSURANCE = 'Insurance';

  public const JOURNAL = 'Journal';

  public const MATERIAL = 'Material';

  public const MESSAGE = 'Message';

  public const ORGANIZATION_UNIT = 'OrganizationUnit';

  public const POWER = 'Power';

  public const REPORTS = 'Reports';

  public const SUMMARY = 'Summary';

  public const TASK = 'Task';

  public const TELEPHONY = 'Telephony';

  public const USER_MANAGEMENT = 'UserManagement';

  public const VIVANT = 'Vivant';

  public const WELCOME = 'Welcome';

  /**
   * @var string[]
   */
  private static $cachedConstants = [];


  /**
   * @return string[]s

   */
  public static function getAll(): array
  {
    if (!self::$cachedConstants) {

      $reflect = new ReflectionClass(static::class);
      self::$cachedConstants = $reflect->getConstants();

    }

    return self::$cachedConstants;
  }

  public static function isValidServiceName(
    string $name
  ): bool {
    return in_array($name, self::getAll(), true);
  }


}

1		<?php
2
3		declare(strict_types=1);
4
5
6		namespace Skautis\Wsdl;
7
8
9		use ReflectionClass;
10
11		/**
12		* Dostupné webové služby SkautISu
13		*/
14		abstract class WebServiceName
15		{
16
17		public const APPLICATION_MANAGEMENT = 'ApplicationManagement';
18
19		public const CONTENT_MANAGEMENT = 'ContentManagement';
20
21		public const DOCUMENT_STORAGE = 'DocumentStorage';
22
23		public const EVALUATION = 'Evaluation';
24
25		public const EVENTS = 'Events';
26
27		public const EXPORTS = 'Exports';
28
29		public const GOOGLE_APPS = 'GoogleApps';
30
31		public const GRANTS = 'Grants';
32
33		public const INSURANCE = 'Insurance';
34
35		public const JOURNAL = 'Journal';
36
37		public const MATERIAL = 'Material';
38
39		public const MESSAGE = 'Message';
40
41		public const ORGANIZATION_UNIT = 'OrganizationUnit';
42
43		public const POWER = 'Power';
44
45		public const REPORTS = 'Reports';
46
47		public const SUMMARY = 'Summary';
48
49		public const TASK = 'Task';
50
51		public const TELEPHONY = 'Telephony';
52
53		public const USER_MANAGEMENT = 'UserManagement';
54
55		public const VIVANT = 'Vivant';
56
57		public const WELCOME = 'Welcome';
58
59		/**
60		* @var string[]
61		*/
62		private static $cachedConstants = [];
63
64
65		/**
66		* @return string[]s
		0 ignored issues – show Documentation introduced 2019-10-06 18:05 UTC by Report Bug Copy Issue Report The doc-type `string[]s` could not be parsed: Expected "\|" or "end of type", but got "s" at position 8. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
67		*/
68	9	public static function getAll(): array
69		{
70	9	if (!self::$cachedConstants) {
		0 ignored issues – show Bug Best Practice introduced 2019-09-12 13:34 UTC by Report Bug Copy Issue Report The expression `self::$cachedConstants` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
71	1	$reflect = new ReflectionClass(static::class);
72	1	self::$cachedConstants = $reflect->getConstants();
		0 ignored issues – show Documentation Bug introduced 2019-09-12 13:34 UTC by Report Bug Copy Issue Report It seems like `$reflect->getConstants()` of type `array<string,integer\|double\|string\|boolean>` is incompatible with the declared type `array<integer,string>` of property `$cachedConstants`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
73		}
74
75	9	return self::$cachedConstants;
76		}
77
78	9	public static function isValidServiceName(
79		string $name
80		): bool {
81	9	return in_array($name, self::getAll(), true);
82		}
83
84
85		}

skaut / Skautis

GitHub Access Token became invalid

Push — 3.x ( 27c796...fe01f0 )

WebServiceName::getAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like