DaemonCommand::configure() - Code Metrics - Inspection of "[WIP] add daemon mode" - sj-i/php-profiler - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#9)

by Shinji
created 2020-06-19 14:34 UTC
DaemonCommand::configure() A

↳ Parent: DaemonCommand
Complexity

Conditions	1
Paths	1
Size

Total Lines	52
Code Lines	43
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	1
Metric	Value
cc	1
eloc	43
c	1
b	0
f	1
nc	1
nop	0
dl	0
loc	52
rs	9.232
How to fix Long Method

<?php

/**
 * This file is part of the sj-i/php-profiler package.
 *
 * (c) sji <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace PhpProfiler\Command\Inspector;

use Amp\Loop;
filter:
    dependency_paths: ["lib/*"]
use Amp\Promise;
filter:
    dependency_paths: ["lib/*"]
use Amp\Parallel\Context;
filter:
    dependency_paths: ["lib/*"]
use PhpProfiler\Command\Inspector\Settings\GetTraceSettings;
use PhpProfiler\Command\Inspector\Settings\TargetPhpSettings;
use PhpProfiler\Command\Inspector\Settings\TraceLoopSettings;
use Symfony\Component\Console\Command\Command;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Input\InputInterface;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Input\InputOption;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Output\OutputInterface;
filter:
    dependency_paths: ["lib/*"]

final class DaemonCommand extends Command
{
    public function configure(): void
    {
        $this->setName('inspector:daemon')
            ->setDescription('periodically get running function name from an outer process or thread')
            ->addOption(
                'target-regex',
                'P',
                InputOption::VALUE_OPTIONAL,
                'regex to find the php binary loaded in the target process'
            )
            ->addOption('depth', 'd', InputOption::VALUE_OPTIONAL, 'max depth')
            ->addOption(
                'sleep-ns',
                's',
                InputOption::VALUE_OPTIONAL,
                'nanoseconds between traces (default: 1000 * 1000 * 10)'
            )
            ->addOption(
                'max-retries',
                'r',
                InputOption::VALUE_OPTIONAL,
                'max retries on contiguous errors of read (default: 10)'
            )
            ->addOption(
                'php-regex',
                null,
                InputOption::VALUE_OPTIONAL,
                'regex to find the php binary loaded in the target process'
            )
            ->addOption(
                'libpthread-regex',
                null,
                InputOption::VALUE_OPTIONAL,
                'regex to find the libpthread.so loaded in the target process'
            )
            ->addOption(
                'php-version',
                null,
                InputOption::VALUE_OPTIONAL,
                'php version of the target'
            )
            ->addOption(
                'php-path',
                null,
                InputOption::VALUE_OPTIONAL,
                'path to the php binary (only needed in tracing chrooted ZTS target)'
            )
            ->addOption(
                'libpthread-path',
                null,
                InputOption::VALUE_OPTIONAL,
                'path to the libpthread.so (only needed in tracing chrooted ZTS target)'
            )
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int
     */
    public function execute(InputInterface $input, OutputInterface $output): int
    {
        $target_php_settings = TargetPhpSettings::fromConsoleInput($input);
        $loop_settings = TraceLoopSettings::fromConsoleInput($input);
        $get_trace_settings = GetTraceSettings::fromConsoleInput($input);

        /** @var string $target_regex */
        $target_regex = '{' . ($input->getOption('target-regex') ?? '^php-fpm') . '}';
        $context = Context\create(__DIR__ . '/Worker/php-searcher.php');
        $context = /** @scrutinizer ignore-call */ Context\create(__DIR__ . '/Worker/php-searcher.php');
        /** @var int $searcher_pid */
        $searcher_pid = Promise\wait($context->start());
        $searcher_pid = /** @scrutinizer ignore-call */ Promise\wait($context->start());
        Promise\wait($context->send($target_regex));
        /** @var int[] $pid_list */
        $pid_list = Promise\wait($context->receive());
        $readers = [];
        foreach ($pid_list as $target_pid) {
            $context = Context\create(__DIR__ . '/Worker/php-reader.php');
            Promise\wait($context->start());
            Promise\wait($context->send([$target_pid, $target_php_settings, $loop_settings, $get_trace_settings]));
            $readers[$target_pid] = $context;
        }
        exec('stty -icanon -echo');

        Loop::run(function () use (&$readers, $output) {
            Loop::onReadable(
                STDIN,
                /** @param resource $stream */
                function (string $watcher_id, $stream) {
                    $key = fread($stream, 1);
                    if ($key === 'q') {
                        Loop::cancel($watcher_id);
                        Loop::stop();
                    }
                }
            );
            Loop::repeat(10, function () use (&$readers, $output) {
                /** @var array<int, Context\Context> $readers */

                $promises = [];
                foreach ($readers as $pid => $reader) {
                    if (!$reader->isRunning()) {
                        /** @psalm-suppress MixedArrayAccess*/
                        unset($readers[$pid]);
                        continue;
                    }
                    $promises[] = \Amp\call(
                    $promises[] = /** @scrutinizer ignore-call */ \Amp\call(
                        function () use ($reader, &$readers, $pid, $output) {
                            /** @psalm-suppress MixedArrayAccess*/
                            unset($readers[$pid]);
                            /** @var string $result */
                            $result = yield $reader->receive();
                            $output->write($result);
                            $readers[$pid] = $reader;
                        }
                    );
                }
                yield $promises;
            });
        });

        return 0;
    }
}

sj-i / php-profiler

Pull Request — master (#9)

DaemonCommand::configure() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
