DaemonCommand::execute() - Code Metrics - Inspection of "[WIP] add daemon mode" - sj-i/php-profiler - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#9)

by Shinji
created 2020-06-29 19:07 UTC
DaemonCommand::execute() B

↳ Parent: DaemonCommand
Complexity

Conditions	5
Paths	1
Size

Total Lines	71
Code Lines	49
Duplication

Lines	0
Ratio	0 %
Importance

Changes	4
Bugs	0	Features	1
Metric	Value
eloc	49
nc	1
nop	2
dl	0
loc	71
c	4
b	0
f	1
cc	5
rs	8.8016
How to fix Long Method

<?php

/**
 * This file is part of the sj-i/php-profiler package.
 *
 * (c) sji <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace PhpProfiler\Command\Inspector;

use Amp\Loop;
filter:
    dependency_paths: ["lib/*"]
use Amp\Promise;
filter:
    dependency_paths: ["lib/*"]
use PhpProfiler\Inspector\Daemon\Dispatcher\DispatchTable;
use PhpProfiler\Inspector\Daemon\Dispatcher\Message\TraceMessage;
use PhpProfiler\Inspector\Daemon\Dispatcher\WorkerPool;
use PhpProfiler\Inspector\Daemon\Reader\Context\PhpReaderContextCreator;
use PhpProfiler\Inspector\Daemon\Searcher\Context\PhpSearcherContextCreator;
use PhpProfiler\Inspector\Settings\DaemonSettings;
use PhpProfiler\Inspector\Settings\GetTraceSettings;
use PhpProfiler\Inspector\Settings\TargetPhpSettings;
use PhpProfiler\Inspector\Settings\TraceLoopSettings;
use Symfony\Component\Console\Command\Command;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Input\InputInterface;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Input\InputOption;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Output\OutputInterface;
filter:
    dependency_paths: ["lib/*"]

final class DaemonCommand extends Command
{
    private PhpSearcherContextCreator $php_searcher_context_creator;
    private PhpReaderContextCreator $php_reader_context_creator;

    public function __construct(
        PhpSearcherContextCreator $php_searcher_context_creator,
        PhpReaderContextCreator $php_reader_context_creator
    ) {
        parent::__construct();
        $this->php_reader_context_creator = $php_reader_context_creator;
        $this->php_searcher_context_creator = $php_searcher_context_creator;
    }

    public function configure(): void
    {
        $this->setName('inspector:daemon')
            ->setDescription('periodically get running function name from an outer process or thread')
            ->addOption(
                'target-regex',
                'P',
                InputOption::VALUE_OPTIONAL,
                'regex to find the php binary loaded in the target process'
            )
            ->addOption('depth', 'd', InputOption::VALUE_OPTIONAL, 'max depth')
            ->addOption(
                'sleep-ns',
                's',
                InputOption::VALUE_OPTIONAL,
                'nanoseconds between traces (default: 1000 * 1000 * 10)'
            )
            ->addOption(
                'max-retries',
                'r',
                InputOption::VALUE_OPTIONAL,
                'max retries on contiguous errors of read (default: 10)'
            )
            ->addOption(
                'threads',
                'T',
                InputOption::VALUE_OPTIONAL,
                'number of workers (default: 8)'
            )
            ->addOption(
                'php-regex',
                null,
                InputOption::VALUE_OPTIONAL,
                'regex to find the php binary loaded in the target process'
            )
            ->addOption(
                'libpthread-regex',
                null,
                InputOption::VALUE_OPTIONAL,
                'regex to find the libpthread.so loaded in the target process'
            )
            ->addOption(
                'php-version',
                null,
                InputOption::VALUE_OPTIONAL,
                'php version of the target'
            )
            ->addOption(
                'php-path',
                null,
                InputOption::VALUE_OPTIONAL,
                'path to the php binary (only needed in tracing chrooted ZTS target)'
            )
            ->addOption(
                'libpthread-path',
                null,
                InputOption::VALUE_OPTIONAL,
                'path to the libpthread.so (only needed in tracing chrooted ZTS target)'
            )
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int
     */
    public function execute(InputInterface $input, OutputInterface $output): int
    {
        $target_php_settings = TargetPhpSettings::fromConsoleInput($input);
        $loop_settings = TraceLoopSettings::fromConsoleInput($input);
        $get_trace_settings = GetTraceSettings::fromConsoleInput($input);
        $daemon_settings = DaemonSettings::fromConsoleInput($input);

        $searcher_context = $this->php_searcher_context_creator->create();
        Promise\wait($searcher_context->start());
        Promise\wait($searcher_context->start());
        Promise\wait($searcher_context->sendTargetRegex($daemon_settings->target_regex));

        $worker_pool = WorkerPool::create(
            $this->php_reader_context_creator,
            $daemon_settings->threads,
            $target_php_settings,
            $loop_settings,
            $get_trace_settings
        );

        $dispatch_table = new DispatchTable(
            $worker_pool,
            $target_php_settings,
            $loop_settings,
            $get_trace_settings
        );

        exec('stty -icanon -echo');

        Loop::run(function () use ($dispatch_table, $searcher_context, $worker_pool, $output) {
            Loop::onReadable(
                STDIN,
                /** @param resource $stream */
                function (string $watcher_id, $stream) {
                    $key = fread($stream, 1);
                    if ($key === 'q') {
                        Loop::cancel($watcher_id);
                        Loop::stop();
                    }
                }
            );
            Loop::repeat(10, function () use ($dispatch_table, $searcher_context, $worker_pool, $output) {
                $promises = [];
                static $searcher_on_read = false;
                if (!$searcher_on_read) {
                    $promises[] = \Amp\call(function () use ($searcher_context, $dispatch_table, &$searcher_on_read) {
                    $promises[] = /** @scrutinizer ignore-call */ \Amp\call(function () use ($searcher_context, $dispatch_table, &$searcher_on_read) {
                        $searcher_on_read = true;
                        $update_target_message = yield $searcher_context->receivePidList();
                        $dispatch_table->updateTargets($update_target_message->target_process_list);
                        $searcher_on_read = false;
                    });
                }
                $readers = $worker_pool->getReadableWorkers();
                foreach ($readers as $pid => $reader) {
                    $promises[] = \Amp\call(
                        function () use ($reader, $pid, $worker_pool, $dispatch_table, $output) {
                            $worker_pool->setOnRead($pid);
                            $result = yield $reader->receiveTrace();
                            $worker_pool->releaseOnRead($pid);
                            if ($result instanceof TraceMessage) {
                                $output->write($result->trace);
                            } else {
                                $dispatch_table->releaseOne($result->pid);
                            }
                        }
                    );
                }
                yield $promises;
            });
        });

        return 0;
    }
}

sj-i / php-profiler

Pull Request — master (#9)

DaemonCommand::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
