Conditions | 6 |
Paths | 1 |
Total Lines | 71 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 4 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
68 | public function execute(InputInterface $input, OutputInterface $output): int |
||
69 | { |
||
70 | $get_trace_settings = $this->get_trace_settings_from_console_input->createSettings($input); |
||
71 | $daemon_settings = $this->daemon_settings_from_console_input->createSettings($input); |
||
72 | $target_php_settings = $this->target_php_settings_from_console_input->createSettings($input); |
||
73 | $loop_settings = $this->trace_loop_settings_from_console_input->createSettings($input); |
||
74 | $template_settings = $this->template_settings_from_console_input->createSettings($input); |
||
75 | $formatter = $this->templated_trace_formatter_factory->createFromSettings($template_settings); |
||
76 | |||
77 | $searcher_context = $this->php_searcher_context_creator->create(); |
||
78 | Promise\wait($searcher_context->start()); |
||
79 | Promise\wait($searcher_context->sendTargetRegex($daemon_settings->target_regex)); |
||
80 | |||
81 | $worker_pool = WorkerPool::create( |
||
82 | $this->php_reader_context_creator, |
||
83 | $daemon_settings->threads, |
||
84 | $target_php_settings, |
||
85 | $loop_settings, |
||
86 | $get_trace_settings |
||
87 | ); |
||
88 | |||
89 | $dispatch_table = new DispatchTable( |
||
90 | $worker_pool, |
||
91 | ); |
||
92 | |||
93 | $_echo_back_canceler = new EchoBackCanceller(); |
||
94 | |||
95 | Loop::onReadable( |
||
96 | STDIN, |
||
97 | /** @param resource $stream */ |
||
98 | function (string $watcher_id, $stream) { |
||
99 | $key = fread($stream, 1); |
||
100 | if ($key === 'q') { |
||
101 | Loop::cancel($watcher_id); |
||
102 | Loop::stop(); |
||
103 | } |
||
104 | } |
||
105 | ); |
||
106 | Loop::run(function () use ($dispatch_table, $searcher_context, $worker_pool, $output, $formatter) { |
||
107 | $promises = []; |
||
108 | $promises[] = call(function () use ($searcher_context, $dispatch_table) { |
||
109 | while (1) { |
||
110 | Log::debug('receiving pid List'); |
||
111 | $update_target_message = yield $searcher_context->receivePidList(); |
||
112 | Log::debug('update targets', [ |
||
113 | 'update' => $update_target_message->target_process_list->getArray(), |
||
114 | 'current' => $dispatch_table->worker_pool->debugDump(), |
||
115 | ]); |
||
116 | $dispatch_table->updateTargets($update_target_message->target_process_list); |
||
117 | Log::debug('target updated', [$dispatch_table->worker_pool->debugDump()]); |
||
118 | } |
||
119 | }); |
||
120 | foreach ($worker_pool->getWorkers() as $reader) { |
||
121 | $promises[] = call( |
||
122 | function () use ($reader, $dispatch_table, $output, $formatter) { |
||
123 | while (1) { |
||
124 | $result = yield $reader->receiveTraceOrDetachWorker(); |
||
125 | if ($result instanceof TraceMessage) { |
||
126 | $this->outputTrace($output, $formatter, $result); |
||
127 | } else { |
||
128 | Log::debug('releaseOne', [$result]); |
||
129 | $dispatch_table->releaseOne($result->pid); |
||
130 | } |
||
131 | } |
||
132 | } |
||
133 | ); |
||
134 | } |
||
135 | yield $promises; |
||
136 | }); |
||
137 | |||
138 | return 0; |
||
139 | } |
||
151 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths