PhpProfiler\Lib\Libc\Unistd\Execvp

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	execvp()	0	22	2
A	__construct()	0	6	1

<?php

/**
 * This file is part of the sj-i/php-profiler package.
 *
 * (c) sji <sji@sj-i.dev>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace PhpProfiler\Lib\Libc\Unistd;

use FFI\CInteger;

class Execvp
{
    /** @var \FFI\Libc\execvp_ffi */
    private \FFI $ffi;

    public function __construct()
    {
        /** @var \FFI\Libc\execvp_ffi */
        $this->ffi = \FFI::cdef('

The property ffi does not seem to exist on FFI\Libc\execvp_ffi.

            int execvp(const char *file, char *const argv[]);
       ', 'libc.so.6');
    }

    /** @param list<string> $argv */

The type PhpProfiler\Lib\Libc\Unistd\list was not found. Maybe you did not declare it correctly or list all dependencies?

    public function execvp(string $file, array $argv): int
    {
        /** @var CInteger $zero */
        $zero = \FFI::new('long', false, true);
        $zero->cdata = 0;
        $null = \FFI::cast('void *', $zero);

        $args = [$file, ...$argv];
        $size = \count($args) + 1;
        /** @var \FFI\CArray $argv_real */
        $argv_real = \FFI::new('char *[' . $size . ']', false, true);
        foreach ($args as $key => $item) {
            $item_len = strlen($item);

It seems like $item can also be of type array; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

            $item_len_nul = $item_len + 1;
            /** @var \FFI\CArray $argv_item */
            $argv_item = \FFI::new("char[{$item_len_nul}]", false, true);
            \FFI::memcpy($argv_item, $item, $item_len);
            $argv_item[$item_len] = "\0";
            $argv_real[$key] = $argv_item;
        }
        $argv_real[$key + 1] = $null;

The variable $key seems to be defined by a foreach iteration on line 43. Are you sure the iterator is never empty, otherwise this variable is not defined?

        return $this->ffi->execvp($file, $argv_real);

The method execvp() does not exist on FFI. It seems like you code against a sub-type of FFI such as FFI\Libc\execvp_ffi.

    }
}