PreciseMask::addWordToMask() - Code Metrics - Inspection of "Add PreciseMask class" - sixty-nine/php-cloud-lib - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 0d249c...af5e43 )

by Dan

created 2018-09-30 10:06 UTC

PreciseMask::addWordToMask() A

↳ Parent: PreciseMask

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	9.0968
c	0
b	0
f	0
cc	5
nc	5
nop	5

<?php

namespace SixtyNine\Cloud\Usher;

use SixtyNine\Cloud\FontMetrics;
use SixtyNine\DataTypes\Box;
use Imagine\Image\Point;

class PreciseMask extends QuadTreeMask implements MaskInterface
{
    /**
     * @param int $width
     * @param int $height
     * @param FontMetrics $metrics
     */
    public function __construct($width, $height, FontMetrics $metrics) {
        parent::__construct($width, $height);
        $this->metrics = $metrics;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param string $word
     * @param Box $place
     * @param string $font
     * @param int $size
     * @param int $angle
     */
    public function addWordToMask($word, Box $place, $font, $size, $angle)
    {
        $base = $this->metrics->calculateSize($word, $font, $size, $angle);
        foreach (str_split($word) as $letter) {
            $box = $this->metrics->calculateSize($letter, $font, $size);

            if ($angle === 0) {
                $newPos = new Point($place->getX(), $place->getY() + ($base->getHeight() - $box->getHeight()));
                $this->add($newPos, $box, $angle);

                $place = $place->move($box->getWidth(), 0);
                continue;
            }

            // Invert width and height
            $box = new Box(0, 0, $box->getHeight(), $box->getWidth());

            if ($place->getY() + ($base->getHeight() - $box->getHeight()) < 0) {
                continue;
            }

            if ($place->getX() + ($base->getWidth() - $box->getWidth()) < 0) {
                continue;
            }

            $newPos = new Point(
                $place->getX() + ($base->getWidth() - $box->getWidth()),
                $place->getY() + ($base->getHeight() - $box->getHeight())
            );
            $this->add($newPos, $box);
            $place = $place->move(0, -$box->getHeight());
        }
    }

}


1			<?php
2
3			namespace SixtyNine\Cloud\Usher;
4
5			use SixtyNine\Cloud\FontMetrics;
6			use SixtyNine\DataTypes\Box;
7			use Imagine\Image\Point;
8
9			class PreciseMask extends QuadTreeMask implements MaskInterface
10			{
11			/**
12			* @param int $width
13			* @param int $height
14			* @param FontMetrics $metrics
15			*/
16			public function __construct($width, $height, FontMetrics $metrics) {
17			parent::__construct($width, $height);
18			$this->metrics = $metrics;
			0 ignored issues – show Bug introduced 2018-09-30 10:13 UTC by Report Bug Copy Issue Report The property `metrics` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			/**
22			* @param string $word
23			* @param Box $place
24			* @param string $font
25			* @param int $size
26			* @param int $angle
27			*/
28			public function addWordToMask($word, Box $place, $font, $size, $angle)
29			{
30			$base = $this->metrics->calculateSize($word, $font, $size, $angle);
31			foreach (str_split($word) as $letter) {
32			$box = $this->metrics->calculateSize($letter, $font, $size);
33
34			if ($angle === 0) {
35			$newPos = new Point($place->getX(), $place->getY() + ($base->getHeight() - $box->getHeight()));
36			$this->add($newPos, $box, $angle);
			0 ignored issues – show Unused Code introduced 2018-09-30 10:13 UTC by Report Bug Copy Issue Report The call to `PreciseMask::add()` has too many arguments starting with `$angle`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
37			$place = $place->move($box->getWidth(), 0);
38			continue;
39			}
40
41			// Invert width and height
42			$box = new Box(0, 0, $box->getHeight(), $box->getWidth());
43
44			if ($place->getY() + ($base->getHeight() - $box->getHeight()) < 0) {
45			continue;
46			}
47
48			if ($place->getX() + ($base->getWidth() - $box->getWidth()) < 0) {
49			continue;
50			}
51
52			$newPos = new Point(
53			$place->getX() + ($base->getWidth() - $box->getWidth()),
54			$place->getY() + ($base->getHeight() - $box->getHeight())
55			);
56			$this->add($newPos, $box);
57			$place = $place->move(0, -$box->getHeight());
58			}
59			}
60
61			}
62

sixty-nine / php-cloud-lib

Push — master ( 0d249c...af5e43 )

PreciseMask::addWordToMask() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like