Font::setName() - Code Metrics - Inspection of "Introduce the class Drawer" - sixty-nine/php-cloud-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Dan

created 2017-04-05 12:57 UTC

Font::setName() A

↳ Parent: Font

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace SixtyNine\Cloud\Model;

/**
 * Embed a TTF font in the Cloud system.
 */
class Font
{
    /** @var string */
    protected $name;

    /** @var string */
    protected $file;

    /**
     * Create a TTF font from the given $file.
     * @param string $name
     * @param string $file
     * @throws \InvalidArgumentException
     */
    function __construct($name, $file)

    {
        if (!file_exists($file)) {
            throw new \InvalidArgumentException("File not found $file");
        }

        $this->name = $name;
        $this->file = $file;
    }

    /**
     * @param string $file
     */
    public function setFile($file)
    {
        $this->file = $file;
    }

    /**
     * @return string
     */
    public function getFile()
    {
        return $this->file;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }
}


1		<?php
2
3		namespace SixtyNine\Cloud\Model;
4
5		/**
6		* Embed a TTF font in the Cloud system.
7		*/
8		class Font
9		{
10		/** @var string */
11		protected $name;
12
13		/** @var string */
14		protected $file;
15
16		/**
17		* Create a TTF font from the given $file.
18		* @param string $name
19		* @param string $file
20		* @throws \InvalidArgumentException
21		*/
22	11	function __construct($name, $file)
		0 ignored issues – show Best Practice introduced 2017-04-05 13:02 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23		{
24	11	if (!file_exists($file)) {
25		throw new \InvalidArgumentException("File not found $file");
26		}
27
28	11	$this->name = $name;
29	11	$this->file = $file;
30	11	}
31
32		/**
33		* @param string $file
34		*/
35		public function setFile($file)
36		{
37		$this->file = $file;
38		}
39
40		/**
41		* @return string
42		*/
43	10	public function getFile()
44		{
45	10	return $this->file;
46		}
47
48		/**
49		* @param string $name
50		*/
51		public function setName($name)
52		{
53		$this->name = $name;
54		}
55
56		/**
57		* @return string
58		*/
59		public function getName()
60		{
61		return $this->name;
62		}
63		}
64

sixty-nine / php-cloud-lib

Pull Request — master (#5)

Font::setName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like