Font::getPaddingAngle() - Code Metrics - Inspection of "Code cleanup" - sixty-nine/php-cloud-lib - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 5ac70c...feabcf )

by Dan

created 2017-04-04 20:21 UTC

Font::getPaddingAngle() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace SixtyNine\Cloud\Model;

/**
 * Embed a TTF font in the Cloud system.
 */
class Font
{
    /** @var string */
    protected $name;

    /** @var string */
    protected $file;

    /**
     * Create a TTF font from the given $file.
     * @param string $name
     * @param string $file
     * @param int $paddingAngle
     * @param int $paddingSize
     * @throws \InvalidArgumentException
     */
    function __construct($name, $file, $paddingAngle = 0, $paddingSize = 1)

    {
        if (!file_exists($file)) {
            throw new \InvalidArgumentException("File not found $file");
        }

        $this->name = $name;
        $this->file = $file;
        $this->paddingAngle = $paddingAngle;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->paddingSize = $paddingSize;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param string $file
     */
    public function setFile($file)
    {
        $this->file = $file;
    }

    /**
     * @return string
     */
    public function getFile()
    {
        return $this->file;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }
}


1		<?php
2
3		namespace SixtyNine\Cloud\Model;
4
5		/**
6		* Embed a TTF font in the Cloud system.
7		*/
8		class Font
9		{
10		/** @var string */
11		protected $name;
12
13		/** @var string */
14		protected $file;
15
16		/**
17		* Create a TTF font from the given $file.
18		* @param string $name
19		* @param string $file
20		* @param int $paddingAngle
21		* @param int $paddingSize
22		* @throws \InvalidArgumentException
23		*/
24		function __construct($name, $file, $paddingAngle = 0, $paddingSize = 1)
		0 ignored issues – show Best Practice introduced 2017-04-02 15:11 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
25		{
26		if (!file_exists($file)) {
27		throw new \InvalidArgumentException("File not found $file");
28		}
29
30	7	$this->name = $name;
31		$this->file = $file;
32	7	$this->paddingAngle = $paddingAngle;
		0 ignored issues – show Bug introduced 2017-04-04 20:24 UTC by Report Bug Copy Issue Report The property `paddingAngle` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33		$this->paddingSize = $paddingSize;
		0 ignored issues – show Bug introduced 2017-04-04 20:24 UTC by Report Bug Copy Issue Report The property `paddingSize` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34		}
35
36	7	/**
37	7	* @param string $file
38	7	*/
39	7	public function setFile($file)
40	7	{
41		$this->file = $file;
42		}
43
44		/**
45		* @return string
46		*/
47		public function getFile()
48		{
49		return $this->file;
50		}
51
52		/**
53	6	* @param string $name
54		*/
55	6	public function setName($name)
56		{
57		$this->name = $name;
58		}
59
60		/**
61		* @return string
62		*/
63		public function getName()
64		{
65		return $this->name;
66		}
67		}
68

sixty-nine / php-cloud-lib

Push — master ( 5ac70c...feabcf )

Font::getPaddingAngle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like