AclController::listresourcesandrightsAction() - Code Metrics - sitrunlab/LearnZF2 - Measure and Improve Code Quality continuously with Scrutinizer

AclController::listresourcesandrightsAction() A
last analyzed 2016-04-05 22:32 UTC

↳ Parent: AclController

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	3	Features	0

Metric	Value
c	3
b	3
f	0
dl	0
loc	17
rs	9.4285
cc	2
eloc	10
nc	2
nop	0

<?php

/**
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license.
 */
namespace LearnZF2Acl\Controller;

use LearnZF2Acl\Model\Acl;
use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\JsonModel;
use Zend\View\Model\ViewModel;

/**
 * Acl Controller.
 *
 * @author Abdul Malik Ikhsan <[email protected]>
 */
class AclController extends AbstractActionController
{
    /**
     * @var Acl
     */
    private $aclmodel;

    /**
     * Construct.
     *
     * @param Acl $aclmodel
     */
    public function __construct(Acl $aclmodel)
    {
        $this->aclmodel = $aclmodel;
    }

    public function indexAction()
    {
        $defaultSelectedRoleId = 0;

        return new ViewModel([
            'defaultSelectedRoleId' => $defaultSelectedRoleId,
            'roles' => $this->aclmodel->getRoles(),
            'resources' => $this->aclmodel->getResources(),
            'rights' => $this->aclmodel->getRightLists(),
            'resourcesSelected' => $this->aclmodel->getResourceByRole($defaultSelectedRoleId),
            'rightsSelected' => $this->aclmodel->getRightLists($defaultSelectedRoleId),
        ]);
    }

    public function listresourcesandrightsAction()
    {
        $resources = [];
        $rights = [];

        if ($this->request->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $roleId = $this->request->getPost('roleId', 0);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $resources = $this->aclmodel->getResourceByRole($roleId);
            $rights = $this->aclmodel->getRightLists($roleId);
        }

        return new JsonModel([
            'resources' => $resources,
            'rights' => $rights,
        ]);
    }
}


AclController::listresourcesandrightsAction() A
last analyzed 2016-04-05 22:32 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
5			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
6			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
7			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
8			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
9			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
10			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
11			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
12			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
13			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
14			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
15			*
16			* This software consists of voluntary contributions made by many individuals
17			* and is licensed under the MIT license.
18			*/
19			namespace LearnZF2Acl\Controller;
20
21			use LearnZF2Acl\Model\Acl;
22			use Zend\Mvc\Controller\AbstractActionController;
23			use Zend\View\Model\JsonModel;
24			use Zend\View\Model\ViewModel;
25
26			/**
27			* Acl Controller.
28			*
29			* @author Abdul Malik Ikhsan <[email protected]>
30			*/
31			class AclController extends AbstractActionController
32			{
33			/**
34			* @var Acl
35			*/
36			private $aclmodel;
37
38			/**
39			* Construct.
40			*
41			* @param Acl $aclmodel
42			*/
43			public function __construct(Acl $aclmodel)
44			{
45			$this->aclmodel = $aclmodel;
46			}
47
48			public function indexAction()
49			{
50			$defaultSelectedRoleId = 0;
51
52			return new ViewModel([
53			'defaultSelectedRoleId' => $defaultSelectedRoleId,
54			'roles' => $this->aclmodel->getRoles(),
55			'resources' => $this->aclmodel->getResources(),
56			'rights' => $this->aclmodel->getRightLists(),
57			'resourcesSelected' => $this->aclmodel->getResourceByRole($defaultSelectedRoleId),
58			'rightsSelected' => $this->aclmodel->getRightLists($defaultSelectedRoleId),
59			]);
60			}
61
62			public function listresourcesandrightsAction()
63			{
64			$resources = [];
65			$rights = [];
66
67			if ($this->request->isPost()) {
			0 ignored issues – show Bug introduced 2015-11-23 21:06 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Stdlib\RequestInterface` as the method `isPost()` does only exist in the following implementations of said interface: `Zend\Http\PhpEnvironment\Request`, `Zend\Http\Request`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
68			$roleId = $this->request->getPost('roleId', 0);
			0 ignored issues – show Bug introduced 2015-11-23 21:06 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Stdlib\RequestInterface` as the method `getPost()` does only exist in the following implementations of said interface: `Zend\Http\PhpEnvironment\Request`, `Zend\Http\Request`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69
70			$resources = $this->aclmodel->getResourceByRole($roleId);
71			$rights = $this->aclmodel->getRightLists($roleId);
72			}
73
74			return new JsonModel([
75			'resources' => $resources,
76			'rights' => $rights,
77			]);
78			}
79			}
80

sitrunlab / LearnZF2

AclController::listresourcesandrightsAction() A last analyzed 2016-04-05 22:32 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AclController::listresourcesandrightsAction() A
last analyzed 2016-04-05 22:32 UTC