DownloadButtonLink - Code Metrics - sitrunlab/LearnZF2 - Measure and Improve Code Quality continuously with Scrutinizer

DownloadButtonLink A
last analyzed 2016-04-05 22:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	3
Bugs	3	Features	0

Metric	Value
wmc	3
c	3
b	3
f	0
lcom	0
cbo	2
dl	0
loc	36
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__invoke()	0	12	2

<?php

/**
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license.
 */
namespace Application\View\Helper;

use Zend\Mvc\MvcEvent;
use Zend\View\Helper\AbstractHelper;

/**
 * Download Button Link View Helper.
 */
final class DownloadButtonLink extends AbstractHelper
{
    /**
     * @var MvcEvent
     */
    private $mvcEvent;

    /**
     * Construct mvcEvent property.
     */
    public function __construct(MvcEvent $mvcEvent)
    {
        $this->mvcEvent = $mvcEvent;
    }

    /**
     * Download link.
     *
     * @param string $compress        'zip' | 'bz2' | other to make option
     * @param string $moduleNamespace
     *
     * @return string
     */
    public function __invoke($compress = 'zip', $moduleNamespace = '')
    {
        if ($moduleNamespace === '') {
            $controller = $this->mvcEvent->getRouteMatch()->getParam('controller');
            $moduleNamespace = substr($controller, 0, strpos($controller, '\\'));
        }

        return $this->view->url('download', [
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'module' => $moduleNamespace,
            'compress' => $compress,
        ]);
    }
}


1			<?php
2
3			/**
4			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
5			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
6			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
7			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
8			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
9			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
10			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
11			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
12			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
13			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
14			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
15			*
16			* This software consists of voluntary contributions made by many individuals
17			* and is licensed under the MIT license.
18			*/
19			namespace Application\View\Helper;
20
21			use Zend\Mvc\MvcEvent;
22			use Zend\View\Helper\AbstractHelper;
23
24			/**
25			* Download Button Link View Helper.
26			*/
27			final class DownloadButtonLink extends AbstractHelper
28			{
29			/**
30			* @var MvcEvent
31			*/
32			private $mvcEvent;
33
34			/**
35			* Construct mvcEvent property.
36			*/
37			public function __construct(MvcEvent $mvcEvent)
38			{
39			$this->mvcEvent = $mvcEvent;
40			}
41
42			/**
43			* Download link.
44			*
45			* @param string $compress 'zip' \| 'bz2' \| other to make option
46			* @param string $moduleNamespace
47			*
48			* @return string
49			*/
50			public function __invoke($compress = 'zip', $moduleNamespace = '')
51			{
52			if ($moduleNamespace === '') {
53			$controller = $this->mvcEvent->getRouteMatch()->getParam('controller');
54			$moduleNamespace = substr($controller, 0, strpos($controller, '\\'));
55			}
56
57			return $this->view->url('download', [
			0 ignored issues – show Bug introduced 2015-11-23 21:06 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\View\Renderer\RendererInterface` as the method `url()` does only exist in the following implementations of said interface: `Zend\View\Renderer\PhpRenderer`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
58			'module' => $moduleNamespace,
59			'compress' => $compress,
60			]);
61			}
62			}
63

sitrunlab / LearnZF2

DownloadButtonLink A last analyzed 2016-04-05 22:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

DownloadButtonLink A
last analyzed 2016-04-05 22:32 UTC