Sitewards\Setup\Service\Page\JsonFilesystemImporter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	execute()	0	8	2

<?php

/**
 * This file is part of the Setup package.
 *
 * (c) Sitewards GmbH
 */

namespace Sitewards\Setup\Service\Page;

use JMS\Serializer\Serializer;
use Sitewards\Setup\Domain\Page\PageRepositoryInterface;

final class JsonFilesystemImporter implements ImporterInterface
{
    /** @var string */
    private $filename = 'pages.json';

    /** @var PageRepositoryInterface */
    private $pageRepository;

    /** @var Serializer */
    private $serializer;

    /**
     * @param PageRepositoryInterface $pageRepository
     * @param Serializer $serializer
     */
    public function __construct(
        PageRepositoryInterface $pageRepository,
        Serializer $serializer
    )
    {
        $this->pageRepository = $pageRepository;
        $this->serializer     = $serializer;
    }

    /**
     * {@inheritdoc}
     */
    public function execute()
    {
        $pages = $this->serializer->deserialize(file_get_contents($this->filename), 'array<Sitewards\Setup\Domain\Page\Page>', 'json');

        foreach ($pages as $page) {

The expression $pages of type object|array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            $this->pageRepository->save($page);
        }
    }
}