Issues (2)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Container.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace SitePoint\Container;
4
5
use SitePoint\Container\Exception\ContainerException;
6
use SitePoint\Container\Exception\ParameterNotFoundException;
7
use SitePoint\Container\Exception\ServiceNotFoundException;
8
use SitePoint\Container\Reference\ParameterReference;
9
use SitePoint\Container\Reference\ServiceReference;
10
11
/**
12
 * A very simple dependency injection container.
13
 */
14
class Container implements ContainerInterface
15
{
16
    /**
17
     * @var array
18
     */
19
    private $services;
20
21
    /**
22
     * @var array
23
     */
24
    private $parameters;
25
26
    /**
27
     * @var array
28
     */
29
    private $serviceStore;
30
31
    /**
32
     * Constructor for the container.
33
     *
34
     * Entries into the $services array must be an associative array with a
35
     * 'class' key and an optional 'arguments' key. Where present the arguments
36
     * will be passed to the class constructor. If an argument is an instance of
37
     * ContainerService the argument will be replaced with the corresponding
38
     * service from the container before the class is instantiated. If an
39
     * argument is an instance of ContainerParameter the argument will be
40
     * replaced with the corresponding parameter from the container before the
41
     * class is instantiated.
42
     *
43
     * @param array $services   The service definitions.
44
     * @param array $parameters The parameter definitions.
45
     */
46 9
    public function __construct(array $services = [], array $parameters = [])
47
    {
48 9
        $this->services     = $services;
49 9
        $this->parameters   = $parameters;
50 9
        $this->serviceStore = [];
51 9
    }
52
53
    /**
54
     * {@inheritDoc}
55
     */
56 7
    public function get($name)
57
    {
58 7
        if (!$this->has($name)) {
59 1
            throw new ServiceNotFoundException('Service not found: '.$name);
60
        }
61
62
        // If we haven't created it, create it and save to store
63 6
        if (!isset($this->serviceStore[$name])) {
64 6
            $this->serviceStore[$name] = $this->createService($name);
65 1
        }
66
67
        // Return service from store
68 1
        return $this->serviceStore[$name];
69
    }
70
71
    /**
72
     * {@inheritDoc}
73
     */
74 7
    public function has($name)
75
    {
76 7
        return isset($this->services[$name]);
77
    }
78
79
    /**
80
     * {@inheritDoc}
81
     */
82 3
    public function getParameter($name)
83
    {
84 3
        $tokens  = explode('.', $name);
85 3
        $context = $this->parameters;
86
87 3
        while (null !== ($token = array_shift($tokens))) {
88 3
            if (!isset($context[$token])) {
89 2
                throw new ParameterNotFoundException('Parameter not found: '.$name);
90
            }
91
92 2
            $context = $context[$token];
93 2
        }
94
95 2
        return $context;
96
    }
97
98
    /**
99
     * {@inheritDoc}
100
     */
101 1
    public function hasParameter($name)
102
    {
103
        try {
104 1
            $this->getParameter($name);
105 1
        } catch (ParameterNotFoundException $exception) {
106 1
            return false;
107
        }
108
109 1
        return true;
110
    }
111
112
    /**
113
     * Attempt to create a service.
114
     *
115
     * @param string $name The service name.
116
     *
117
     * @return mixed The created service.
118
     *
119
     * @throws ContainerException On failure.
120
     */
121 6
    private function createService($name)
122
    {
123 6
        $entry = &$this->services[$name];
124
125 6
        if (!is_array($entry) || !isset($entry['class'])) {
126 1
            throw new ContainerException($name.' service entry must be an array containing a \'class\' key');
127 5
        } elseif (!class_exists($entry['class'])) {
128 1
            throw new ContainerException($name.' service class does not exist: '.$entry['class']);
129 4
        } elseif (isset($entry['lock'])) {
130 1
            throw new ContainerException($name.' contains circular reference');
131
        }
132
133 4
        $entry['lock'] = true;
134
135 4
        $arguments = isset($entry['arguments']) ? $this->resolveArguments($entry['arguments']) : [];
0 ignored issues
show
$entry['arguments'] is of type boolean, but the function expects a array.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
136
137 3
        $reflector = new \ReflectionClass($entry['class']);
138 3
        $service = $reflector->newInstanceArgs($arguments);
139
140 3
        if (isset($entry['calls'])) {
141 3
            $this->initializeService($service, $name, $entry['calls']);
0 ignored issues
show
$entry['calls'] is of type boolean, but the function expects a array.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
142 1
        }
143
144 1
        return $service;
145
    }
146
147
    /**
148
     * Resolve argument definitions into an array of arguments.
149
     *
150
     * @param array  $argumentDefinitions The service arguments definition.
151
     *
152
     * @return array The service constructor arguments.
153
     *
154
     * @throws ContainerException On failure.
155
     */
156 4
    private function resolveArguments(array $argumentDefinitions)
157
    {
158 4
        $arguments = [];
159
160 4
        foreach ($argumentDefinitions as $argumentDefinition) {
161 4
            if ($argumentDefinition instanceof ServiceReference) {
162 2
                $argumentServiceName = $argumentDefinition->getName();
163
164 2
                $arguments[] = $this->get($argumentServiceName);
165 3
            } elseif ($argumentDefinition instanceof ParameterReference) {
166 1
                $argumentParameterName = $argumentDefinition->getName();
167
168 1
                $arguments[] = $this->getParameter($argumentParameterName);
169 1
            } else {
170 3
                $arguments[] = $argumentDefinition;
171
            }
172 3
        }
173
174 3
        return $arguments;
175
    }
176
177
    /**
178
     * Initialize a service using the call definitions.
179
     *
180
     * @param object $service         The service.
181
     * @param string $name            The service name.
182
     * @param array  $callDefinitions The service calls definition.
183
     *
184
     * @throws ContainerException On failure.
185
     */
186 3
    private function initializeService($service, $name, array $callDefinitions)
187
    {
188 3
        foreach ($callDefinitions as $callDefinition) {
189 3
            if (!is_array($callDefinition) || !isset($callDefinition['method'])) {
190 1
                throw new ContainerException($name.' service calls must be arrays containing a \'method\' key');
191 2
            } elseif (!is_callable([$service, $callDefinition['method']])) {
192 1
                throw new ContainerException($name.' service asks for call to uncallable method: '.$callDefinition['method']);
193
            }
194
195 1
            $arguments = isset($callDefinition['arguments']) ? $this->resolveArguments($callDefinition['arguments']) : [];
196
197 1
            call_user_func_array([$service, $callDefinition['method']], $arguments);
198 1
        }
199 1
    }
200
}
201