Sirius\Validation\Rule\File\ImageRatio

Complexity

Total Complexity

8

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	normalizeRatio()	0	13	4
B	validate()	0	22	4

<?php
namespace Sirius\Validation\Rule\File;

use Sirius\Validation\Rule\AbstractRule;

class ImageRatio extends AbstractRule
{
    // the image width/height ration;
    // can be a number or a string like 4:3, 16:9
    const OPTION_RATIO = 'ratio';
    // how much can the image ratio diverge from the allowed ratio
    const OPTION_ERROR_MARGIN = 'error_margin';

    const MESSAGE = 'The image does must have a ratio (width/height) of {ratio})';

    const LABELED_MESSAGE = '{label} does must have a ratio (width/height) of {ratio})';

    protected $options = array(
        self::OPTION_RATIO        => 0,
        self::OPTION_ERROR_MARGIN => 0,
    );

    protected function normalizeRatio($ratio)
    {
        if (is_numeric($ratio) || $ratio == filter_var($ratio, FILTER_SANITIZE_NUMBER_FLOAT)) {
            return floatval($ratio);
        }
        if (strpos($ratio, ':') !== false) {
            list($width, $height) = explode(':', $ratio);

            return $width / $height;
        }

        return 0;
    }

    public function validate($value, $valueIdentifier = null)
    {
        $this->value = $value;
        $ratio       = $this->normalizeRatio($this->options[self::OPTION_RATIO]);
        if (! file_exists($value)) {
            $this->success = false;
        } elseif ($ratio == 0) {
            $this->success = true;
        } else {
            $imageInfo     = getimagesize($value);

            if ($imageInfo) {

The expression $imageInfo of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $actualRatio   = $imageInfo[0] / $imageInfo[1];
                $this->success = abs($actualRatio - $ratio) <= $this->options[self::OPTION_ERROR_MARGIN];
            } else {
                // no image size computed => no valid image
                return $this->success = false;
            }
        }

        return $this->success;
    }
}