ImageRatio::normalizeRatio() - Code Metrics - Inspection of "Upgrade code to PHP 7.1+" - siriusphp/validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 458234...a0327e )

by Adrian

created 2020-02-26 16:54 UTC

ImageRatio::normalizeRatio() A

↳ Parent: ImageRatio

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.8333
c	0
b	0
f	0
cc	4
nc	3
nop	1
crap	4

<?php
declare(strict_types=1);
namespace Sirius\Validation\Rule\Upload;

use Sirius\Validation\Rule\AbstractRule;
use Sirius\Validation\Util\RuleHelper;

class ImageRatio extends AbstractRule
{
    // the image width/height ration;
    // can be a number or a string like 4:3, 16:9
    const OPTION_RATIO = 'ratio';
    // how much can the image ratio diverge from the allowed ratio
    const OPTION_ERROR_MARGIN = 'error_margin';

    const MESSAGE = 'The image does must have a ratio (width/height) of {ratio})';

    const LABELED_MESSAGE = '{label} does must have a ratio (width/height) of {ratio})';

    protected $options = [
        self::OPTION_RATIO        => 0,
        self::OPTION_ERROR_MARGIN => 0,
    ];

    public function validate($value, string $valueIdentifier = null)
    {
        $this->value = $value;
        $ratio       = RuleHelper::normalizeImageRatio($this->options[self::OPTION_RATIO]);
        if (! is_array($value) || ! isset($value['tmp_name'])) {
            $this->success = false;
        } elseif (! file_exists($value['tmp_name'])) {
            $this->success = $value['error'] === UPLOAD_ERR_NO_FILE;
        } elseif ($ratio == 0) {
            $this->success = true;
        } else {
            $imageInfo     = getimagesize($value['tmp_name']);

            if (is_array($imageInfo)) {
                $actualRatio   = $imageInfo[0] / $imageInfo[1];
                $this->success = abs($actualRatio - $ratio) <= $this->options[self::OPTION_ERROR_MARGIN];
            } else {
                // no image size computed => no valid image
                return $this->success = false;
            }
        }

        return $this->success;
    }
}


1		<?php
2		declare(strict_types=1);
3		namespace Sirius\Validation\Rule\Upload;
4
5		use Sirius\Validation\Rule\AbstractRule;
6		use Sirius\Validation\Util\RuleHelper;
7
8		class ImageRatio extends AbstractRule
9		{
10		// the image width/height ration;
11		// can be a number or a string like 4:3, 16:9
12		const OPTION_RATIO = 'ratio';
13		// how much can the image ratio diverge from the allowed ratio
14		const OPTION_ERROR_MARGIN = 'error_margin';
15
16		const MESSAGE = 'The image does must have a ratio (width/height) of {ratio})';
17
18		const LABELED_MESSAGE = '{label} does must have a ratio (width/height) of {ratio})';
19
20		protected $options = [
21		self::OPTION_RATIO => 0,
22		self::OPTION_ERROR_MARGIN => 0,
23	7	];
24
25	7	public function validate($value, string $valueIdentifier = null)
26	5	{
27		$this->value = $value;
28	2	$ratio = RuleHelper::normalizeImageRatio($this->options[self::OPTION_RATIO]);
29	1	if (! is_array($value) \|\| ! isset($value['tmp_name'])) {
30		$this->success = false;
31	1	} elseif (! file_exists($value['tmp_name'])) {
32		$this->success = $value['error'] === UPLOAD_ERR_NO_FILE;
33		} elseif ($ratio == 0) {
34	1	$this->success = true;
35		} else {
36		$imageInfo = getimagesize($value['tmp_name']);
37	7
38		if (is_array($imageInfo)) {
39	7	$actualRatio = $imageInfo[0] / $imageInfo[1];
40	7	$this->success = abs($actualRatio - $ratio) <= $this->options[self::OPTION_ERROR_MARGIN];
41	7	} else {
42		// no image size computed => no valid image
43	7	return $this->success = false;
44	2	}
45	1	}
46	1
47	1	return $this->success;
48		}
49		}
50

siriusphp / validation

Push — master ( 458234...a0327e )

ImageRatio::normalizeRatio() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like