Collection::__construct() - Code Metrics - Inspection of "Remove the usage of is_uploaded_file() and move_up..." - siriusphp/upload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1a94da...33e4a6 )

by Adrian

created 2016-03-31 11:54 UTC

Collection::__construct() A

↳ Parent: Collection

Complexity

Conditions	4
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	10
ccs	9
cts	9
cp	1
rs	9.2
cc	4
eloc	6
nc	2
nop	2
crap	4

<?php

namespace Sirius\Upload\Result;

use Sirius\Upload\Container\ContainerInterface;

class Collection extends \ArrayIterator
{
    public function __construct($files = array(), ContainerInterface $container = null)
    {
        $filesArray = array();
        if (is_array($files) && !empty($files)) {
            foreach ($files as $key => $file) {
                $filesArray[$key] = new File($file, $container);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
            }
        }
        parent::__construct($filesArray);
    }

    public function clear()
    {
        foreach ($this as $file) {
            /* @var $file \Sirius\Upload\Result\File */
            $file->clear();
        }
    }

    public function confirm()
    {
        foreach ($this as $file) {
            /* @var $file \Sirius\Upload\Result\File */
            $file->confirm();
        }
    }

    public function isValid()
    {
        foreach ($this->getMessages() as $messages) {
            if ($messages) {
                return false;
            }
        }

        return true;
    }

    public function getMessages()
    {
        $messages = array();
        foreach ($this as $key => $file) {
            /* @var $file \Sirius\Upload\Result\File */
            $messages[$key] = $file->getMessages();
        }

        return $messages;
    }

}


1		<?php
2
3		namespace Sirius\Upload\Result;
4
5		use Sirius\Upload\Container\ContainerInterface;
6
7		class Collection extends \ArrayIterator
8		{
9	5	public function __construct($files = array(), ContainerInterface $container = null)
10		{
11	5	$filesArray = array();
12	5	if (is_array($files) && !empty($files)) {
13	3	foreach ($files as $key => $file) {
14	3	$filesArray[$key] = new File($file, $container);
		0 ignored issues – show Bug introduced 2016-03-31 11:46 UTC by Report Bug Copy Issue Report It seems like `$container` defined by parameter `$container` on line `9` can be `null`; however, `Sirius\Upload\Result\File::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
15	3	}
16	3	}
17	5	parent::__construct($filesArray);
18	5	}
19
20	1	public function clear()
21		{
22	1	foreach ($this as $file) {
23		/* @var $file \Sirius\Upload\Result\File */
24	1	$file->clear();
25	1	}
26	1	}
27
28	2	public function confirm()
29		{
30	2	foreach ($this as $file) {
31		/* @var $file \Sirius\Upload\Result\File */
32	2	$file->confirm();
33	2	}
34	2	}
35
36	2	public function isValid()
37		{
38	2	foreach ($this->getMessages() as $messages) {
39	2	if ($messages) {
40	1	return false;
41		}
42	1	}
43
44	1	return true;
45		}
46
47	2	public function getMessages()
48		{
49	2	$messages = array();
50	2	foreach ($this as $key => $file) {
51		/* @var $file \Sirius\Upload\Result\File */
52	2	$messages[$key] = $file->getMessages();
53	2	}
54
55	2	return $messages;
56		}
57
58		}
59

siriusphp / upload

Push — master ( 1a94da...33e4a6 )

Collection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like