Issues in Where.php (master) - Issues in master - siriusphp/sql - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Clause/Where.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace Sirius\Sql\Clause;

use Sirius\Sql\Component\Conditions;

trait Where
{
    /**
     * @var Conditions
     */
    protected $where;

    /**
     * Adds a column based condition condition
     *
     * @param string $column
     * @param null $value
     * @param string $condition
     *
     * @return $this
     */
    public function where($column, $value = null, $condition = '=')
    {
        if (is_array($column) && is_array($value)) {
            return $this->whereMultiple($column, $value, $condition);
        }
        if (count(func_get_args()) == 1) {
            $this->where->and($column, null, null);
        } else {
            $this->where->and($column, $value, $condition);
        }

        return $this;
    }

    public function whereSprintf(string $format, ...$bindInline)
    {
        $this->where->andSprintf($format, ...$bindInline);

        return $this;
    }

    /**
     * Helper method for situation when you need to query by primary key
     * which consists of multiple columns. Only works for `=` and `IN`
     *
     * @param array $columns
     * @param array $values
     * @param $condition
     *
     * @return $this
     */
    public function whereMultiple(array $columns, array $values, $condition)
    {
        $condition = strtoupper($condition);
        if (! in_array($condition, ['=', 'IN'])) {
            throw new \InvalidArgumentException(
                'For `whereMultiple` the condition `' . $condition . '` is not allowed'
            );
        }

        if (! is_array($values[0])) {
            $values = [$values];
        }

        $this->whereStartSet();
        foreach ($values as $value) {
            // match ALL of the column-value pairs
            $this->orWhereStartSet();
            foreach ($columns as $k => $column) {
                $this->where($column, $value[$k]);
            }
            $this->endSet();
        }

        $this->endSet();

        return $this;
    }

    public function orWhere(string $column, $value = null, $condition = '=')
    {
        if (count(func_get_args()) == 1) {
            $this->where->or($column, null, null);
        } else {
            $this->where->or($column, $value, $condition);
        }

        return $this;
    }

    public function orWhereSprintf(string $format, ...$bindInline)
    {
        $this->where->orSprintf($format, ...$bindInline);

        return $this;
    }

    public function whereAll(array $columnsValues, $isSet = true)
    {
        if ($isSet) {
            $this->whereStartSet();
        }

        foreach ($columnsValues as $key => $val) {
            if (is_numeric($key)) {
                $this->where($val);
            } elseif ($val === null) {
                $this->where("{$key} IS NULL");
            } else {
                $this->where("{$key}", $val);
            }
        }


        if ($isSet) {
            $this->endSet();
        }

        return $this;
    }

    public function whereStartSet()
    {
        $this->where->openGroup();

        return $this;
    }

    public function orWhereStartSet()
    {
        $this->where->openGroup('OR');

        return $this;
    }

    public function endSet()
    {
        $this->where->closeGroup();

        return $this;

        return $this;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function groupCurrentWhere()
    {
        $this->where->groupCurrent();

        return $this;
    }

    public function resetWhere()
    {
        $this->where = new Conditions($this->bindings, 'WHERE');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Sirius\Sql\Clause;
5
6		use Sirius\Sql\Component\Conditions;
7
8		trait Where
9		{
10		/**
11		* @var Conditions
12		*/
13		protected $where;
14
15		/**
16		* Adds a column based condition condition
17		*
18		* @param string $column
19		* @param null $value
20		* @param string $condition
21		*
22		* @return $this
23		*/
24	14	public function where($column, $value = null, $condition = '=')
25		{
26	14	if (is_array($column) && is_array($value)) {
27	1	return $this->whereMultiple($column, $value, $condition);
28		}
29	14	if (count(func_get_args()) == 1) {
30	4	$this->where->and($column, null, null);
31		} else {
32	11	$this->where->and($column, $value, $condition);
33		}
34
35	14	return $this;
36		}
37
38	1	public function whereSprintf(string $format, ...$bindInline)
39		{
40	1	$this->where->andSprintf($format, ...$bindInline);
41
42	1	return $this;
43		}
44
45		/**
46		* Helper method for situation when you need to query by primary key
47		* which consists of multiple columns. Only works for `=` and `IN`
48		*
49		* @param array $columns
50		* @param array $values
51		* @param $condition
52		*
53		* @return $this
54		*/
55	1	public function whereMultiple(array $columns, array $values, $condition)
56		{
57	1	$condition = strtoupper($condition);
58	1	if (! in_array($condition, ['=', 'IN'])) {
59		throw new \InvalidArgumentException(
60		'For `whereMultiple` the condition `' . $condition . '` is not allowed'
61		);
62		}
63
64	1	if (! is_array($values[0])) {
65		$values = [$values];
66		}
67
68	1	$this->whereStartSet();
69	1	foreach ($values as $value) {
70		// match ALL of the column-value pairs
71	1	$this->orWhereStartSet();
72	1	foreach ($columns as $k => $column) {
73	1	$this->where($column, $value[$k]);
74		}
75	1	$this->endSet();
76		}
77
78	1	$this->endSet();
79
80	1	return $this;
81		}
82
83	4	public function orWhere(string $column, $value = null, $condition = '=')
84		{
85	4	if (count(func_get_args()) == 1) {
86	1	$this->where->or($column, null, null);
87		} else {
88	3	$this->where->or($column, $value, $condition);
89		}
90
91	4	return $this;
92		}
93
94	1	public function orWhereSprintf(string $format, ...$bindInline)
95		{
96	1	$this->where->orSprintf($format, ...$bindInline);
97
98	1	return $this;
99		}
100
101	1	public function whereAll(array $columnsValues, $isSet = true)
102		{
103	1	if ($isSet) {
104	1	$this->whereStartSet();
105		}
106
107	1	foreach ($columnsValues as $key => $val) {
108	1	if (is_numeric($key)) {
109	1	$this->where($val);
110	1	} elseif ($val === null) {
111	1	$this->where("{$key} IS NULL");
112		} else {
113	1	$this->where("{$key}", $val);
114		}
115		}
116
117
118	1	if ($isSet) {
119	1	$this->endSet();
120		}
121
122	1	return $this;
123		}
124
125	4	public function whereStartSet()
126		{
127	4	$this->where->openGroup();
128
129	4	return $this;
130		}
131
132	2	public function orWhereStartSet()
133		{
134	2	$this->where->openGroup('OR');
135
136	2	return $this;
137		}
138
139	3	public function endSet()
140		{
141	3	$this->where->closeGroup();
142
143	3	return $this;
144
145		return $this;
		0 ignored issues – show Unused Code introduced 2020-02-08 07:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return $this;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
146		}
147
148	1	public function groupCurrentWhere()
149		{
150	1	$this->where->groupCurrent();
151
152	1	return $this;
153		}
154
155	19	public function resetWhere()
156		{
157	19	$this->where = new Conditions($this->bindings, 'WHERE');
		0 ignored issues – show Bug introduced 2020-02-08 07:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `bindings` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
158
159	19	return $this;
160		}
161		}
162

siriusphp / sql

Issues (8)

Security Analysis no request data

src/Clause/Where.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like