Sirius\Middleware\FrameRunner

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	1	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	factory()	0	8	3
A	__construct()	0	4	1
A	add()	0	7	1
A	__invoke()	0	15	3

<?php

namespace Sirius\Middleware;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

/**
 * FrameRunner Middleware inspired by this article
 * http://blog.ircmaxell.com/2016/05/all-about-middleware.html
 */
class FrameRunner
{

    /* @var runner */
    protected $next;

    protected $middleware;

    /**
     * Creates a runner based on an array of middleware
     *
     * @param array $middlewares
     * @return FrameRunner
     */
    public static function factory(array $middlewares = array())
    {
        $runner = null;
        foreach ($middlewares as $middleware) {
            $runner = $runner ? $runner->add($middleware) : new static($middleware);
        }
        return $runner;
    }

    public function __construct(callable $middleware)
    {
        $this->middleware = $middleware;
    }

    /**
     * Returns a new FrameRunner
     * @param callable $middleware
     * @return FrameRunner
     */
    public function add(callable $middleware)
    {
        $runner = new static($middleware);
        $runner->next = $this;

It seems like $this of type this<Sirius\Middleware\FrameRunner> is incompatible with the declared type object<Sirius\Middleware\Runner> of property $next.

        return $runner;
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     * @throws \Exception
     */
    public function __invoke(ServerRequestInterface $request)
    {

        $next = $this->next ?: function (ServerRequestInterface $request) {

The parameter $request is not used and could be removed.

            throw new \Exception('The first middleware in the stack calls next when it shouldn\'t');
        };

        $response = call_user_func($this->middleware, $request, $next);

        if (!$response instanceof ResponseInterface) {
            throw new \Exception('Middleware is not returning a Response object');
        }

        return $response;
    }
}