Sirius\Input\Traits\HasFiltersTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getFilters()	0	4	2
A	setFilters()	0	6	1
B	prepareFiltrator()	0	14	6

<?php

namespace Sirius\Input\Traits;

use Sirius\Input\Specs;
use Sirius\Input\InputFilter;

trait HasFiltersTrait
{

    /**
     * Get data filters for the element
     *
     * @return array
     */
    public function getFilters()
    {
        return isset($this[Specs::FILTERS]) ? $this[Specs::FILTERS] : array();
    }

    /**
     * Sets data filter for the element
     *
     * @param array $filters
     *
     * @return $this
     */
    public function setFilters($filters = array())
    {
        $this[Specs::FILTERS] = $filters;

        return $this;
    }

    /**
     * Attached the element's data filters to the filtrator object
     *
     * @param InputFilter $input
     *
     * @throws \InvalidArgumentException
     */
    protected function prepareFiltrator(InputFilter $input)
    {
        $filters = $this->getFilters();
        if (!$filters || !is_array($filters)) {

The expression $filters of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }
        $filtrator = $input->getFiltrator();
        foreach ($filters as $filter) {
            $params = is_array($filter) ? $filter : array($filter);
            if (isset($params[0])) {
                $filtrator->add($this->getName(), $params[0], @$params[1], @$params[2], @$params[3]);

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }
    }

}