Conditions | 10 |
Paths | 4 |
Total Lines | 11 |
Lines | 0 |
Ratio | 0 % |
Tests | 8 |
CRAP Score | 10 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
16 | 6 | public function filterSingle($value, string $valueIdentifier = null) |
|
17 | { |
||
18 | 6 | if (is_string($value) && $value == '' && $this->options['empty_string']) { |
|
19 | 4 | return null; |
|
20 | 5 | } elseif (is_string($value) && $value == '0' && $this->options['zero']) { |
|
21 | 2 | return null; |
|
22 | 4 | } elseif (! is_string($value) && $value == 0 && $this->options['zero']) { |
|
23 | 2 | return null; |
|
24 | } |
||
25 | 3 | return $value; |
|
26 | } |
||
27 | } |
||
28 |