PasswordHashService::hash() - Code Metrics - Inspection of "Refactor the InsertUpdateTable to use HashPassword..." - sirdiego/importr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 852cbb...117aa5 )

by diego

created 2016-10-14 13:16 UTC

PasswordHashService::hash() A

↳ Parent: PasswordHashService

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1
crap	12

<?php
namespace HDNET\Importr\Service;
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Saltedpasswords\Salt\SaltFactory;

/**
 * Class PasswordHashService.
 */
class PasswordHashService
{
    /**
     * This function takes a password as argument, salts it and returns the new password.
     *
     * @param string $password
     *
     * @return string
     */
    public function hash($password)
    {
        if (ExtensionManagementUtility::isLoaded('saltedpasswords')) {
            $salter = SaltFactory::getSaltingInstance(null, 'FE');
            $password = $salter->getHashedPassword($password);

            if ($this->isValidMd5($password)) {
                $password = 'M' . $password;
            }
        }

        return $password;
    }

    /**
     * This function checks if a password is in md5 format.
     *
     * @param string $md5
     *
     * @return int
     */
    protected function isValidMd5($md5 = '')
    {
        return preg_match('/^[a-f0-9]{32}$/', $md5);
    }
}

1			<?php
2			namespace HDNET\Importr\Service;
3			use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
4			use TYPO3\CMS\Saltedpasswords\Salt\SaltFactory;
5
6			/**
7			* Class PasswordHashService.
8			*/
9			class PasswordHashService
10			{
11			/**
12			* This function takes a password as argument, salts it and returns the new password.
13			*
14			* @param string $password
15			*
16			* @return string
17			*/
18			public function hash($password)
19			{
20			if (ExtensionManagementUtility::isLoaded('saltedpasswords')) {
21			$salter = SaltFactory::getSaltingInstance(null, 'FE');
22			$password = $salter->getHashedPassword($password);
23
24			if ($this->isValidMd5($password)) {
25			$password = 'M' . $password;
26			}
27			}
28
29			return $password;
30			}
31
32			/**
33			* This function checks if a password is in md5 format.
34			*
35			* @param string $md5
36			*
37			* @return int
38			*/
39			protected function isValidMd5($md5 = '')
40			{
41			return preg_match('/^[a-f0-9]{32}$/', $md5);
42			}
43			}

sirdiego / importr

Push — master ( 852cbb...117aa5 )

PasswordHashService::hash() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like