Sinarajabpour1998\Gateway\Drivers\Poolam

Complexity

Total Complexity

11

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	verify()	0	14	4
A	check_payment()	0	9	1
A	init()	0	21	5
A	payment_request()	0	9	1

<?php

namespace Sinarajabpour1998\Gateway\Drivers;

use Illuminate\Support\Facades\Auth;
use Sinarajabpour1998\Gateway\Abstracts\Driver;

class Poolam extends Driver
{
    public function init($amount, $orderId, $callbackUrl, $detail = [])
    {
        // Create new transaction
        $transaction = $this->createNewTransaction($orderId, $amount);

        // $amount, $transaction->id, $transaction->created_at->format('Y/m/d H:i:s'), $callbackUrl
        $result = $this->payment_request($amount, $callbackUrl);

        if(isset($detail['auto_redirect']) && $detail['auto_redirect'] == false && $result['status'] == 1) {
            $result['token'] = $result['invoice_key'];
            $result['url'] = config('gateway.information')['poolam']['api_url'] . "pay/" . $result['token'];
            return $result;

        } elseif($result['status'] == 1) {
            $this->updateTransactionData($transaction->id, ['token' => $result['invoice_key']]);
            header( 'Location: ' . config('gateway.information')['poolam']['api_url'] . "pay/" . $result['invoice_key']);
            die();

        }

        return $result;
    }

    public function verify($request)
    {
        $check = $this->check_payment($request['invoice_key']);
        $transaction = $this->getTransaction($request['invoice_key']);

        if (!is_null($transaction)) {
            if ($check['status'] == 1 && $transaction->parent->user->id == Auth::user()->id) {

The property parent does not seem to exist on Sinarajabpour1998\Gateway\Models\Transaction. Are you sure there is no database migration missing?

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $this->updateTransactionData($transaction->id, ['status' => 'successful', 'ref_no' => $check['bank_code']]);
                return $result;

The variable $result seems to be never defined.

            }

            $this->updateTransactionData($transaction->id, ['status' => 'failed', 'ref_no' => $result['errorCode'], 'description' => $result['errorDescription']]);
        }
        return $check;
    }

    protected function check_payment($inv_key){
        $ch = curl_init();
        curl_setopt($ch,CURLOPT_URL,config('gateway.information')['poolam']['api_url'] . 'check/'.$inv_key);
        curl_setopt($ch,CURLOPT_POSTFIELDS,"api_key=" . config('gateway.information')['poolam']['api_key']);
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, FALSE);
        curl_setopt($ch,CURLOPT_RETURNTRANSFER,true);
        $res = curl_exec($ch);
        curl_close($ch);
        return json_decode($res,1);

It seems like $res can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

    }

    protected function payment_request($amount,$redirect){
        $ch = curl_init();
        curl_setopt($ch,CURLOPT_URL,config('gateway.information')['poolam']['api_url'] . 'request');
        curl_setopt($ch,CURLOPT_POSTFIELDS,"api_key=" . config('gateway.information')['poolam']['api_key'] . "&amount=$amount&return_url=$redirect");
        curl_setopt($ch,CURLOPT_SSL_VERIFYPEER, FALSE);
        curl_setopt($ch,CURLOPT_RETURNTRANSFER,true);
        $res = curl_exec($ch);
        curl_close($ch);
        return json_decode($res,1);

It seems like $res can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

    }
}