sinacms / MultiHttp

src/Request.php

Doc Comments +2 added lines, -2 removed lines

@@ -183,7 +183,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return callable
      */
     public function endCallback()
     {
@@ -211,7 +211,7 @@ 
 
     /**
      * @param $key
-     * @return mixed
+     * @return string
      */
     protected static function fullOption($key)
     {

Braces +30 added lines, -11 removed lines

@@ -230,7 +230,9 @@ 
     }
     public function expects($mime)
     {
-        if (empty($mime)) return $this;
+        if (empty($mime)) {
+        	return $this;
+        }
         $this->expected_type = Mime::getFullMime($mime);
         return $this;
     }
@@ -257,7 +259,9 @@ 
      */
     public function getIni($field = null)
     {
-        if(!$field) return $this->options;
+        if(!$field) {
+        	return $this->options;
+        }
         $full = self::fullOption($field);
         return isset($this->options[$full]) ? $this->options[$full] : false;
     }
@@ -437,12 +441,15 @@ 
     public function send($isMultiCurl = false)
     {
         try {
-            if (!$this->hasInitialized)
-                $this->applyOptions();
+            if (!$this->hasInitialized) {
+                            $this->applyOptions();
+            }
             $response = $this->makeResponse($isMultiCurl);
             $response->parse();
         } catch (\Exception $e) {
-            if(!isset($response)) $response = Response::create($this, null, null, null, null);
+            if(!isset($response)) {
+            	$response = Response::create($this, null, null, null, null);
+            }
             $response->error = $e->getMessage();
             $response->errorCode = 999;
         }
@@ -506,12 +513,19 @@ 
         $this->serializeBody();
 
         //try fix url
-        if (strpos($this->options['url'], '://') === FALSE) $this->options['url'] = 'http://' . $this->options['url'];
+        if (strpos($this->options['url'], '://') === FALSE) {
+        	$this->options['url'] = 'http://' . $this->options['url'];
+        }
         $components = parse_url($this->options['url']);
-        if(FALSE === $components) throw new InvalidArgumentException('formatting url occurs error: '. $this->options['url']);
+        if(FALSE === $components) {
+        	throw new InvalidArgumentException('formatting url occurs error: '. $this->options['url']);
+        }
         if($this->withURIQuery){
-            if(isset($components['query'])) $components['query'] .= '&'. trim($this->withURIQuery);
-            else $components['query'] = trim($this->withURIQuery);
+            if(isset($components['query'])) {
+            	$components['query'] .= '&'. trim($this->withURIQuery);
+            } else {
+            	$components['query'] = trim($this->withURIQuery);
+            }
         }
         $this->options['url'] = self::combineUrl($components);
 
@@ -553,7 +567,10 @@ 
         }
 
         $cURLOptions = self::filterAndRaw($this->options);
-        if(isset($this->body))$cURLOptions[CURLOPT_POSTFIELDS] = $this->body;//use serialized body not raw data
+        if(isset($this->body)) {
+        	$cURLOptions[CURLOPT_POSTFIELDS] = $this->body;
+        }
+        //use serialized body not raw data
         curl_setopt_array($this->curlHandle, $cURLOptions);
 
         return $this;
@@ -564,7 +581,9 @@ 
         if (isset($this->options['data'])) {
             if (isset($this->sendMime)) {
                 $method = $this->sendMime;
-                if (!method_exists($this, $method)) throw new InvalidOperationException($method . ' is not exists in ' . __CLASS__);
+                if (!method_exists($this, $method)) {
+                	throw new InvalidOperationException($method . ' is not exists in ' . __CLASS__);
+                }
                 $this->body = $this->$method($this->options['data']);
             } else {
                 $this->body =  $this->options['data'];

src/JsonTrait.php

Braces +6 added lines, -2 removed lines

@@ -51,7 +51,9 @@ 
     public function unJson($body)
     {
         $parsed = json_decode($body, true);
-        if(json_last_error() !== JSON_ERROR_NONE)throw new UnexpectedResponseException('parsing json occurs error: '.  self::jsonLastErrorMsg() . ', raw body: ' .$body  );
+        if(json_last_error() !== JSON_ERROR_NONE) {
+        	throw new UnexpectedResponseException('parsing json occurs error: '.  self::jsonLastErrorMsg() . ', raw body: ' .$body  );
+        }
         return $parsed;
     }
 
@@ -59,7 +61,9 @@ 
      * @return string
      */
     private static function jsonLastErrorMsg(){
-        if(function_exists('json_last_error_msg')) return json_last_error_msg();
+        if(function_exists('json_last_error_msg')) {
+        	return json_last_error_msg();
+        }
         switch (json_last_error()) {
             case JSON_ERROR_NONE:
                 return ' - No errors';

src/Response.php

Braces +11 added lines, -6 removed lines

@@ -72,10 +72,11 @@ 
         $headers = explode(PHP_EOL, $headers);
         array_shift($headers); // HTTP HEADER
         foreach ($headers as $h) {
-            if (false !== strpos($h, ':'))
-                list($k, $v) = explode(':', $h, 2);
-            else
-                list($k, $v) = array($h, '');
+            if (false !== strpos($h, ':')) {
+                            list($k, $v) = explode(':', $h, 2);
+            } else {
+                            list($k, $v) = array($h, '');
+            }
 
             $this->header[trim($k)] = trim($v);
         }
@@ -96,9 +97,13 @@ 
     public function unserializeBody()
     {
         if (isset($this->request->expectedMime)) {
-            if (Mime::getFullMime($this->request->expectedMime) !== $this->contentType) throw new UnexpectedResponseException('expected mime can not be matched, real mime:'. $this->contentType. ', expected mime:'. Mime::getFullMime($this->request->expectedMime));
+            if (Mime::getFullMime($this->request->expectedMime) !== $this->contentType) {
+            	throw new UnexpectedResponseException('expected mime can not be matched, real mime:'. $this->contentType. ', expected mime:'. Mime::getFullMime($this->request->expectedMime));
+            }
             $method = 'un'.ucfirst($this->request->expectedMime);
-            if (!method_exists($this->request, $method)) throw new InvalidOperationException($method . ' is not exists in ' . __CLASS__);
+            if (!method_exists($this->request, $method)) {
+            	throw new InvalidOperationException($method . ' is not exists in ' . __CLASS__);
+            }
             $this->body = $this->request->{$method}($this->body);
         }
     }

src/Helper.php

Braces +5 added lines, -2 removed lines

@@ -17,8 +17,11 @@
     public static function retry($maxTimes = 2, callable $task, $sleep = 0){
         $tryTimes = 0;
         while(++$tryTimes <= $maxTimes){
-            if($task()) break;
-            else usleep(abs($sleep) * 1000000);
+            if($task()) {
+            	break;
+            } else {
+            	usleep(abs($sleep) * 1000000);
+            }
         }
         return $tryTimes;
     }