CryptoBinaryTest::testValidCryptoBinary() - Code Metrics - Inspection of "Migrate to value types" - simplesamlphp/xml-security - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#60)

by Tim

created 2025-01-18 13:36 UTC

CryptoBinaryTest::testValidCryptoBinary() A

↳ Parent: CryptoBinaryTest

Complexity

Conditions	2
Paths	3

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
nc	3
nop	2
dl	0
loc	8
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace SimpleSAML\Test\XMLSecurity\Assert;

use PHPUnit\Framework\Attributes\{CoversClass, DataProvider};
filter:
    dependency_paths: ["lib/*"]
use PHPUnit\Framework\TestCase;
use SimpleSAML\Assert\AssertionFailedException;
use SimpleSAML\XMLSecurity\Assert\Assert;

/**
 * Class \SimpleSAML\Test\XMLSecurity\Assert\CryptoBinaryTest
 *
 * @package simplesamlphp/xml-security
 */
#[CoversClass(Assert::class)]
final class CryptoBinaryTest extends TestCase
{
    /**
     * @param boolean $shouldPass
     * @param string $cryptoBinary
     */
    #[DataProvider('provideCryptoBinary')]
    public function testValidCryptoBinary(bool $shouldPass, string $cryptoBinary): void
    {
        try {
            Assert::validCryptoBinary($cryptoBinary);
            $this->assertTrue($shouldPass);
        } catch (AssertionFailedException $e) {
            $this->assertFalse($shouldPass);
        }
    }


    /**
     * @return array<string, array{0: bool, 1: string}>
     */
    public static function provideCryptoBinary(): array
    {
        return [
            'empty' => [false, ''],
            'valid' => [true, 'U2ltcGxlU0FNTHBocA=='],
            'illegal characters' => [false, '&*$(#&^@!(^%$'],
            'length not dividable by 4' => [false, 'U2ltcGxlU0FTHBocA=='],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\Test\XMLSecurity\Assert;
6
7			use PHPUnit\Framework\Attributes\{CoversClass, DataProvider};
			2 ignored issues – show Bug introduced 2025-01-18 13:26 UTC by Report Bug Copy Issue Report The type `PHPUnit\Framework\Attributes\DataProvider` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history... Bug introduced 2025-01-18 13:26 UTC by Report Bug Copy Issue Report The type `PHPUnit\Framework\Attributes\CoversClass` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use PHPUnit\Framework\TestCase;
9			use SimpleSAML\Assert\AssertionFailedException;
10			use SimpleSAML\XMLSecurity\Assert\Assert;
11
12			/**
13			* Class \SimpleSAML\Test\XMLSecurity\Assert\CryptoBinaryTest
14			*
15			* @package simplesamlphp/xml-security
16			*/
17			#[CoversClass(Assert::class)]
18			final class CryptoBinaryTest extends TestCase
19			{
20			/**
21			* @param boolean $shouldPass
22			* @param string $cryptoBinary
23			*/
24			#[DataProvider('provideCryptoBinary')]
25			public function testValidCryptoBinary(bool $shouldPass, string $cryptoBinary): void
26			{
27			try {
28			Assert::validCryptoBinary($cryptoBinary);
29			$this->assertTrue($shouldPass);
30			} catch (AssertionFailedException $e) {
31			$this->assertFalse($shouldPass);
32			}
33			}
34
35
36			/**
37			* @return array<string, array{0: bool, 1: string}>
38			*/
39			public static function provideCryptoBinary(): array
40			{
41			return [
42			'empty' => [false, ''],
43			'valid' => [true, 'U2ltcGxlU0FNTHBocA=='],
44			'illegal characters' => [false, '&*$(#&^@!(^%$'],
45			'length not dividable by 4' => [false, 'U2ltcGxlU0FTHBocA=='],
46			];
47			}
48			}
49

simplesamlphp / xml-security

Pull Request — master (#60)

CryptoBinaryTest::testValidCryptoBinary() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like