SimpleSAML\XMLSecurity\XML\ds\XPath

Complexity

Total Complexity

11

Size/Duplication

Total Lines	121
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	fromXML()	0	16	3
A	__construct()	0	4	1
A	getNamespaces()	0	3	1
A	getExpression()	0	3	1
A	setExpression()	0	3	1
A	setNamespaces()	0	8	2
A	toXML()	0	9	2

<?php

declare(strict_types=1);

namespace SimpleSAML\XMLSecurity\XML\ds;

use DOMElement;
use SimpleSAML\XML\Exception\InvalidDOMElementException;
use Webmozart\Assert\Assert;

/**
 * Class implementing the XPath element.
 *
 * @package simplesamlphp/xml-security
 */
class XPath extends AbstractDsElement
{
    /**
     * The XPath expression.
     *
     * @var string
     */
    protected string $expression;

    /**
     * A key-value array with namespaces, indexed by the prefixes used in the XPath expression.
     *
     * @var string[]
     */
    protected array $namespaces = [];


    /**
     * Construct an XPath element.
     *
     * @param string $expression The XPath expression itself.
     * @param string[] $namespaces A key - value array with namespace definitions.
     */
    public function __construct(string $expression, array $namespaces = null)
    {
        $this->setExpression($expression);
        $this->setNamespaces($namespaces);
    }


    /**
     * Get the actual XPath expression.
     *
     * @return string
     */
    public function getExpression(): string
    {
        return $this->expression;
    }


    /**
     * Set the xpath expression itself.
     *
     * @param string $expression
     */
    private function setExpression(string $expression): void
    {
        $this->expression = $expression;
    }


    /**
     * Get the list of namespaces used in this XPath expression, with their corresponding prefix as
     * the keys of each element in the array.
     *
     * @return string[]
     */
    public function getNamespaces(): array
    {
        return $this->namespaces;
    }


    /**
     * Set the list of namespaces used in this XPath expression.
     *
     * @param string[] $namespaces
     */
    private function setNamespaces(?array $namespaces): void
    {
        if ($namespaces === null) {

The condition $namespaces === null is always false.

            return;
        }
        Assert::allString($namespaces);
        Assert::allString(array_keys($namespaces));
        $this->namespaces = $namespaces;
    }


    /**
     * Convert XML into a class instance
     *
     * @param DOMElement $xml
     * @return self
     *
     * @throws \SimpleSAML\XML\Exception\InvalidDOMElementException
     *   If the qualified name of the supplied element is wrong
     */
    public static function fromXML(DOMElement $xml): object
    {
        Assert::same($xml->localName, 'XPath', InvalidDOMElementException::class);
        Assert::same($xml->namespaceURI, self::NS, InvalidDOMElementException::class);

        $namespaces = [];
        $xpath = new \DOMXPath($xml->ownerDocument);

It seems like $xml->ownerDocument can also be of type null; however, parameter $document of DOMXPath::__construct() does only seem to accept DOMDocument, maybe add an additional type check?

        /** @var \DOMNode $ns */
        foreach ($xpath->query('namespace::*', $xml) as $ns) {
            if ($xml->getAttributeNode($ns->nodeName)) {
                $namespaces[str_replace('xmlns:', '', $ns->nodeName)] =
                    $xml->getAttribute($ns->nodeName);
            }
        }

        return new self($xml->textContent, $namespaces);
    }


    /**
     * @param DOMElement|null $parent
     * @return DOMElement
     */
    public function toXML(DOMElement $parent = null): DOMElement
    {
        $e = $this->instantiateParentElement($parent);
        $e->textContent = $this->expression;

        foreach ($this->namespaces as $prefix => $namespace) {
            $e->setAttribute('xmlns:' . $prefix, $namespace);
        }
        return $e;
    }
}