SimpleSAML\XMLSecurity\XML\xenc11\OtherSource

Complexity

Total Complexity

1

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	fromXML()	0	11	1

<?php

declare(strict_types=1);

namespace SimpleSAML\XMLSecurity\XML\xenc11;

use DOMElement;
use SimpleSAML\Assert\Assert;
use SimpleSAML\XML\Exception\InvalidDOMElementException;
use SimpleSAML\XML\Exception\TooManyElementsException;

use function array_pop;

/**
 * A class implementing the xenc11:OtherSource element.
 *
 * @package simplesamlphp/xml-security
 */
final class OtherSource extends AbstractAlgorithmIdentifierType
{
    /**
     * @inheritDoc
     *
     * @throws \SimpleSAML\XML\Exception\InvalidDOMElementException
     *   If the qualified name of the supplied element is wrong
     */
    public static function fromXML(DOMElement $xml): static
    {
        Assert::same($xml->localName, static::getLocalName(), InvalidDOMElementException::class);
        Assert::same($xml->namespaceURI, static::getNamespaceURI(), InvalidDOMElementException::class);

        $parameter = Parameters::getChildrenOfClass($xml);
        Assert::maxCount($parameter, 1, TooManyElementsException::class);

        return new static(
            self::getOptionalAttribute($xml, 'Algorithm', null),

It seems like self::getOptionalAttribute($xml, 'Algorithm', null) can also be of type null; however, parameter $Algorithm of SimpleSAML\XMLSecurity\XML\xenc11\OtherSource::__construct() does only seem to accept string, maybe add an additional type check?

            array_pop($parameter),
        );
    }
}