SimpleSAML\XMLSecurity\Test\XML\ds\XPathTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testUnmarshalling()	0	13	1
A	setUpBeforeClass()	0	6	1
A	testMarshalling()	0	18	1

<?php

declare(strict_types=1);

namespace SimpleSAML\XMLSecurity\Test\XML\ds;

use PHPUnit\Framework\TestCase;
use SimpleSAML\XML\DOMDocumentFactory;
use SimpleSAML\XML\TestUtils\SerializableElementTestTrait;
use SimpleSAML\XMLSecurity\XML\ds\XPath;

use function dirname;
use function strval;

/**
 * Class \SimpleSAML\XMLSecurity\Test\XML\ds\XPathTest
 *
 * @covers \SimpleSAML\XMLSecurity\XML\ds\XPath
 *
 * @package simplesamlphp/xml-security
 */
class XPathTest extends TestCase
{
    use SerializableElementTestTrait;

The trait SimpleSAML\XML\TestUtils\SerializableElementTestTrait requires the property $documentElement which is not provided by SimpleSAML\XMLSecurity\Test\XML\ds\XPathTest.

    /**
     */
    public static function setUpBeforeClass(): void
    {
        self::$testedClass = XPath::class;

        self::$xmlRepresentation = DOMDocumentFactory::fromFile(
            dirname(__FILE__, 3) . '/resources/xml/ds_XPath.xml',
        );
    }


    public function testMarshalling(): void
    {
        $xpath = new XPath(
            'self::xenc:CipherValue[@Id="example1"]',
            [
                'xenc' => 'http://www.w3.org/2001/04/xmlenc#',
            ],
        );

        $this->assertEquals('self::xenc:CipherValue[@Id="example1"]', $xpath->getExpression());
        $namespaces = $xpath->getNamespaces();
        $this->assertCount(1, $namespaces);
        $this->assertArrayHasKey('xenc', $namespaces);

It seems like $namespaces can also be of type Countable; however, parameter $array of PHPUnit\Framework\Assert::assertArrayHasKey() does only seem to accept ArrayAccess|array, maybe add an additional type check?

        $this->assertEquals('http://www.w3.org/2001/04/xmlenc#', $namespaces['xenc']);

        $this->assertEquals(
            self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),
            strval($xpath),
        );
    }


    /**
     */
    public function testUnmarshalling(): void
    {
        $xpath = XPath::fromXML(self::$xmlRepresentation->documentElement);
        $this->assertEquals('self::xenc:CipherValue[@Id="example1"]', $xpath->getExpression());
        $namespaces = $xpath->getNamespaces();
        $this->assertCount(2, $namespaces);
        $this->assertEquals('xenc', array_keys($namespaces)[0]);

$namespaces of type Countable|iterable is incompatible with the type array expected by parameter $array of array_keys().

        $this->assertEquals('ds', array_keys($namespaces)[1]);


        $this->assertEquals(
            self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),
            strval($xpath),
        );
    }
}