simplesamlphp / xml-common

src/XML/TestUtils/ArrayizableElementTestTrait.php

<?php

declare(strict_types=1);

namespace SimpleSAML\XML\TestUtils;

use PHPUnit\Framework\Attributes\Depends;

The type PHPUnit\Framework\Attributes\Depends was not found. Maybe you did not declare it correctly or list all dependencies?

use function class_exists;

/**
 * Test for arrayizable XML classes to perform default serialization tests.
 *
 * @package simplesamlphp\xml-common
 */
trait ArrayizableElementTestTrait
{
    /** @var class-string */

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

    protected static string $testedClass;

    /** @var array */
    protected static array $arrayRepresentation;


    /**
     * Test arrayization / de-arrayization
     */
    #[Depends('testMarshalling')]
    public function testArrayization(): void
    {
        if (!class_exists(self::$testedClass)) {
            $this->markTestSkipped(

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$element to a class-string representing the XML-class being tested',
            );
        } elseif (self::$arrayRepresentation === null) {

The condition self::arrayRepresentation === null is always false.

            $this->markTestSkipped(
                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$arrayRepresentation to an array representing the XML-class being tested',
            );
        } else {
            $this->assertEquals(

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                self::$arrayRepresentation,
                self::$testedClass::fromArray(self::$arrayRepresentation)->toArray(),
            );
        }
    }
}