SimpleSAML\Test\XML\SerializableElementTestTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testSerialization()	0	18	3

<?php

declare(strict_types=1);

namespace SimpleSAML\Test\XML;

use DOMDocument;

use function class_exists;

/**
 * Test for Serializable XML classes to perform default serialization tests.
 *
 * @package simplesamlphp\xml-common
 */
trait SerializableElementTestTrait
{
    /** @var class-string */

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

    protected string $testedClass;

    /** @var \DOMDocument|null */
    protected ?DOMDocument $xmlRepresentation = null;


    /**
     * Test serialization / unserialization.
     */
    public function testSerialization(): void
    {
        if (!class_exists($this->testedClass)) {
            $this->markTestSkipped(

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'Unable to run ' . self::class . '::testSerialization(). Please set ' . self::class
                . ':$testedClass to a class-string representing the XML-class being tested',
            );
        } elseif (empty($this->xmlRepresentation)) {
            $this->markTestSkipped(
                'Unable to run ' . self::class . '::testSerialization(). Please set ' . self::class
                . ':$xmlRepresentation to a DOMDocument representing the XML-class being tested',
            );
        } else {
            /** @psalm-var \DOMElement */
            $xmlRepresentationDocument = $this->xmlRepresentation->documentElement;
            $this->assertEquals(

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->xmlRepresentation->saveXML($xmlRepresentationDocument),
                strval(unserialize(serialize($this->testedClass::fromXML($xmlRepresentationDocument)))),
            );
        }
    }
}