TopLevelElement::fromXML() - Code Metrics - Inspection of "More refactoring" - simplesamlphp/xml-common - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8413b2...00f101 )

by Tim

created 2025-06-30 19:06 UTC

TopLevelElement::fromXML() A

↳ Parent: TopLevelElement

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	37
nc	1
nop	1
dl	0
loc	53
rs	9.328
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace SimpleSAML\XMLSchema\XML;

use DOMElement;
use SimpleSAML\XML\Assert\Assert;
use SimpleSAML\XML\{SchemaValidatableElementInterface, SchemaValidatableElementTrait};
use SimpleSAML\XMLSchema\Exception\{InvalidDOMElementException, SchemaViolationException, TooManyElementsException};
use SimpleSAML\XMLSchema\Type\{BooleanValue, IDValue, NCNameValue, QNameValue, StringValue};
use SimpleSAML\XMLSchema\Type\Schema\{
    BlockSetValue,
    DerivationSetValue,
    FormChoiceValue,
    MaxOccursValue,
    MinOccursValue,
};

/**
 * Class representing the topLevelElement-type.
 *
 * @package simplesamlphp/xml-common
 */
final class TopLevelElement extends AbstractTopLevelElement implements SchemaValidatableElementInterface
{
    use SchemaValidatableElementTrait;


    /** @var string */
    public const LOCALNAME = 'element';


    /**
     * Create an instance of this object from its XML representation.
     *
     * @param \DOMElement $xml
     * @return static
     *
     * @throws \SimpleSAML\XMLSchema\Exception\InvalidDOMElementException
     *   if the qualified name of the supplied element is wrong
     */
    public static function fromXML(DOMElement $xml): static
    {
        Assert::same($xml->localName, static::getLocalName(), InvalidDOMElementException::class);
        Assert::same($xml->namespaceURI, static::NS, InvalidDOMElementException::class);

        // Prohibited attributes
        $ref = self::getOptionalAttribute($xml, 'ref', QNameValue::class, null);
        Assert::null($ref, SchemaViolationException::class);

        $form = self::getOptionalAttribute($xml, 'form', FormChoiceValue::class, null);
        Assert::null($form, SchemaViolationException::class);

        $minCount = self::getOptionalAttribute($xml, 'minCount', MinOccursValue::class, null);
        Assert::null($minCount, SchemaViolationException::class);

        $maxCount = self::getOptionalAttribute($xml, 'maxCount', MaxOccursValue::class, null);
        Assert::null($maxCount, SchemaViolationException::class);

        // The annotation
        $annotation = Annotation::getChildrenOfClass($xml);
        Assert::maxCount($annotation, 1, TooManyElementsException::class);

        // The local type
        $localSimpleType = LocalSimpleType::getChildrenOfClass($xml);
        Assert::maxCount($localSimpleType, 1, TooManyElementsException::class);

        $localComplexType = LocalComplexType::getChildrenOfClass($xml);
        Assert::maxCount($localComplexType, 1, TooManyElementsException::class);

        $localType = array_merge($localSimpleType, $localComplexType);
        Assert::maxCount($localType, 1, TooManyElementsException::class);

        // The identity constraint
        $key = Key::getChildrenOfClass($xml);
        $keyref = Keyref::getChildrenOfClass($xml);
        $unique = Unique::getChildrenOfClass($xml);
        $identityConstraint = array_merge($key, $keyref, $unique);

        return new static(
            self::getAttribute($xml, 'name', NCNameValue::class),
            array_pop($localType),
            $identityConstraint,
            self::getOptionalAttribute($xml, 'type', QNameValue::class, null),
            self::getOptionalAttribute($xml, 'substitutionGroup', QNameValue::class, null),
            self::getOptionalAttribute($xml, 'default', StringValue::class, null),
            self::getOptionalAttribute($xml, 'fixed', StringValue::class, null),
            self::getOptionalAttribute($xml, 'nillable', BooleanValue::class, null),
            self::getOptionalAttribute($xml, 'abstract', BooleanValue::class, null),
            self::getOptionalAttribute($xml, 'final', DerivationSetValue::class, null),
            self::getOptionalAttribute($xml, 'block', BlockSetValue::class, null),
            array_pop($annotation),
            self::getOptionalAttribute($xml, 'id', IDValue::class, null),
            self::getAttributesNSFromXML($xml),
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\XMLSchema\XML;
6
7			use DOMElement;
8			use SimpleSAML\XML\Assert\Assert;
9			use SimpleSAML\XML\{SchemaValidatableElementInterface, SchemaValidatableElementTrait};
10			use SimpleSAML\XMLSchema\Exception\{InvalidDOMElementException, SchemaViolationException, TooManyElementsException};
11			use SimpleSAML\XMLSchema\Type\{BooleanValue, IDValue, NCNameValue, QNameValue, StringValue};
12			use SimpleSAML\XMLSchema\Type\Schema\{
13			BlockSetValue,
14			DerivationSetValue,
15			FormChoiceValue,
16			MaxOccursValue,
17			MinOccursValue,
18			};
19
20			/**
21			* Class representing the topLevelElement-type.
22			*
23			* @package simplesamlphp/xml-common
24			*/
25			final class TopLevelElement extends AbstractTopLevelElement implements SchemaValidatableElementInterface
26			{
27			use SchemaValidatableElementTrait;
			1 ignored issue – show introduced 2025-06-30 19:08 UTC by Report Bug Copy Issue Report The trait `SimpleSAML\XML\SchemaValidatableElementTrait` requires some properties which are not provided by `SimpleSAML\XMLSchema\XML\TopLevelElement`: `$message`, `$line` Loading history...
28
29			/** @var string */
30			public const LOCALNAME = 'element';
31
32
33			/**
34			* Create an instance of this object from its XML representation.
35			*
36			* @param \DOMElement $xml
37			* @return static
38			*
39			* @throws \SimpleSAML\XMLSchema\Exception\InvalidDOMElementException
40			* if the qualified name of the supplied element is wrong
41			*/
42			public static function fromXML(DOMElement $xml): static
43			{
44			Assert::same($xml->localName, static::getLocalName(), InvalidDOMElementException::class);
45			Assert::same($xml->namespaceURI, static::NS, InvalidDOMElementException::class);
46
47			// Prohibited attributes
48			$ref = self::getOptionalAttribute($xml, 'ref', QNameValue::class, null);
49			Assert::null($ref, SchemaViolationException::class);
50
51			$form = self::getOptionalAttribute($xml, 'form', FormChoiceValue::class, null);
52			Assert::null($form, SchemaViolationException::class);
53
54			$minCount = self::getOptionalAttribute($xml, 'minCount', MinOccursValue::class, null);
55			Assert::null($minCount, SchemaViolationException::class);
56
57			$maxCount = self::getOptionalAttribute($xml, 'maxCount', MaxOccursValue::class, null);
58			Assert::null($maxCount, SchemaViolationException::class);
59
60			// The annotation
61			$annotation = Annotation::getChildrenOfClass($xml);
62			Assert::maxCount($annotation, 1, TooManyElementsException::class);
63
64			// The local type
65			$localSimpleType = LocalSimpleType::getChildrenOfClass($xml);
66			Assert::maxCount($localSimpleType, 1, TooManyElementsException::class);
67
68			$localComplexType = LocalComplexType::getChildrenOfClass($xml);
69			Assert::maxCount($localComplexType, 1, TooManyElementsException::class);
70
71			$localType = array_merge($localSimpleType, $localComplexType);
72			Assert::maxCount($localType, 1, TooManyElementsException::class);
73
74			// The identity constraint
75			$key = Key::getChildrenOfClass($xml);
76			$keyref = Keyref::getChildrenOfClass($xml);
77			$unique = Unique::getChildrenOfClass($xml);
78			$identityConstraint = array_merge($key, $keyref, $unique);
79
80			return new static(
81			self::getAttribute($xml, 'name', NCNameValue::class),
82			array_pop($localType),
83			$identityConstraint,
84			self::getOptionalAttribute($xml, 'type', QNameValue::class, null),
85			self::getOptionalAttribute($xml, 'substitutionGroup', QNameValue::class, null),
86			self::getOptionalAttribute($xml, 'default', StringValue::class, null),
87			self::getOptionalAttribute($xml, 'fixed', StringValue::class, null),
88			self::getOptionalAttribute($xml, 'nillable', BooleanValue::class, null),
89			self::getOptionalAttribute($xml, 'abstract', BooleanValue::class, null),
90			self::getOptionalAttribute($xml, 'final', DerivationSetValue::class, null),
91			self::getOptionalAttribute($xml, 'block', BlockSetValue::class, null),
92			array_pop($annotation),
93			self::getOptionalAttribute($xml, 'id', IDValue::class, null),
94			self::getAttributesNSFromXML($xml),
95			);
96			}
97			}
98

simplesamlphp / xml-common

Push — master ( 8413b2...00f101 )

TopLevelElement::fromXML() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like