Inspection of "Fix namespaced IncludeToken-attribute" - simplesamlphp/ws-security - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 90528b...cd68f4 )

by Tim

created 2024-09-23 16:00 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
         Assert::allIsInstanceOf($parts, Part::class, SchemaViolationException::class);
 
         $partNames = array_map(
-            function ($x) {
+            function($x) {
                 return $x->getName();
             },
             $parts,

Please login to merge, or discard this patch.

src/XML/sp_200702/AbstractSecureConversationTokenType.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
      * @param array<\SimpleSAML\XML\Attribute> $namespacedAttributes
      */
     final public function __construct(
-        protected Issuer|IssuerName|null $issuer,
+        protected Issuer | IssuerName | null $issuer,
         ?IncludeToken $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
      *
      * @return \SimpleSAML\WSSecurity\XML\sp_200702\Issuer|\SimpleSAML\WSSecurity\XML\sp_200702\IssuerName|null
      */
-    public function getIssuer(): Issuer|IssuerName|null
+    public function getIssuer(): Issuer | IssuerName | null
     {
         return $this->issuer;
     }

Please login to merge, or discard this patch.

src/XML/sp_200702/AbstractIssuedTokenType.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -48,7 +48,7 @@  discard block
 block discarded – undo
      */
     final public function __construct(
         protected RequestSecurityTokenTemplate $requestSecurityTokenTemplate,
-        protected Issuer|IssuerName|null $issuer,
+        protected Issuer | IssuerName | null $issuer,
         ?IncludeToken $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
      *
      * @return \SimpleSAML\WSSecurity\XML\sp_200702\Issuer|\SimpleSAML\WSSecurity\XML\sp_200702\IssuerName|null
      */
-    public function getIssuer(): Issuer|IssuerName|null
+    public function getIssuer(): Issuer | IssuerName | null
     {
         return $this->issuer;
     }

Please login to merge, or discard this patch.

src/XML/sp_200702/IncludeTokenTypeTrait.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
      *
      * @var \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken|string|null
      */
-    protected IncludeToken|string|null $includeToken;
+    protected IncludeToken | string | null $includeToken;
 
 
     /**
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
      *
      * @return \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken|string|null
      */
-    public function getIncludeToken(): IncludeToken|string|null
+    public function getIncludeToken(): IncludeToken | string | null
     {
         return $this->includeToken;
     }
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
      *
      * @param \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken|string|null $includeToken
      */
-    protected function setIncludeToken(IncludeToken|string|null $includeToken): void
+    protected function setIncludeToken(IncludeToken | string | null $includeToken): void
     {
         if (is_string($includeToken)) {
             Assert::validURI($includeToken);

Please login to merge, or discard this patch.

src/XML/sp_200507/IncludeTokenTypeTrait.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
      *
      * @var \SimpleSAML\WSSecurity\XML\sp_200507\IncludeToken|string|null
      */
-    protected IncludeToken|string|null $includeToken;
+    protected IncludeToken | string | null $includeToken;
 
 
     /**
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
      *
      * @return \SimpleSAML\WSSecurity\XML\sp_200507\IncludeToken|string|null
      */
-    public function getIncludeToken(): IncludeToken|string|null
+    public function getIncludeToken(): IncludeToken | string | null
     {
         return $this->includeToken;
     }
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
      *
      * @param \SimpleSAML\WSSecurity\XML\sp_200507\IncludeToken|string|null $includeToken
      */
-    protected function setIncludeToken(IncludeToken|string|null $includeToken): void
+    protected function setIncludeToken(IncludeToken | string | null $includeToken): void
     {
         if (is_string($includeToken)) {
             Assert::validURI($includeToken);

Please login to merge, or discard this patch.

src/XML/sp_200507/AbstractSpnegoContextTokenType.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
      */
     final public function __construct(
         protected ?Issuer $issuer,
-        IncludeToken|string|null $includeToken = null,
+        IncludeToken | string | null $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
     ) {

Please login to merge, or discard this patch.

src/XML/sp_200507/AbstractIssuedTokenType.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -49,7 +49,7 @@
 block discarded – undo
     final public function __construct(
         protected RequestSecurityTokenTemplate $requestSecurityTokenTemplate,
         protected ?Issuer $issuer,
-        IncludeToken|string|null $includeToken = null,
+        IncludeToken | string | null $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
     ) {

Please login to merge, or discard this patch.

src/XML/sp_200702/AbstractSpnegoContextTokenType.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
      * @param array<\SimpleSAML\XML\Attribute> $namespacedAttributes
      */
     final public function __construct(
-        protected Issuer|IssuerName|null $issuer,
+        protected Issuer | IssuerName | null $issuer,
         ?IncludeToken $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
      *
      * @return \SimpleSAML\WSSecurity\XML\sp_200702\Issuer|\SimpleSAML\WSSecurity\XML\sp_200702\IssuerName|null
      */
-    public function getIssuer(): Issuer|IssuerName|null
+    public function getIssuer(): Issuer | IssuerName | null
     {
         return $this->issuer;
     }

Please login to merge, or discard this patch.

src/XML/sp_200507/AbstractSecureConversationTokenType.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
      */
     final public function __construct(
         protected ?Issuer $issuer,
-        IncludeToken|string|null $includeToken = null,
+        IncludeToken | string | null $includeToken = null,
         array $elts = [],
         array $namespacedAttributes = [],
     ) {

Please login to merge, or discard this patch.

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	Assert::allIsInstanceOf($parts, Part::class, SchemaViolationException::class);
34	34
35	35	$partNames = array_map(
36		- function ($x) {
	36	+ function($x) {
37	37	return $x->getName();
38	38	},
39	39	$parts,

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	* @param array<\SimpleSAML\XML\Attribute> $namespacedAttributes
45	45	*/
46	46	final public function __construct(
47		- protected Issuer\|IssuerName\|null $issuer,
	47	+ protected Issuer \| IssuerName \| null $issuer,
48	48	?IncludeToken $includeToken = null,
49	49	array $elts = [],
50	50	array $namespacedAttributes = [],
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	*
61	61	* @return \SimpleSAML\WSSecurity\XML\sp_200702\Issuer\|\SimpleSAML\WSSecurity\XML\sp_200702\IssuerName\|null
62	62	*/
63		- public function getIssuer(): Issuer\|IssuerName\|null
	63	+ public function getIssuer(): Issuer \| IssuerName \| null
64	64	{
65	65	return $this->issuer;
66	66	}

		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	*/
49	49	final public function __construct(
50	50	protected RequestSecurityTokenTemplate $requestSecurityTokenTemplate,
51		- protected Issuer\|IssuerName\|null $issuer,
	51	+ protected Issuer \| IssuerName \| null $issuer,
52	52	?IncludeToken $includeToken = null,
53	53	array $elts = [],
54	54	array $namespacedAttributes = [],
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	*
65	65	* @return \SimpleSAML\WSSecurity\XML\sp_200702\Issuer\|\SimpleSAML\WSSecurity\XML\sp_200702\IssuerName\|null
66	66	*/
67		- public function getIssuer(): Issuer\|IssuerName\|null
	67	+ public function getIssuer(): Issuer \| IssuerName \| null
68	68	{
69	69	return $this->issuer;
70	70	}

		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	*
21	21	* @var \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken\|string\|null
22	22	*/
23		- protected IncludeToken\|string\|null $includeToken;
	23	+ protected IncludeToken \| string \| null $includeToken;
24	24
25	25
26	26	/**
		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	*
29	29	* @return \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken\|string\|null
30	30	*/
31		- public function getIncludeToken(): IncludeToken\|string\|null
	31	+ public function getIncludeToken(): IncludeToken \| string \| null
32	32	{
33	33	return $this->includeToken;
34	34	}
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	*
40	40	* @param \SimpleSAML\WSSecurity\XML\sp_200702\IncludeToken\|string\|null $includeToken
41	41	*/
42		- protected function setIncludeToken(IncludeToken\|string\|null $includeToken): void
	42	+ protected function setIncludeToken(IncludeToken \| string \| null $includeToken): void
43	43	{
44	44	if (is_string($includeToken)) {
45	45	Assert::validURI($includeToken);

		@@ -45,7 +45,7 @@
		block discarded – undo
45	45	*/
46	46	final public function __construct(
47	47	protected ?Issuer $issuer,
48		- IncludeToken\|string\|null $includeToken = null,
	48	+ IncludeToken \| string \| null $includeToken = null,
49	49	array $elts = [],
50	50	array $namespacedAttributes = [],
51	51	) {

		@@ -49,7 +49,7 @@
		block discarded – undo
49	49	final public function __construct(
50	50	protected RequestSecurityTokenTemplate $requestSecurityTokenTemplate,
51	51	protected ?Issuer $issuer,
52		- IncludeToken\|string\|null $includeToken = null,
	52	+ IncludeToken \| string \| null $includeToken = null,
53	53	array $elts = [],
54	54	array $namespacedAttributes = [],
55	55	) {

simplesamlphp / ws-security

Push — master ( 90528b...cd68f4 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch