simplesamlphp / simplesamlphp-module-webauthn

src/Controller/AuthProcess.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
 
         if ($debugEnabled) {
             $response = new RunnableResponse(
-                function ($authObject, $state) {
+                function($authObject, $state) {
                     echo $authObject->getDebugBuffer();
                     echo $authObject->getValidateBuffer();
                     echo "Debug mode, not continuing to " . ($state['FIDO2WantsRegister'] ? "credential registration page." : "destination.");

src/Controller/RegProcess.php

Spacing +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
         $id = $this->authState::saveState($state, 'webauthn:request');
         if ($debugEnabled === true) {
             $response = new RunnableResponse(
-                function ($regObject, $id) {
+                function($regObject, $id) {
                     echo $regObject->getDebugBuffer();
                     echo $regObject->getValidateBuffer();
                     echo "<form id='regform' method='POST' action='" .

src/WebAuthn/WebAuthnAuthenticationEvent.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
         }
         $keyResource = openssl_pkey_get_public($keyObject->asPEM());
         if ($keyResource === false) {
-            $this->fail("Unable to construct public key resource from PEM (was algo type ". $this->algo .").");
+            $this->fail("Unable to construct public key resource from PEM (was algo type " . $this->algo . ").");
         }
         /**
          * §7.2 STEP 17: validate signature

src/WebAuthn/WebAuthnRegistrationEvent.php

Spacing +9 added lines, -9 removed lines

@@ -23,7 +23,7 @@ 
      */
     public const PK_ALGORITHM_ECDSA = "-7";
     public const PK_ALGORITHM_RSA = "-257";
-    public const PK_ALGORITHM = [ self::PK_ALGORITHM_ECDSA, self::PK_ALGORITHM_RSA ];
+    public const PK_ALGORITHM = [self::PK_ALGORITHM_ECDSA, self::PK_ALGORITHM_RSA];
     public const AAGUID_ASSURANCE_LEVEL_NONE = 0;
     public const AAGUID_ASSURANCE_LEVEL_SELF = 1;
     public const AAGUID_ASSURANCE_LEVEL_BASIC = 2;
@@ -184,7 +184,7 @@ 
 	// Found the root CA with Google, see above, and will perform chain validation even if the spec doesn't say so.
 
 	// first, clear the openssl error backlog. We might need error data in case things go sideways.
-	while(openssl_error_string() !== false);
+	while (openssl_error_string() !== false);
 
         $stmtDecoded = $attestationArray['attStmt'];
 	if (!isset($stmtDecoded['x5c'])) {
@@ -200,7 +200,7 @@ 
            !isset($certProps['extensions']['1.2.840.113635.100.8.2'])
            || empty($certProps['extensions']['1.2.840.113635.100.8.2'])
                 ) {
-                    $this->fail( "The required nonce value is not present in the OID." );
+                    $this->fail("The required nonce value is not present in the OID.");
                 }
 	$toCompare = substr($certProps['extensions']['1.2.840.113635.100.8.2'], 6);
 	if ($nonce != $toCompare) {
@@ -208,7 +208,7 @@ 
 	}
 
 	// chain validation first
-	foreach ( $stmtDecoded['x5c'] as $runIndex => $runCert ) {
+	foreach ($stmtDecoded['x5c'] as $runIndex => $runCert) {
 		if (isset($stmtDecoded['x5c'][$runIndex + 1])) { // there is a next cert, so follow the chain
 			$certResource = openssl_x509_read(Utils\Crypto::der2pem($runCert));
 			$signerPubKey = openssl_pkey_get_public(Utils\Crypto::der2pem($stmtDecoded['x5c'][$runIndex + 1]));
@@ -222,7 +222,7 @@ 
 			$certResource = openssl_x509_read(Utils\Crypto::der2pem($runCert));
 			$signerPubKey = openssl_pkey_get_public($APPLE_WEBAUTHN_ROOT_CA);
 			if (openssl_x509_verify($certResource, $signerPubKey) != 1) {
-                                $this->fail("Error during root CA validation of the attestation chain certificate, which is ".Utils\Crypto::der2pem($runCert));
+                                $this->fail("Error during root CA validation of the attestation chain certificate, which is " . Utils\Crypto::der2pem($runCert));
                         }
 		}
 	}
@@ -254,9 +254,9 @@ 
 	// § 8.8 Bullet 5
 	$credentialDetails = openssl_pkey_get_details($credentialResource);
 	$keyDetails = openssl_pkey_get_details($keyResource);
-	if ( $credentialDetails['bits'] != $keyDetails['bits'] ||
-             $credentialDetails['key']  != $keyDetails['key']  ||
-             $credentialDetails['type'] != $keyDetails['type'] ) { 
+	if ($credentialDetails['bits'] != $keyDetails['bits'] ||
+             $credentialDetails['key'] != $keyDetails['key'] ||
+             $credentialDetails['type'] != $keyDetails['type']) { 
 		$this->fail("The credential public key does not match the certificate public key in attestationData. ("
               . $credentialDetails['key'] 
               . " - "
@@ -542,7 +542,7 @@ 
          */
         if (in_array($arrayPK['3'], self::PK_ALGORITHM)) { // we requested -7 or -257, so want to see it here
             $this->algo = $arrayPK['3'];
-            $this->pass("Public Key Algorithm is expected (".implode(' or ', WebAuthnRegistrationEvent::PK_ALGORITHM).").");
+            $this->pass("Public Key Algorithm is expected (" . implode(' or ', WebAuthnRegistrationEvent::PK_ALGORITHM) . ").");
         } else {
             $this->fail("Public Key Algorithm mismatch!");
         }

bin/updateMetadata.php

Spacing +2 added lines, -2 removed lines

@@ -5,11 +5,11 @@
 	exit(1);
 }
 $token = file_get_contents($argv[1]);
-$blobContent = json_decode(base64_decode(str_replace('_', '/', str_replace('-','+',explode('.', $token)[1]))),true);
+$blobContent = json_decode(base64_decode(str_replace('_', '/', str_replace('-', '+', explode('.', $token)[1]))), true);
 $outFormat = [];
 foreach ($blobContent['entries'] as $oneEntry) {
 	if (isset($oneEntry['aaguid'])) {
-		$outFormat[str_replace('-','',$oneEntry['aaguid'])] = [ 
+		$outFormat[str_replace('-', '', $oneEntry['aaguid'])] = [ 
                 	"model" => $oneEntry["metadataStatement"]["description"], 
 	                "RootPEMs" => $oneEntry["metadataStatement"]["attestationRootCertificates"] 
 		];

src/Controller/WebAuthn.php

Spacing +3 added lines, -3 removed lines

@@ -97,7 +97,7 @@ 
         /** @var array $state */
         $state = $this->authState::loadState($stateId, 'webauthn:request');
 
-        $templateFile = ( $state['UseInflowRegistration'] || $state['InRegistration'] ) ? 'webauthn:webauthn.twig' : 'webauthn:authentication.twig';
+        $templateFile = ($state['UseInflowRegistration'] || $state['InRegistration']) ? 'webauthn:webauthn.twig' : 'webauthn:authentication.twig';
 
         // Make, populate and layout consent form
         $t = new Template($this->config, $templateFile);
@@ -134,7 +134,7 @@ 
         $frontendData = [];
         $frontendData['challengeEncoded'] = $challengeEncoded;
         $frontendData['state'] = [];
-        foreach (['Source', 'FIDO2Scope','FIDO2Username','FIDO2Displayname','requestTokenModel'] as $stateItem) {
+        foreach (['Source', 'FIDO2Scope', 'FIDO2Username', 'FIDO2Displayname', 'requestTokenModel'] as $stateItem) {
             $frontendData['state'][$stateItem] = $state[$stateItem];
         }
 
@@ -147,7 +147,7 @@ 
         $t->data['FIDO2AuthSuccessful'] = $state['FIDO2AuthSuccessful'];
         if (
             count($state['FIDO2Tokens']) === 0 || // no tokens
-            ($state['FIDO2WantsRegister'] === true && $state['FIDO2AuthSuccessful'] !== false ) || // authenticated and wants to change something
+            ($state['FIDO2WantsRegister'] === true && $state['FIDO2AuthSuccessful'] !== false) || // authenticated and wants to change something
             $state['UseInflowRegistration'] !== true // stand-alone registration active - can change without being authenticated with second factor
         ) {
             $t->data['regURL'] = Module::getModuleURL('webauthn/regprocess?StateId=' . urlencode($stateId));