PushbackUserPass::setAuthState() - Code Metrics - Inspection of "Merge branch 'supercharged'" - simplesamlphp/simplesamlphp-module-webauthn - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f07e2d...f5be48 )

by Stefan

created 2023-04-24 15:07 UTC

PushbackUserPass::setAuthState() A

↳ Parent: PushbackUserPass

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	2
rs	10

<?php

declare(strict_types=1);

namespace SimpleSAML\Module\webauthn\Controller;

use DateTime;
use Exception;
use SimpleSAML\Auth;
use SimpleSAML\Auth\Source;
use SimpleSAML\Configuration;
use SimpleSAML\Error;
use SimpleSAML\HTTP\RunnableResponse;
use SimpleSAML\Logger;
use SimpleSAML\Module;
use SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAbstractEvent;
use SimpleSAML\Module\webauthn\WebAuthn\WebAuthnAuthenticationEvent;
use SimpleSAML\Session;
use SimpleSAML\Utils;
use SimpleSAML\XHTML\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Response;

/**
 * Controller class for the webauthn module.
 *
 * This class serves the different views available in the module.
 *
 * @package SimpleSAML\Module\webauthn
 */
class PushbackUserPass {

    /** @var \SimpleSAML\Configuration */
    protected Configuration $config;

    /** @var \SimpleSAML\Session */
    protected Session $session;

    /**
     * @var \SimpleSAML\Auth\State|string
     * @psalm-var \SimpleSAML\Auth\State|class-string
     */
    protected $authState = Auth\State::class;

    /**
     * @var \SimpleSAML\Logger|string
     * @psalm-var \SimpleSAML\Logger|class-string
     */
    protected $logger = Logger::class;

    /**
     * Controller constructor.
     *
     * It initializes the global configuration and session for the controllers implemented here.
     *
     * @param \SimpleSAML\Configuration              $config The configuration to use by the controllers.
     * @param \SimpleSAML\Session                    $session The session to use by the controllers.
     *
     * @throws \Exception
     */
    public function __construct(
            Configuration $config,
            Session $session
    ) {
        $this->config = $config;
        $this->session = $session;
    }

    /**
     * Inject the \SimpleSAML\Auth\State dependency.
     *
     * @param \SimpleSAML\Auth\State $authState
     */
    public function setAuthState(Auth\State $authState): void {
        $this->authState = $authState;
    }

    /**
     * Inject the \SimpleSAML\Logger dependency.
     *
     * @param \SimpleSAML\Logger $logger
     */
    public function setLogger(Logger $logger): void {
        $this->logger = $logger;
    }

    /**
     * @param \Symfony\Component\HttpFoundation\Request $request
     * @return (

     *   \Symfony\Component\HttpFoundation\RedirectResponse|
     *   \SimpleSAML\HTTP\RunnableResponse
     * ) A Symfony Response-object.
     */
    public function main(Request $request): Response {
        $this->logger::info('FIDO2 Supercharged - Redirecting to username/password validation');

        $stateId = $request->query->get('StateId');
        if ($stateId === null) {
            throw new Error\BadRequest('Missing required StateId query parameter.');
        }

        $moduleConfig = Configuration::getOptionalConfig('module_webauthn.php');
        $authsources = Configuration::getConfig('authsources.php')->toArray();
        $authsourceString = $moduleConfig->getString('password_authsource');
        $classname = get_class(Source::getById($authsourceString));
        switch ($classname) {
            case 'SimpleSAML\Module\radius\Auth\Source\Radius':
                $overrideSource = new class(['AuthId' => $authsourceString], $authsources[$authsourceString]) extends \SimpleSAML\Module\radius\Auth\Source\Radius {
filter:
    dependency_paths: ["lib/*"]
                    public function loginOverload(string $username, string $password): array {
                        return $this->login($username, $password);
                    }
                };
                break;
            case 'SimpleSAML\Module\radius\Auth\Source\Ldap':
                $overrideSource = new class(['AuthId' => $authsourceString], $authsources[$authsourceString]) extends \SimpleSAML\Module\ldap\Auth\Source\Ldap {
filter:
    dependency_paths: ["lib/*"]
                    public function loginOverload(string $username, string $password): array {
                        return $this->login($username, $password);
                    }
                };
                break;
            default:
                throw new Exception("Unable to pushback authentication to source :$classname:");
        }


        $attribs = $overrideSource->loginOverload($request->request->get("username"), $request->request->get("password"));

        
        $state = $this->authState::loadState($stateId, 'webauthn:request');
        
        // this is the confirmed username, we store it just like the Passwordless
        // one would have been
        
        $state['Attributes'][$state['FIDO2AttributeStoringUsername']] = [ $request->request->get("username") ];

        // we deliberately do not store any additional attributes - these have
        // to be retrieved from the same authproc that would retrieve them
        // in Passwordless mode

        // now properly return our final state to the framework
        Source::completeAuth($state);
        Source::completeAuth(/** @scrutinizer ignore-type */ $state);
        
    }

    public function login(string $username, string $password): array {
        throw new Exception("Ugh ($username, $password).");
    }

}


simplesamlphp / simplesamlphp-module-webauthn

Push — master ( f07e2d...f5be48 )

PushbackUserPass::setAuthState() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like