Conditions | 10 |
Paths | 90 |
Total Lines | 128 |
Code Lines | 91 |
Lines | 0 |
Ratio | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
85 | public function main(Request $request): Template |
||
86 | { |
||
87 | AccessCheck::checkAccess($this->moduleConfig); |
||
88 | |||
89 | /** |
||
90 | * Check input parameters |
||
91 | */ |
||
92 | $preferRule = $request->query->get('rule'); |
||
93 | $preferRule2 = $request->query->get('rule2'); |
||
94 | if ($preferRule2 === '_') { |
||
95 | $preferRule2 = null; |
||
96 | } |
||
97 | |||
98 | $preferTime = strval($request->query->get('time')); |
||
99 | $preferTimeRes = strval($request->query->get('res')); |
||
100 | $delimiter = strval($request->query->get('delimiter')); |
||
101 | |||
102 | /** |
||
103 | * Create statistics data. |
||
104 | */ |
||
105 | $ruleset = new Ruleset($this->moduleConfig); |
||
106 | $statrule = $ruleset->getRule($preferRule); |
||
107 | $rule = $statrule->getRuleID(); |
||
108 | |||
109 | /** |
||
110 | * Prepare template. |
||
111 | */ |
||
112 | $t = new Template($this->config, 'statistics:statistics.twig'); |
||
113 | $t->data = [ |
||
114 | 'delimiter' => $delimiter, |
||
115 | 'pageid' => 'statistics', |
||
116 | 'header' => 'stat', |
||
117 | 'available_rules' => $ruleset->availableRulesNames(), |
||
118 | 'selected_rule' => $rule, |
||
119 | 'selected_rule2' => $preferRule2, |
||
120 | ]; |
||
121 | |||
122 | $t->data['available_rules'] = $ruleset->availableRulesNames(); |
||
123 | $t->data['current_rule'] = $t->data['available_rules'][$rule]; |
||
124 | $t->data['post_rule'] = $this->getBaseURL($t, 'post', 'rule'); |
||
125 | $t->data['post_res'] = $this->getBaseURL($t, 'post', 'res'); |
||
126 | $t->data['post_time'] = $this->getBaseURL($t, 'post', 'time'); |
||
127 | $t->data['available_timeres'] = []; |
||
128 | $t->data['available_times'] = []; |
||
129 | |||
130 | try { |
||
131 | $dataset = $statrule->getDataset($preferTimeRes, $preferTime); |
||
132 | $delimiter = $dataset->getDelimiter(); |
||
133 | $dataset->setDelimiter($delimiter); |
||
134 | $dataset->aggregateSummary(); |
||
135 | $dataset->calculateMax(); |
||
136 | } catch (Exception $e) { |
||
137 | $t->data['error'] = "No data available"; |
||
138 | return $t; |
||
139 | } |
||
140 | |||
141 | $fileslot = $dataset->getFileslot(); |
||
142 | $timeres = $dataset->getTimeRes(); |
||
143 | $timeNavigation = $statrule->getTimeNavigation($timeres, $preferTime); |
||
144 | $piedata = $dataset->getPieData(); |
||
145 | $datasets = [$dataset->getPercentValues()]; |
||
146 | $axis = $dataset->getAxis(); |
||
147 | $maxes = [$dataset->getMax()]; |
||
148 | |||
149 | if (isset($preferRule2)) { |
||
150 | $statrule = $ruleset->getRule($preferRule2); |
||
151 | $t->data['available_timeres'] = $statrule->availableTimeRes(); |
||
152 | $t->data['available_times'] = $statrule->availableFileSlots($timeres); |
||
153 | } |
||
154 | |||
155 | |||
156 | $t->data['results'] = $dataset->getResults(); |
||
157 | $t->data['summaryDataset'] = $dataset->getSummary(); |
||
158 | $t->data['debugdata'] = $dataset->getDebugData(); |
||
159 | $t->data['topdelimiters'] = $dataset->getTopDelimiters(); |
||
160 | $t->data['availdelimiters'] = $dataset->availDelimiters(); |
||
161 | $t->data['available_times_prev'] = $timeNavigation['prev']; |
||
162 | $t->data['available_times_next'] = $timeNavigation['next']; |
||
163 | $t->data['selected_rule'] = $rule; |
||
164 | $t->data['selected_time'] = $fileslot; |
||
165 | $t->data['selected_timeres'] = $timeres; |
||
166 | $t->data['post_d'] = $this->getBaseURL($t, 'post', 'd'); |
||
167 | |||
168 | $dimx = $this->moduleConfig->getOptionalValue('dimension.x', 800); |
||
169 | $dimy = $this->moduleConfig->getOptionalValue('dimension.y', 350); |
||
170 | $grapher = new Graph\GoogleCharts($dimx, $dimy); |
||
171 | $t->data['imgurl'] = $grapher->show($axis['axis'], $axis['axispos'], $datasets, $maxes); |
||
172 | |||
173 | if (isset($preferRule2)) { |
||
174 | try { |
||
175 | $dataset2 = $statrule->getDataset($preferTimeRes, $preferTime); |
||
176 | $dataset2->aggregateSummary(); |
||
177 | $dataset2->calculateMax(); |
||
178 | $datasets[] = $dataset2->getPercentValues(); |
||
179 | $maxes[] = $dataset2->getMax(); |
||
180 | |||
181 | if ($request->query->get('format') === 'csv') { |
||
182 | header('Content-type: text/csv'); |
||
183 | header('Content-Disposition: attachment; filename="simplesamlphp-data.csv"'); |
||
184 | $data = $dataset->getDebugData(); |
||
185 | foreach ($data as $de) { |
||
186 | if (isset($de[1])) { |
||
187 | echo '"' . $de[0] . '",' . $de[1] . "\n"; |
||
188 | } |
||
189 | } |
||
190 | exit; |
||
191 | } else { |
||
192 | $t->data['error'] = 'Export format not supported'; |
||
193 | return $t; |
||
194 | } |
||
195 | } catch (Exception $e) { |
||
196 | $t->data['error'] = "No data available to compare"; |
||
197 | return $t; |
||
198 | } |
||
199 | } |
||
200 | |||
201 | if (!empty($piedata)) { |
||
202 | $t->data['pieimgurl'] = $grapher->showPie($dataset->getDelimiterPresentationPie(), $piedata); |
||
203 | } |
||
204 | |||
205 | $t->data['selected_rule2'] = $preferRule2; |
||
206 | $t->data['selected_delimiter'] = $delimiter; |
||
207 | $t->data['post_rule2'] = $this->getBaseURL($t, 'post', 'rule2'); |
||
208 | $t->data['get_times_prev'] = $this->getBaseURL($t, 'get', 'time', $t->data['available_times_prev']); |
||
209 | $t->data['get_times_next'] = $this->getBaseURL($t, 'get', 'time', $t->data['available_times_next']); |
||
210 | $t->data['delimiterPresentation'] = $dataset->getDelimiterPresentation(); |
||
211 | |||
212 | return $t; |
||
213 | } |
||
250 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.