SQL1Compat::__construct() - Code Metrics - Inspection of "Support aggregation of attributes from multiple da..." - simplesamlphp/simplesamlphp-module-sqlauth - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#20)

unknown

created 2025-10-23 22:21 UTC

SQL1Compat::__construct() B

↳ Parent: SQL1Compat

Complexity

Conditions	6
Paths	8

Size

Total Lines	39
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	20
c	1
b	0
f	0
nc	8
nop	2
dl	0
loc	39
rs	8.9777

<?php

declare(strict_types=1);

namespace SimpleSAML\Module\sqlauth\Auth\Source;

/**
 * @package SimpleSAMLphp
 */

class SQL1Compat extends SQL2
{
    /**
     * Constructor for this authentication source.
     *
     * @param array $info  Information about this authentication source.
     * @param array $config  Configuration.
     */
    public function __construct(array $info, array $config)
    {
        /* Transform SQL (version 1) config to SQL2 config
         * Version 1 supported only one database, but multiple queries. The first query was defined
         * to be the "authentication query", all subsequent queries were "attribute queries".
         */
        $v2config = [
            'sqlauth:SQL2',
            'databases' => [
                'default' => [
                    'dsn' => $config['dsn'],
                    'username' => $config['username'],
                    'password' => $config['password'],
                ],
            ],

            'auth_queries' => [
                'default' => [
                    'database' => 'default',
                    'query' => is_array($config['query']) ? $config['query'][0] : $config['query'],
                ],
            ],
        ];

        if (array_key_exists('username_regex', $config)) {
            $v2config['auth_queries']['default']['username_regex'] = $config['username_regex'];
        }

        if (is_array($config['query']) && count($config['query']) > 1) {
            $v2config['attr_queries'] = [];
            for ($i = 1; $i < count($config['query']); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $v2config['attr_queries']['query' . $i] = [
                    'database' => 'default',
                    'query' => $config['query'][$i],
                ];
            }
        }

        parent::__construct($info, $v2config);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\Module\sqlauth\Auth\Source;
6
7			/**
8			* @package SimpleSAMLphp
9			*/
10
11			class SQL1Compat extends SQL2
12			{
13			/**
14			* Constructor for this authentication source.
15			*
16			* @param array $info Information about this authentication source.
17			* @param array $config Configuration.
18			*/
19			public function __construct(array $info, array $config)
20			{
21			/* Transform SQL (version 1) config to SQL2 config
22			* Version 1 supported only one database, but multiple queries. The first query was defined
23			* to be the "authentication query", all subsequent queries were "attribute queries".
24			*/
25			$v2config = [
26			'sqlauth:SQL2',
27			'databases' => [
28			'default' => [
29			'dsn' => $config['dsn'],
30			'username' => $config['username'],
31			'password' => $config['password'],
32			],
33			],
34
35			'auth_queries' => [
36			'default' => [
37			'database' => 'default',
38			'query' => is_array($config['query']) ? $config['query'][0] : $config['query'],
39			],
40			],
41			];
42
43			if (array_key_exists('username_regex', $config)) {
44			$v2config['auth_queries']['default']['username_regex'] = $config['username_regex'];
45			}
46
47			if (is_array($config['query']) && count($config['query']) > 1) {
48			$v2config['attr_queries'] = [];
49			for ($i = 1; $i < count($config['query']); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2025-10-22 00:56 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
50			$v2config['attr_queries']['query' . $i] = [
51			'database' => 'default',
52			'query' => $config['query'][$i],
53			];
54			}
55			}
56
57			parent::__construct($info, $v2config);
58			}
59			}
60

simplesamlphp / simplesamlphp-module-sqlauth

Pull Request — master (#20)

SQL1Compat::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like