SmartName::getFullName() - Code Metrics - Inspection of "Initial import" - simplesamlphp/simplesamlphp-module-smartattributes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 52914c...5ecbc9 )

by Tim

created 2019-05-27 09:53 UTC

SmartName::getFullName() B

↳ Parent: SmartName

Complexity

Conditions	11
Paths	16

Size

Total Lines	36
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	18
nc	16
nop	1
dl	0
loc	36
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php

namespace SimpleSAML\Module\smartattributes\Auth\Process;

use Webmozart\Assert\Assert;

/**
 * Filter to set name in a smart way, based on available name attributes.
 *
 * @author Andreas Åkre Solberg, UNINETT AS.
 * @package SimpleSAMLphp
 */
class SmartName extends \SimpleSAML\Auth\ProcessingFilter
{
    /**
     * Attributes which should be added/appended.
     *
     * @var array Associative array of arrays.
     */
    private $attributes = [];



    /**
     * @param array $attributes
     * @return string|null
     */
    private function getFullName($attributes)
    {
        if (isset($attributes['displayName'])) {
            return $attributes['displayName'][0];
        }

        if (isset($attributes['cn'])) {
            if (count(explode(' ', $attributes['cn'][0])) > 1) {
                return $attributes['cn'][0];
            }
        }

        if (isset($attributes['sn']) && isset($attributes['givenName'])) {
            return $attributes['givenName'][0].' '.$attributes['sn'][0];
        }

        if (isset($attributes['cn'])) {
            return $attributes['cn'][0];
        }

        if (isset($attributes['sn'])) {
            return $attributes['sn'][0];
        }

        if (isset($attributes['givenName'])) {
            return $attributes['givenName'][0];
        }

        if (isset($attributes['eduPersonPrincipalName'])) {
            $localname = $this->getLocalUser($attributes['eduPersonPrincipalName'][0]);
            if (isset($localname)) {
                return $localname;
            }
        }

        return null;
    }


    /**
     * @param string $userid
     * @return string|null
     */
    private function getLocalUser($userid)
    {
        if (strpos($userid, '@') === false) {
            return null;
        }
        $decomposed = explode('@', $userid);
        if (count($decomposed) === 2) {
            return $decomposed[0];
        }
        return null;
    }


    /**
     * Apply filter to add or replace attributes.
     *
     * Add or replace existing attributes with the configured values.
     *
     * @param array &$request  The current request
     * @return void
     */
    public function process(&$request)
    {
        Assert::isArray($request);
        Assert::keyExists($request, 'Attributes');

        $attributes = &$request['Attributes'];

        $fullname = $this->getFullName($attributes);

        if (isset($fullname)) {
            $request['Attributes']['smartname-fullname'] = [$fullname];
        }
    }
}


1			<?php
2
3			namespace SimpleSAML\Module\smartattributes\Auth\Process;
4
5			use Webmozart\Assert\Assert;
6
7			/**
8			* Filter to set name in a smart way, based on available name attributes.
9			*
10			* @author Andreas Åkre Solberg, UNINETT AS.
11			* @package SimpleSAMLphp
12			*/
13			class SmartName extends \SimpleSAML\Auth\ProcessingFilter
14			{
15			/**
16			* Attributes which should be added/appended.
17			*
18			* @var array Associative array of arrays.
19			*/
20			private $attributes = [];
			0 ignored issues – show introduced 2019-05-27 09:56 UTC by Report Bug Copy Issue Report The private property `$attributes` is not used, and could be removed. Loading history...
21
22
23			/**
24			* @param array $attributes
25			* @return string\|null
26			*/
27			private function getFullName($attributes)
28			{
29			if (isset($attributes['displayName'])) {
30			return $attributes['displayName'][0];
31			}
32
33			if (isset($attributes['cn'])) {
34			if (count(explode(' ', $attributes['cn'][0])) > 1) {
35			return $attributes['cn'][0];
36			}
37			}
38
39			if (isset($attributes['sn']) && isset($attributes['givenName'])) {
40			return $attributes['givenName'][0].' '.$attributes['sn'][0];
41			}
42
43			if (isset($attributes['cn'])) {
44			return $attributes['cn'][0];
45			}
46
47			if (isset($attributes['sn'])) {
48			return $attributes['sn'][0];
49			}
50
51			if (isset($attributes['givenName'])) {
52			return $attributes['givenName'][0];
53			}
54
55			if (isset($attributes['eduPersonPrincipalName'])) {
56			$localname = $this->getLocalUser($attributes['eduPersonPrincipalName'][0]);
57			if (isset($localname)) {
58			return $localname;
59			}
60			}
61
62			return null;
63			}
64
65
66			/**
67			* @param string $userid
68			* @return string\|null
69			*/
70			private function getLocalUser($userid)
71			{
72			if (strpos($userid, '@') === false) {
73			return null;
74			}
75			$decomposed = explode('@', $userid);
76			if (count($decomposed) === 2) {
77			return $decomposed[0];
78			}
79			return null;
80			}
81
82
83			/**
84			* Apply filter to add or replace attributes.
85			*
86			* Add or replace existing attributes with the configured values.
87			*
88			* @param array &$request The current request
89			* @return void
90			*/
91			public function process(&$request)
92			{
93			Assert::isArray($request);
94			Assert::keyExists($request, 'Attributes');
95
96			$attributes = &$request['Attributes'];
97
98			$fullname = $this->getFullName($attributes);
99
100			if (isset($fullname)) {
101			$request['Attributes']['smartname-fullname'] = [$fullname];
102			}
103			}
104			}
105

simplesamlphp / simplesamlphp-module-smartattributes

Push — master ( 52914c...5ecbc9 )

SmartName::getFullName() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like