SimpleSAML\Module\metaedit\Controller\MetaEditor::edit()

Complexity

Conditions	10
Paths	52

Size

Total Lines	88
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function edit(Request $request): Template
    {
        /* Load configuration and metadata */
        $moduleConfig = Configuration::getConfig('module_metaedit.php');

        $mdh = new Metadata\MetaDataStorageHandlerSerialize($moduleConfig->getValue('metahandlerConfig', null));

It seems like $moduleConfig->getValue('metahandlerConfig', null) can also be of type null; however, parameter $config of SimpleSAML\Metadata\MetaDataStorageHandlerSerialize::__construct() does only seem to accept array, maybe add an additional type check?

        $authsource = $moduleConfig->getValue('auth', 'login-admin');
        $useridattr = $moduleConfig->getValue('useridattr', 'eduPersonPrincipalName');

        $as = new Auth\Simple($authsource);
        $as->requireAuth();

        $attributes = $as->getAttributes();
        // Check if userid exists
        if (!isset($attributes[$useridattr])) {
            throw new Error\Exception('User ID is missing');
        }
        $userid = $attributes[$useridattr][0];

        $entityId = $request->get('entityid');
        $xmlMetadata = $request->get('xmlmetadata');

        if ($entityId !== null) {
            $metadata = $mdh->getMetadata($entityId, 'saml20-sp-remote');
            $this->requireOwnership($metadata, $userid);

It seems like $metadata can also be of type null; however, parameter $metadata of SimpleSAML\Module\metaedit\Controller\MetaEditor::requireOwnership() does only seem to accept array, maybe add an additional type check?

        } elseif ($xmlMetadata !== null) {
            $xmlUtils = new Utils\XML();
            $xmlUtils->checkSAMLMessage($xmldata, 'saml-meta');

The variable $xmldata seems to be never defined.

            $entities = Metadata\SAMLParser::parseDescriptorsString($xmlMetadata);
            $entity = array_pop($entities);
            $metadata =  $entity->getMetadata20SP();

            /* Trim metadata endpoint arrays. */
            $metadata['AssertionConsumerService'] = [
                Utils\Config\Metadata::getDefaultEndpoint(
                    $metadata['AssertionConsumerService'],
                    [Constants::BINDING_HTTP_POST]
                )
            ];
            $metadata['SingleLogoutService'] = [
                Utils\Config\Metadata::getDefaultEndpoint(
                    $metadata['SingleLogoutService'],
                    [Constants::BINDING_HTTP_REDIRECT]
                )
            ];
        } else {
            $metadata = [
                'owner' => $userid,
            ];
        }

        $editor = new Editor();

        if ($request->get('submit')) {
            $editor->checkForm($request->request);

$request->request of type Symfony\Component\HttpFoundation\InputBag is incompatible with the type array expected by parameter $request of SimpleSAML\Module\metaedit\MetaEditor::checkForm().

            $metadata = $editor->formToMeta($request->request, [], ['owner' => $userid]);

$request->request of type Symfony\Component\HttpFoundation\InputBag is incompatible with the type array expected by parameter $request of SimpleSAML\Module\metaedit\MetaEditor::formToMeta().

            $wasEntityId = $request->get('was-entityid');
            if (($wasEntityId !== null) && ($wasEntityId !== $metadata['entityid'])) {
                $premetadata = $mdh->getMetadata($_REQUEST['was-entityid'], 'saml20-sp-remote');
                $this->requireOwnership($premetadata, $userid);
                $mdh->deleteMetadata($_REQUEST['was-entityid'], 'saml20-sp-remote');
            }

            $testmetadata = null;

The assignment to $testmetadata is dead and can be removed.

            try {
                $testmetadata = $mdh->getMetadata($metadata['entityid'], 'saml20-sp-remote');
            } catch (Exception $e) {
                // catch
            }

            if ($testmetadata) {
                $this->requireOwnership($testmetadata, $userid);
            }

            $result = $mdh->saveMetadata($metadata['entityid'], 'saml20-sp-remote', $metadata);
            if ($result === false) {
                throw new Error\Exception("Could not save metadata. See log for details");
            }

            return new Template($this->config, 'metaedit:saved.twig');
        }

        $form = $editor->metaToForm($metadata);

        $t = new Template($this->config, 'metaedit:formedit.twig');
        $t->data['form'] = $form;
        $t->send();

In this branch, the function will implicitly return null which is incompatible with the type-hinted return SimpleSAML\XHTML\Template. Consider adding a return statement or allowing null as return value.

    }