AttributeAddUsersGroups::getGroups() - Code Metrics - Inspection of "WIP: Migrate to symfony/ldap" - simplesamlphp/simplesamlphp-module-ldap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#28)

by Tim

created 2022-01-28 09:31 UTC

AttributeAddUsersGroups::getGroups() C

↳ Parent: AttributeAddUsersGroups

Complexity

Conditions	10
Paths	17

Size

Total Lines	199
Code Lines	128

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	0	Features	0

Metric	Value
cc	10
eloc	128
c	6
b	0
f	0
nc	17
nop	1
dl	0
loc	199
rs	6.1333

How to fix Long Method Complexity

<?php

/**
 * Does a reverse membership lookup on the logged in user,
 * looking for groups it is a member of and adds them to
 * a defined attribute, in DN format.
 *
 * @package simplesamlphp/simplesamlphp-module-ldap
 */

declare(strict_types=1);

namespace SimpleSAML\Module\ldap\Auth\Process;

use SimpleSAML\Assert\Assert;
use SimpleSAML\Error;
use SimpleSAML\Logger;
use SimpleSAML\Module\ldap\Utils\Ldap as LdapUtils;
use SimpleSAML\Utils;
use Symfony\Component\Ldap\Adapter\ExtLdap\Query;

class AttributeAddUsersGroups extends BaseFilter
{
    /** @var string */
    protected string $searchUsername;

    /** @var string */
    protected string $searchPassword;

    /** @var string */
    protected string $product;


    /**
     * Initialize this filter.
     *
     * @param array $config Configuration information about this filter.
     * @param mixed $reserved For future use.
     */
    public function __construct(array $config, $reserved)
    {
        parent::__construct($config, $reserved);

        // Get filter specific config options
        $this->searchUsername = $this->config->getString('search.username');
        $this->searchPassword = $this->config->getString('search.password', null);
        $this->product = $this->config->getString('ldap.product', 'ActiveDirectory');
    }


    /**
     * LDAP search filters to be added to the base filters for this authproc-filter.
     * It's an array of key => value pairs that will be translated to (key=value) in the ldap query.
     *
     * @var array
     */
    protected array $additional_filters;


    /**
     * This is run when the filter is processed by SimpleSAML.
     * It will attempt to find the current users groups using
     * the best method possible for the LDAP product. The groups
     * are then added to the request attributes.
     *
     * @throws \SimpleSAML\Error\Exception
     * @param array &$state
     */
    public function process(array &$state): void
    {
        Assert::keyExists($state, 'Attributes');

        // Log the process
        Logger::debug(sprintf(
            '%s : Attempting to get the users groups...',
            $this->title
        ));

        $this->additional_filters = $this->config->getArray('additional_filters', []);

        // Reference the attributes, just to make the names shorter
        $attributes = &$state['Attributes'];
        $map = &$this->attribute_map;

        // Get the users groups from LDAP
        $groups = $this->getGroups($attributes);

        // If there are none, do not proceed
        if (empty($groups)) {
            return;
        }

        // Make the array if it is not set already
        if (!isset($attributes[$map['groups']])) {
            $attributes[$map['groups']] = [];
        }

        // Must be an array, else cannot merge groups
        if (!is_array($attributes[$map['groups']])) {
            throw new Error\Exception(sprintf(
                '%s : The group attribute [%s] is not an array of group DNs. %s',
                $this->title,
                $map['groups'],
                $this->varExport($attributes[$map['groups']])
            ));
        }

        // Add the users group(s)
        $group_attribute = &$attributes[$map['groups']];
        $group_attribute = array_merge($group_attribute, $groups);
        $group_attribute = array_unique($group_attribute);

        // All done
        Logger::debug(sprintf(
            '%s : Added users groups to the group attribute[%s]: %s',
            $this->title,
            $map['groups'],
            implode('; ', $groups)
        ));
    }


    /**
     * Will perform a search using the required attribute values from the user to
     * get their group membership, recursively.
     *
     * @throws \SimpleSAML\Error\Exception
     * @param array $attributes
     * @return array
     */
    protected function getGroups(array $attributes): array
    {
        // Log the request
        Logger::debug(sprintf(
            '%s : Checking for groups based on the best method for the LDAP product.',
            $this->title
        ));

        $ldapUtils = new LdapUtils();
        $ldapUtils->bind($this->ldapObject, $this->searchUsername, $this->searchPassword);

        $options = [
            'scope' => $this->config->getString('search.scope', Query::SCOPE_SUB),
            'timeout' => $this->config->getInteger('timeout', 3),
        ];

        // Reference the map, just to make the name shorter
        $map = &$this->attribute_map;


        // All map-properties are guaranteed to exist and have a default value
        $dn_attribute = $map['dn'];
        $return_attribute = $map['return'];

        // Based on the directory service, search LDAP for groups
        // If any attributes are needed, prepare them before calling search method
        switch ($this->product) {
            case 'ActiveDirectory':
                // Log the AD specific search
                Logger::debug(sprintf(
                    '%s : Searching LDAP using ActiveDirectory specific method.',
                    $this->title
                ));

                // Make sure the defined DN attribute exists
                if (!isset($attributes[$dn_attribute])) {
                    Logger::warning(sprintf(
                        "%s : The DN attribute [%s] is not defined in the user's Attributes: %s",
                        $this->title,
                        $dn_attribute,
                        implode(', ', array_keys($attributes)),
                    ));

                    return [];
                }

                // Make sure the defined DN attribute has a value
                if (!isset($attributes[$dn_attribute][0]) || !$attributes[$dn_attribute][0]) {
                    Logger::warning(sprintf(
                        '%s : The DN attribute [%s] does not have a [0] value defined. %s',
                        $this->title,
                        $dn_attribute,
                        $this->varExport($attributes[$dn_attribute])
                    ));

                    return [];
                }

                // Log the search
                $arrayUtils = new Utils\Arrays();
                Logger::debug(sprintf(
                    '%s : Searching ActiveDirectory group membership.'
                        . ' DN: %s DN Attribute: %s Member Attribute: %s Type Attribute: %s Type Value: %s Base: %s',
                    $this->title,
                    $attributes[$dn_attribute][0],
                    $dn_attribute,
                    $map['member'],
                    $map['type'],
                    $this->type_map['group'],
                    implode('; ', $arrayUtils->arrayize($this->searchBase))
                ));

                $filter = sprintf(
                    "(&(%s=%s)(%s=%s))",
                    $map['type'],
                    $this->type_map['group'],
                    $map['member'] . ':1.2.840.113556.1.4.1941:',
                    $attributes[$dn_attribute][0],
                );

                $entries = $ldapUtils->searchForMultiple(
                    $this->ldapObject,
                    $this->searchBase,
                    $filter,
                    $options,
                    true
                );

                break;
            case 'OpenLDAP':
                // Log the OpenLDAP specific search
                Logger::debug(sprintf(
                    '%s : Searching LDAP using OpenLDAP specific method.',
                    $this->title
                ));

                Logger::debug(sprintf(
                    '%s : Searching for groups in base [%s] with filter (%s=%s) and attributes %s',
                    $this->title,
                    implode(', ', $this->searchBase),
                    $map['memberOf'],
                    $attributes[$map['username']][0],
                    $map['member']
                ));

                $filter = sprintf(
                    '(&(%s=%s))',
                    $map['memberOf'],
                    $attributes[$map['username']][0]
                );

                $entries = $ldapUtils->searchForMultiple(
                    $this->ldapObject,
                    $this->searchBase,
                    $filter,
                    $options,
                    true
                );

                break;
            default:
                // Log the generic search
                Logger::debug(
                    $this->title . 'Searching LDAP using the generic search method.'
                );

                // Make sure the defined memberOf attribute exists
                Assert::keyExists(
                    $attributes,
                    $map['memberOf'],
                    sprintf(
                        "%s : The memberOf attribute [%s] is not defined in the user's attributes: [%s]",
                        $this->title,
                        $map['memberOf'],
                        implode(', ', array_keys($attributes))
                    ),
                    Error\Exception::class,
                );

                // MemberOf must be an array of group DN's
                Assert::isArray(
                    $attributes[$map['memberOf']],
                    sprintf(
                        '%s : The memberOf attribute [%s] is not an array of group DNs;  %s',
                        $this->title,
                        $map['memberOf'],
                        $this->varExport($attributes[$map['memberOf']]),
                    ),
                    Error\Exception::class,
                );

                Logger::debug(sprintf(
                    '%s : Checking DNs for groups. DNs: %s Attributes: %s, %s Group Type: %s',
                    $this->title,
                    implode('; ', $attributes[$map['memberOf']]),
                    $map['memberOf'],
                    $map['type'],
                    $this->type_map['group']
                ));

                // Search for the users group membership, recursively
                $entries = $this->search($attributes[$map['memberOf']], $options);
        }

        $groups = [];
        foreach ($entries as $entry) {
            if ($entry->hasAttribute($return_attribute)) {
                $values = $entry->getAttribute($return_attribute);
                $groups[] = array_pop($values);
                continue;
            } elseif ($entry->hasAttribute(strtolower($return_attribute))) {
                // Some backends return lowercase attributes
                $values = $entry->getAttribute(strtolower($return_attribute));
                $groups[] = array_pop($values);
                continue;
            } elseif ($entry->hasAttribute('dn')) {
                // AD queries also seem to return the objects dn by default
                $values = $entry->getAttribute('dn');
                $groups[] = array_pop($values);
                continue;
            }

            // Could not find DN, log and continue
            Logger::notice(sprintf(
                '%s : The return attribute [%s] could not be found in the entry. %s',
                $this->title,
                implode(', ', [$map['return'], strtolower($map['return']), 'dn']),
                $this->varExport($entry),
            ));
        }

        // All done
        Logger::debug(sprintf(
            '%s : User found to be a member of the groups: %s',
            $this->title,
            implode('; ', $groups),
        ));

        return $groups;
    }


    /**
     * Looks for groups from the list of DN's passed. Also
     * recursively searches groups for further membership.
     * Avoids loops by only searching a DN once. Returns
     * the list of groups found.
     *
     * @param array $memberOf
     * @param array $options
     * @return array
     */
    protected function search(array $memberOf, array $options): array
    {
        // Shorten the variable name
        $map = &$this->attribute_map;

        // Used to determine what DN's have already been searched
        static $searched = [];

        // Init the groups variable
        $entries = [];
        $ldapUtils = new LdapUtils();

        // Check each DN of the passed memberOf
        foreach ($memberOf as $dn) {
            // Avoid infinite loops, only need to check a DN once
            if (isset($searched[$dn])) {
                continue;
            }

            // Track all DN's that are searched
            // Use DN for key as well, isset() is faster than in_array()
            $searched[$dn] = $dn;

            // Query LDAP for the attribute values for the DN
            $entry = $ldapUtils->search(
                $this->ldapObject,
                $this->searchBase,
                sprintf("(&(%s=%s)(distinguishedName=%s))", $map['type'], $this->type_map['group'], $dn),
                $options,
                true,
            );

            if ($entry === null) {
                // Probably the DN does not exist within the given search base
                continue;
            }

            // Add to found groups array
            $entries[] = $entry;

            // Recursively search "sub" groups
            $subGroups = $entry->getAttribute($map['memberOf']);
            if (!empty($subGroups)) {
                $entries = array_merge($entries, $this->search($subGroups, $options));
            }
        }

        return $entries;
    }
}


1			<?php
2
3			/**
4			* Does a reverse membership lookup on the logged in user,
5			* looking for groups it is a member of and adds them to
6			* a defined attribute, in DN format.
7			*
8			* @package simplesamlphp/simplesamlphp-module-ldap
9			*/
10
11			declare(strict_types=1);
12
13			namespace SimpleSAML\Module\ldap\Auth\Process;
14
15			use SimpleSAML\Assert\Assert;
16			use SimpleSAML\Error;
17			use SimpleSAML\Logger;
18			use SimpleSAML\Module\ldap\Utils\Ldap as LdapUtils;
19			use SimpleSAML\Utils;
20			use Symfony\Component\Ldap\Adapter\ExtLdap\Query;
21
22			class AttributeAddUsersGroups extends BaseFilter
23			{
24			/** @var string */
25			protected string $searchUsername;
26
27			/** @var string */
28			protected string $searchPassword;
29
30			/** @var string */
31			protected string $product;
32
33
34			/**
35			* Initialize this filter.
36			*
37			* @param array $config Configuration information about this filter.
38			* @param mixed $reserved For future use.
39			*/
40			public function __construct(array $config, $reserved)
41			{
42			parent::__construct($config, $reserved);
43
44			// Get filter specific config options
45			$this->searchUsername = $this->config->getString('search.username');
46			$this->searchPassword = $this->config->getString('search.password', null);
47			$this->product = $this->config->getString('ldap.product', 'ActiveDirectory');
48			}
49
50
51			/**
52			* LDAP search filters to be added to the base filters for this authproc-filter.
53			* It's an array of key => value pairs that will be translated to (key=value) in the ldap query.
54			*
55			* @var array
56			*/
57			protected array $additional_filters;
58
59
60			/**
61			* This is run when the filter is processed by SimpleSAML.
62			* It will attempt to find the current users groups using
63			* the best method possible for the LDAP product. The groups
64			* are then added to the request attributes.
65			*
66			* @throws \SimpleSAML\Error\Exception
67			* @param array &$state
68			*/
69			public function process(array &$state): void
70			{
71			Assert::keyExists($state, 'Attributes');
72
73			// Log the process
74			Logger::debug(sprintf(
75			'%s : Attempting to get the users groups...',
76			$this->title
77			));
78
79			$this->additional_filters = $this->config->getArray('additional_filters', []);
80
81			// Reference the attributes, just to make the names shorter
82			$attributes = &$state['Attributes'];
83			$map = &$this->attribute_map;
84
85			// Get the users groups from LDAP
86			$groups = $this->getGroups($attributes);
87
88			// If there are none, do not proceed
89			if (empty($groups)) {
90			return;
91			}
92
93			// Make the array if it is not set already
94			if (!isset($attributes[$map['groups']])) {
95			$attributes[$map['groups']] = [];
96			}
97
98			// Must be an array, else cannot merge groups
99			if (!is_array($attributes[$map['groups']])) {
100			throw new Error\Exception(sprintf(
101			'%s : The group attribute [%s] is not an array of group DNs. %s',
102			$this->title,
103			$map['groups'],
104			$this->varExport($attributes[$map['groups']])
105			));
106			}
107
108			// Add the users group(s)
109			$group_attribute = &$attributes[$map['groups']];
110			$group_attribute = array_merge($group_attribute, $groups);
111			$group_attribute = array_unique($group_attribute);
112
113			// All done
114			Logger::debug(sprintf(
115			'%s : Added users groups to the group attribute[%s]: %s',
116			$this->title,
117			$map['groups'],
118			implode('; ', $groups)
119			));
120			}
121
122
123			/**
124			* Will perform a search using the required attribute values from the user to
125			* get their group membership, recursively.
126			*
127			* @throws \SimpleSAML\Error\Exception
128			* @param array $attributes
129			* @return array
130			*/
131			protected function getGroups(array $attributes): array
132			{
133			// Log the request
134			Logger::debug(sprintf(
135			'%s : Checking for groups based on the best method for the LDAP product.',
136			$this->title
137			));
138
139			$ldapUtils = new LdapUtils();
140			$ldapUtils->bind($this->ldapObject, $this->searchUsername, $this->searchPassword);
141
142			$options = [
143			'scope' => $this->config->getString('search.scope', Query::SCOPE_SUB),
144			'timeout' => $this->config->getInteger('timeout', 3),
145			];
146
147			// Reference the map, just to make the name shorter
148			$map = &$this->attribute_map;
149
150
151			// All map-properties are guaranteed to exist and have a default value
152			$dn_attribute = $map['dn'];
153			$return_attribute = $map['return'];
154
155			// Based on the directory service, search LDAP for groups
156			// If any attributes are needed, prepare them before calling search method
157			switch ($this->product) {
158			case 'ActiveDirectory':
159			// Log the AD specific search
160			Logger::debug(sprintf(
161			'%s : Searching LDAP using ActiveDirectory specific method.',
162			$this->title
163			));
164
165			// Make sure the defined DN attribute exists
166			if (!isset($attributes[$dn_attribute])) {
167			Logger::warning(sprintf(
168			"%s : The DN attribute [%s] is not defined in the user's Attributes: %s",
169			$this->title,
170			$dn_attribute,
171			implode(', ', array_keys($attributes)),
172			));
173
174			return [];
175			}
176
177			// Make sure the defined DN attribute has a value
178			if (!isset($attributes[$dn_attribute][0]) \|\| !$attributes[$dn_attribute][0]) {
179			Logger::warning(sprintf(
180			'%s : The DN attribute [%s] does not have a [0] value defined. %s',
181			$this->title,
182			$dn_attribute,
183			$this->varExport($attributes[$dn_attribute])
184			));
185
186			return [];
187			}
188
189			// Log the search
190			$arrayUtils = new Utils\Arrays();
191			Logger::debug(sprintf(
192			'%s : Searching ActiveDirectory group membership.'
193			. ' DN: %s DN Attribute: %s Member Attribute: %s Type Attribute: %s Type Value: %s Base: %s',
194			$this->title,
195			$attributes[$dn_attribute][0],
196			$dn_attribute,
197			$map['member'],
198			$map['type'],
199			$this->type_map['group'],
200			implode('; ', $arrayUtils->arrayize($this->searchBase))
201			));
202
203			$filter = sprintf(
204			"(&(%s=%s)(%s=%s))",
205			$map['type'],
206			$this->type_map['group'],
207			$map['member'] . ':1.2.840.113556.1.4.1941:',
208			$attributes[$dn_attribute][0],
209			);
210
211			$entries = $ldapUtils->searchForMultiple(
212			$this->ldapObject,
213			$this->searchBase,
214			$filter,
215			$options,
216			true
217			);
218
219			break;
220			case 'OpenLDAP':
221			// Log the OpenLDAP specific search
222			Logger::debug(sprintf(
223			'%s : Searching LDAP using OpenLDAP specific method.',
224			$this->title
225			));
226
227			Logger::debug(sprintf(
228			'%s : Searching for groups in base [%s] with filter (%s=%s) and attributes %s',
229			$this->title,
230			implode(', ', $this->searchBase),
231			$map['memberOf'],
232			$attributes[$map['username']][0],
233			$map['member']
234			));
235
236			$filter = sprintf(
237			'(&(%s=%s))',
238			$map['memberOf'],
239			$attributes[$map['username']][0]
240			);
241
242			$entries = $ldapUtils->searchForMultiple(
243			$this->ldapObject,
244			$this->searchBase,
245			$filter,
246			$options,
247			true
248			);
249
250			break;
251			default:
252			// Log the generic search
253			Logger::debug(
254			$this->title . 'Searching LDAP using the generic search method.'
255			);
256
257			// Make sure the defined memberOf attribute exists
258			Assert::keyExists(
259			$attributes,
260			$map['memberOf'],
261			sprintf(
262			"%s : The memberOf attribute [%s] is not defined in the user's attributes: [%s]",
263			$this->title,
264			$map['memberOf'],
265			implode(', ', array_keys($attributes))
266			),
267			Error\Exception::class,
268			);
269
270			// MemberOf must be an array of group DN's
271			Assert::isArray(
272			$attributes[$map['memberOf']],
273			sprintf(
274			'%s : The memberOf attribute [%s] is not an array of group DNs; %s',
275			$this->title,
276			$map['memberOf'],
277			$this->varExport($attributes[$map['memberOf']]),
278			),
279			Error\Exception::class,
280			);
281
282			Logger::debug(sprintf(
283			'%s : Checking DNs for groups. DNs: %s Attributes: %s, %s Group Type: %s',
284			$this->title,
285			implode('; ', $attributes[$map['memberOf']]),
286			$map['memberOf'],
287			$map['type'],
288			$this->type_map['group']
289			));
290
291			// Search for the users group membership, recursively
292			$entries = $this->search($attributes[$map['memberOf']], $options);
293			}
294
295			$groups = [];
296			foreach ($entries as $entry) {
297			if ($entry->hasAttribute($return_attribute)) {
298			$values = $entry->getAttribute($return_attribute);
299			$groups[] = array_pop($values);
300			continue;
301			} elseif ($entry->hasAttribute(strtolower($return_attribute))) {
302			// Some backends return lowercase attributes
303			$values = $entry->getAttribute(strtolower($return_attribute));
304			$groups[] = array_pop($values);
305			continue;
306			} elseif ($entry->hasAttribute('dn')) {
307			// AD queries also seem to return the objects dn by default
308			$values = $entry->getAttribute('dn');
309			$groups[] = array_pop($values);
310			continue;
311			}
312
313			// Could not find DN, log and continue
314			Logger::notice(sprintf(
315			'%s : The return attribute [%s] could not be found in the entry. %s',
316			$this->title,
317			implode(', ', [$map['return'], strtolower($map['return']), 'dn']),
318			$this->varExport($entry),
319			));
320			}
321
322			// All done
323			Logger::debug(sprintf(
324			'%s : User found to be a member of the groups: %s',
325			$this->title,
326			implode('; ', $groups),
327			));
328
329			return $groups;
330			}
331
332
333			/**
334			* Looks for groups from the list of DN's passed. Also
335			* recursively searches groups for further membership.
336			* Avoids loops by only searching a DN once. Returns
337			* the list of groups found.
338			*
339			* @param array $memberOf
340			* @param array $options
341			* @return array
342			*/
343			protected function search(array $memberOf, array $options): array
344			{
345			// Shorten the variable name
346			$map = &$this->attribute_map;
347
348			// Used to determine what DN's have already been searched
349			static $searched = [];
350
351			// Init the groups variable
352			$entries = [];
353			$ldapUtils = new LdapUtils();
354
355			// Check each DN of the passed memberOf
356			foreach ($memberOf as $dn) {
357			// Avoid infinite loops, only need to check a DN once
358			if (isset($searched[$dn])) {
359			continue;
360			}
361
362			// Track all DN's that are searched
363			// Use DN for key as well, isset() is faster than in_array()
364			$searched[$dn] = $dn;
365
366			// Query LDAP for the attribute values for the DN
367			$entry = $ldapUtils->search(
368			$this->ldapObject,
369			$this->searchBase,
370			sprintf("(&(%s=%s)(distinguishedName=%s))", $map['type'], $this->type_map['group'], $dn),
371			$options,
372			true,
373			);
374
375			if ($entry === null) {
376			// Probably the DN does not exist within the given search base
377			continue;
378			}
379
380			// Add to found groups array
381			$entries[] = $entry;
382
383			// Recursively search "sub" groups
384			$subGroups = $entry->getAttribute($map['memberOf']);
385			if (!empty($subGroups)) {
386			$entries = array_merge($entries, $this->search($subGroups, $options));
387			}
388			}
389
390			return $entries;
391			}
392			}
393

simplesamlphp / simplesamlphp-module-ldap

Pull Request — master (#28)

AttributeAddUsersGroups::getGroups() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like