DiscoPowerTest::testDiscoPowerHasDiscoParams() - Code Metrics - Inspection of "Update test-framework" - simplesamlphp/simplesamlphp-module-discopower - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 852ed5...a44092 )

by Tim

created 2023-10-30 16:42 UTC

DiscoPowerTest::testDiscoPowerHasDiscoParams() A

↳ Parent: DiscoPowerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	0
dl	0
loc	20
rs	9.8333
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace SimpleSAML\Test\Module\discopower\Controller;

use PHPUnit\Framework\TestCase;
use SimpleSAML\Configuration;
use SimpleSAML\Error;
use SimpleSAML\HTTP\RunnableResponse;
use SimpleSAML\Module\discopower\Controller;
use SimpleSAML\Session;
use SimpleSAML\TestUtils\ClearStateTestCase;
use SimpleSAML\XHTML\Template;
use Symfony\Component\HttpFoundation\Request;

/**
 * Set of tests for the controllers in the "discopwer" module.
 *
 * @covers \SimpleSAML\Module\discopower\Controller\DiscoPower
 */
class DiscoPowerTest extends ClearStateTestCase
{
    /** @var \SimpleSAML\Configuration */
    private static Configuration $discoconfig;


    /**
     * Set up for before tests.
     */
    public static function setUpBeforeClass(): void
    {
        parent::setUp();

        $config = Configuration::loadFromArray(
            [
                'module.enable' => ['discopower' => true],
                'trusted.url.domains' => ['example.com'],
            ],
            '[ARRAY]',
            'simplesaml'
        );

        Configuration::setPreLoadedConfig($config, 'config.php');

        self::$discoconfig = Configuration::loadFromArray(
            [
                'defaulttab' => 0,
                'trusted.url.domains' => ['example.com'],
            ],
            '[ARRAY]',
            'simplesaml'
        );
    }

    public function testDiscoPowerNoDiscoParams(): void
    {
        $request = Request::create(
            '/disco.php',
            'GET'
        );

        $c = new Controller\DiscoPower();

        $this->expectException(Error\Error::class);
        $this->expectExceptionMessage("DISCOPARAMS");
        $r = $c->main($request);

    }

    public function testDiscoPowerHasDiscoParams(): void
    {
        Configuration::setPreLoadedConfig(self::$discoconfig, 'module_discopower.php');

        $request = Request::create(
            '/disco.php',
            'GET',
        );
        $_GET = [
            'entityID' => 'https://example.com/sp',
            'return' => 'https://example.com/acs',
            'returnIDParam' => 'idpentityid'
        ];
        $_SERVER['REQUEST_URI'] = '/disco.php';

        $c = new Controller\DiscoPower();

        $r = $c->main($request);
        $this->assertInstanceOf(RunnableResponse::class, $r);
        $this->assertTrue($r->isSuccessful());
    }

    public function testDiscoPowerReturnUrlDisallowed(): void
    {
        Configuration::setPreLoadedConfig(self::$discoconfig, 'module_discopower.php');

        $request = Request::create(
            '/disco.php',
            'GET',
        );
        $_GET = [
            'entityID' => 'https://example.com/sp',
            'return' => 'https://attacker.example.org/acs',
            'returnIDParam' => 'idpentityid'
        ];
        $_SERVER['REQUEST_URI'] = '/disco.php';

        $c = new Controller\DiscoPower();

        // All exceptions in this stage are flattened into DISCOPARAMS
        $this->expectException(Error\Error::class);
        $this->expectExceptionMessage("DISCOPARAMS");
        $c->main($request);
    }

    public function testTablistJson(): void
    {
        $session = Session::getSessionFromRequest();
        $session->setData('discopower:tabList', 'faventry', 'http://example.org/idp');
        $session->setData('discopower:tabList', 'tabs', ['Frankrijk', 'Nederland', 'Duitsland']);
        $session->setData('discopower:tabList', 'defaulttab', 'Nederland');

        $request = Request::create(
            '/tablist',
            'GET'
        );

        $c = new Controller\DiscoPower();

        $r = $c->tablist($request);
        $this->assertTrue($r->isSuccessful());
        $this->assertEquals('application/json', $r->headers->get('Content-Type'));
        $this->assertEquals(
            '{"faventry":"http:\/\/example.org\/idp","default":"Nederland","tabs":["Frankrijk","Nederland","Duitsland"]}',
            $r->getContent(),
        );

        $request = Request::create(
            '/tablist',
            'GET',
            ['callback' => 'aapnoot'],
        );

        $c = new Controller\DiscoPower();

        $r = $c->tablist($request);
        $this->assertTrue($r->isSuccessful());
        $this->assertEquals('text/javascript', $r->headers->get('Content-Type'));
        $this->assertEquals(
            '/**/aapnoot({"faventry":"http:\/\/example.org\/idp","default":"Nederland","tabs":["Frankrijk","Nederland","Duitsland"]});',
            $r->getContent(),
        );
    }

    public function testTablistJsonNoSession(): void
    {
        $request = Request::create(
            '/tablist',
            'GET',
        );

        $c = new Controller\DiscoPower();

        $this->expectException(Error\Exception::class);
        $this->expectExceptionMessage("Could not get tab list from session");
        $r = $c->tablist($request);

    }

    public function testTablistJsonUnsafeCallback(): void
    {
        $session = Session::getSessionFromRequest();
        $session->setData('discopower:tabList', 'faventry', 'http://example.org/idp');
        $session->setData('discopower:tabList', 'tabs', ['Frankrijk', 'Nederland', 'Duitsland']);
        $session->setData('discopower:tabList', 'defaulttab', 'Nederland');

        $request = Request::create(
            '/tablist',
            'GET',
            ['callback' => 'alert("hallo")'],
        );

        $c = new Controller\DiscoPower();

        $this->expectException(Error\Exception::class);
        $this->expectExceptionMessage("Unsafe JSONP callback");
        $r = $c->tablist($request);

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\Test\Module\discopower\Controller;
6
7			use PHPUnit\Framework\TestCase;
8			use SimpleSAML\Configuration;
9			use SimpleSAML\Error;
10			use SimpleSAML\HTTP\RunnableResponse;
11			use SimpleSAML\Module\discopower\Controller;
12			use SimpleSAML\Session;
13			use SimpleSAML\TestUtils\ClearStateTestCase;
14			use SimpleSAML\XHTML\Template;
15			use Symfony\Component\HttpFoundation\Request;
16
17			/**
18			* Set of tests for the controllers in the "discopwer" module.
19			*
20			* @covers \SimpleSAML\Module\discopower\Controller\DiscoPower
21			*/
22			class DiscoPowerTest extends ClearStateTestCase
23			{
24			/** @var \SimpleSAML\Configuration */
25			private static Configuration $discoconfig;
26
27
28			/**
29			* Set up for before tests.
30			*/
31			public static function setUpBeforeClass(): void
32			{
33			parent::setUp();
34
35			$config = Configuration::loadFromArray(
36			[
37			'module.enable' => ['discopower' => true],
38			'trusted.url.domains' => ['example.com'],
39			],
40			'[ARRAY]',
41			'simplesaml'
42			);
43
44			Configuration::setPreLoadedConfig($config, 'config.php');
45
46			self::$discoconfig = Configuration::loadFromArray(
47			[
48			'defaulttab' => 0,
49			'trusted.url.domains' => ['example.com'],
50			],
51			'[ARRAY]',
52			'simplesaml'
53			);
54			}
55
56			public function testDiscoPowerNoDiscoParams(): void
57			{
58			$request = Request::create(
59			'/disco.php',
60			'GET'
61			);
62
63			$c = new Controller\DiscoPower();
64
65			$this->expectException(Error\Error::class);
66			$this->expectExceptionMessage("DISCOPARAMS");
67			$r = $c->main($request);
			0 ignored issues – show Unused Code introduced 2023-10-30 16:21 UTC by Report Bug Copy Issue Report The assignment to `$r` is dead and can be removed. Loading history...
68			}
69
70			public function testDiscoPowerHasDiscoParams(): void
71			{
72			Configuration::setPreLoadedConfig(self::$discoconfig, 'module_discopower.php');
73
74			$request = Request::create(
75			'/disco.php',
76			'GET',
77			);
78			$_GET = [
79			'entityID' => 'https://example.com/sp',
80			'return' => 'https://example.com/acs',
81			'returnIDParam' => 'idpentityid'
82			];
83			$_SERVER['REQUEST_URI'] = '/disco.php';
84
85			$c = new Controller\DiscoPower();
86
87			$r = $c->main($request);
88			$this->assertInstanceOf(RunnableResponse::class, $r);
89			$this->assertTrue($r->isSuccessful());
90			}
91
92			public function testDiscoPowerReturnUrlDisallowed(): void
93			{
94			Configuration::setPreLoadedConfig(self::$discoconfig, 'module_discopower.php');
95
96			$request = Request::create(
97			'/disco.php',
98			'GET',
99			);
100			$_GET = [
101			'entityID' => 'https://example.com/sp',
102			'return' => 'https://attacker.example.org/acs',
103			'returnIDParam' => 'idpentityid'
104			];
105			$_SERVER['REQUEST_URI'] = '/disco.php';
106
107			$c = new Controller\DiscoPower();
108
109			// All exceptions in this stage are flattened into DISCOPARAMS
110			$this->expectException(Error\Error::class);
111			$this->expectExceptionMessage("DISCOPARAMS");
112			$c->main($request);
113			}
114
115			public function testTablistJson(): void
116			{
117			$session = Session::getSessionFromRequest();
118			$session->setData('discopower:tabList', 'faventry', 'http://example.org/idp');
119			$session->setData('discopower:tabList', 'tabs', ['Frankrijk', 'Nederland', 'Duitsland']);
120			$session->setData('discopower:tabList', 'defaulttab', 'Nederland');
121
122			$request = Request::create(
123			'/tablist',
124			'GET'
125			);
126
127			$c = new Controller\DiscoPower();
128
129			$r = $c->tablist($request);
130			$this->assertTrue($r->isSuccessful());
131			$this->assertEquals('application/json', $r->headers->get('Content-Type'));
132			$this->assertEquals(
133			'{"faventry":"http:\/\/example.org\/idp","default":"Nederland","tabs":["Frankrijk","Nederland","Duitsland"]}',
134			$r->getContent(),
135			);
136
137			$request = Request::create(
138			'/tablist',
139			'GET',
140			['callback' => 'aapnoot'],
141			);
142
143			$c = new Controller\DiscoPower();
144
145			$r = $c->tablist($request);
146			$this->assertTrue($r->isSuccessful());
147			$this->assertEquals('text/javascript', $r->headers->get('Content-Type'));
148			$this->assertEquals(
149			'/**/aapnoot({"faventry":"http:\/\/example.org\/idp","default":"Nederland","tabs":["Frankrijk","Nederland","Duitsland"]});',
150			$r->getContent(),
151			);
152			}
153
154			public function testTablistJsonNoSession(): void
155			{
156			$request = Request::create(
157			'/tablist',
158			'GET',
159			);
160
161			$c = new Controller\DiscoPower();
162
163			$this->expectException(Error\Exception::class);
164			$this->expectExceptionMessage("Could not get tab list from session");
165			$r = $c->tablist($request);
			0 ignored issues – show Unused Code introduced 2023-10-30 16:21 UTC by Report Bug Copy Issue Report The assignment to `$r` is dead and can be removed. Loading history...
166			}
167
168			public function testTablistJsonUnsafeCallback(): void
169			{
170			$session = Session::getSessionFromRequest();
171			$session->setData('discopower:tabList', 'faventry', 'http://example.org/idp');
172			$session->setData('discopower:tabList', 'tabs', ['Frankrijk', 'Nederland', 'Duitsland']);
173			$session->setData('discopower:tabList', 'defaulttab', 'Nederland');
174
175			$request = Request::create(
176			'/tablist',
177			'GET',
178			['callback' => 'alert("hallo")'],
179			);
180
181			$c = new Controller\DiscoPower();
182
183			$this->expectException(Error\Exception::class);
184			$this->expectExceptionMessage("Unsafe JSONP callback");
185			$r = $c->tablist($request);
			0 ignored issues – show Unused Code introduced 2023-10-30 16:21 UTC by Report Bug Copy Issue Report The assignment to `$r` is dead and can be removed. Loading history...
186			}
187			}
188

simplesamlphp / simplesamlphp-module-discopower

Push — master ( 852ed5...a44092 )

DiscoPowerTest::testDiscoPowerHasDiscoParams() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like