Issues in UrlTrait.php (master) - Issues in master - simplesamlphp/simplesamlphp-module-casserver - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/Traits/UrlTrait.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

declare(strict_types=1);

namespace SimpleSAML\Module\casserver\Controller\Traits;

use SimpleSAML\Configuration;
use SimpleSAML\Module\casserver\Cas\ServiceValidator;
use SimpleSAML\Module\casserver\Cas\TicketValidator;
use Symfony\Component\HttpFoundation\Request;

use function array_merge;
use function is_string;

trait UrlTrait
{
    /**
     * @param string $service
     * @param string[] $legal_service_urls
     *
     * @return bool
     * @throws \ErrorException
     * @see \SimpleSAML\Module\casserver\Cas\ServiceValidator
     */
    public function checkServiceURL(string $service, array $legal_service_urls): bool
    {
        //delegate to ServiceValidator until all references to this can be cleaned up
        $config = Configuration::loadFromArray(['legal_service_urls' => $legal_service_urls]);
        $serviceValidator = new ServiceValidator($config);
        return $serviceValidator->checkServiceURL($service) !== null;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param string $parameter
     * @return string
     */
    public function sanitize(string $parameter): string
    {
        return TicketValidator::sanitize($parameter);
    }

    /**
     * Parse the query Parameters from $_GET global and return them in an array.
     *
     * @param \Symfony\Component\HttpFoundation\Request $request
     * @param string[]|null $sessionTicket
     *
     * @return string[]
     */
    public function parseQueryParameters(Request $request, ?array $sessionTicket): array
    {
        $forceAuthn = $this->getRequestParam($request, 'renew');
        $sessionRenewId = !empty($sessionTicket['renewId']) ? $sessionTicket['renewId'] : null;

        $queryParameters = $request->query->all();
        $requestParameters = $request->request->all();

        $query = array_merge($requestParameters, $queryParameters);

        if ($sessionRenewId && $forceAuthn) {
            $query['renewId'] = $sessionRenewId;
        }

        if (isset($query['language'])) {
            $query['language'] = is_string($query['language']) ? $query['language'] : null;
        }

        return $query;
    }

    /**
     * @param \Symfony\Component\HttpFoundation\Request $request
     * @param string $paramName
     *
     * @return mixed
     */
    public function getRequestParam(Request $request, string $paramName): mixed
    {
        return $request->query->get($paramName) ?? $request->request->get($paramName) ?? null;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\Module\casserver\Controller\Traits;
6
7			use SimpleSAML\Configuration;
8			use SimpleSAML\Module\casserver\Cas\ServiceValidator;
9			use SimpleSAML\Module\casserver\Cas\TicketValidator;
10			use Symfony\Component\HttpFoundation\Request;
11
12			use function array_merge;
13			use function is_string;
14
15			trait UrlTrait
16			{
17			/**
18			* @param string $service
19			* @param string[] $legal_service_urls
20			*
21			* @return bool
22			* @throws \ErrorException
23			* @see \SimpleSAML\Module\casserver\Cas\ServiceValidator
24			*/
25			public function checkServiceURL(string $service, array $legal_service_urls): bool
26			{
27			//delegate to ServiceValidator until all references to this can be cleaned up
28			$config = Configuration::loadFromArray(['legal_service_urls' => $legal_service_urls]);
29			$serviceValidator = new ServiceValidator($config);
30			return $serviceValidator->checkServiceURL($service) !== null;
			0 ignored issues – show Bug introduced 2025-11-20 00:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$serviceValidator->checkServiceURL($service)` targeting `SimpleSAML\Module\casser...ator::checkServiceURL()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
31			}
32
33			/**
34			* @param string $parameter
35			* @return string
36			*/
37			public function sanitize(string $parameter): string
38			{
39			return TicketValidator::sanitize($parameter);
40			}
41
42			/**
43			* Parse the query Parameters from $_GET global and return them in an array.
44			*
45			* @param \Symfony\Component\HttpFoundation\Request $request
46			* @param string[]\|null $sessionTicket
47			*
48			* @return string[]
49			*/
50			public function parseQueryParameters(Request $request, ?array $sessionTicket): array
51			{
52			$forceAuthn = $this->getRequestParam($request, 'renew');
53			$sessionRenewId = !empty($sessionTicket['renewId']) ? $sessionTicket['renewId'] : null;
54
55			$queryParameters = $request->query->all();
56			$requestParameters = $request->request->all();
57
58			$query = array_merge($requestParameters, $queryParameters);
59
60			if ($sessionRenewId && $forceAuthn) {
61			$query['renewId'] = $sessionRenewId;
62			}
63
64			if (isset($query['language'])) {
65			$query['language'] = is_string($query['language']) ? $query['language'] : null;
66			}
67
68			return $query;
69			}
70
71			/**
72			* @param \Symfony\Component\HttpFoundation\Request $request
73			* @param string $paramName
74			*
75			* @return mixed
76			*/
77			public function getRequestParam(Request $request, string $paramName): mixed
78			{
79			return $request->query->get($paramName) ?? $request->request->get($paramName) ?? null;
80			}
81			}
82

simplesamlphp / simplesamlphp-module-casserver

Issues (31)

Security Analysis not enabled

src/Controller/Traits/UrlTrait.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like