simplesamlphp / simplesamlphp-module-casserver

www/logout.php

Spacing +2 added lines, -2 removed lines

@@ -28,7 +28,7 @@ 
 if (!$casconfig->getValue('enable_logout', false)) {
     $message = 'Logout not allowed';
 
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     throw new Exception($message);
 }
@@ -38,7 +38,7 @@ 
 if ($skipLogoutPage && !array_key_exists('url', $_GET)) {
     $message = 'Required URL query parameter [url] not provided. (CAS Server)';
 
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     throw new Exception($message);
 }

www/utility/urlUtils.php

Spacing +2 added lines, -2 removed lines

@@ -29,11 +29,11 @@
         }
         if (!ctype_alnum($legalUrl[0])) {
             // Probably a regex. Suppress errors incase the format is invalid
-            $result =  @preg_match($legalUrl, $service);
+            $result = @preg_match($legalUrl, $service);
             if ($result === 1) {
                 return true;
             } elseif ($result === false) {
-                SimpleSAML\Logger::warning("Invalid CAS legal service url '$legalUrl'. Error " . preg_last_error());
+                SimpleSAML\Logger::warning("Invalid CAS legal service url '$legalUrl'. Error ".preg_last_error());
             }
         } elseif (strpos($service, $legalUrl) === 0) {
             return true;

www/utility/validateTicket.php

Spacing +16 added lines, -16 removed lines

@@ -78,8 +78,8 @@ 
                             'sessionId' => $serviceTicket['sessionId']
                         ));
                         try {
-                            SimpleSAML\Utils\HTTP::fetch($pgtUrl . '?pgtIou=' . $proxyGrantingTicket['iou']
-                                . '&pgtId=' . $proxyGrantingTicket['id']);
+                            SimpleSAML\Utils\HTTP::fetch($pgtUrl.'?pgtIou='.$proxyGrantingTicket['iou']
+                                . '&pgtId='.$proxyGrantingTicket['id']);
 
                             $protocol->setProxyGrantingTicketIOU($proxyGrantingTicket['iou']);
 
@@ -92,29 +92,29 @@ 
                 echo $protocol->getValidateSuccessResponse($serviceTicket['userName']);
             } else {
                 if ($ticketFactory->isExpired($serviceTicket)) {
-                    $message = 'Ticket ' . var_export($_GET['ticket'], true) . ' has expired';
+                    $message = 'Ticket '.var_export($_GET['ticket'], true).' has expired';
 
-                    SimpleSAML\Logger::debug('casserver:' . $message);
+                    SimpleSAML\Logger::debug('casserver:'.$message);
 
                     echo $protocol->getValidateFailureResponse('INVALID_TICKET', $message);
                 } else {
                     if (sanitize($serviceTicket['service']) != sanitize($_GET['service'])) {
                         $message = 'Mismatching service parameters: expected '
                             . var_export($serviceTicket['service'], true)
-                            . ' but was: ' . var_export($_GET['service'], true);
+                            . ' but was: '.var_export($_GET['service'], true);
 
-                        SimpleSAML\Logger::debug('casserver:' . $message);
+                        SimpleSAML\Logger::debug('casserver:'.$message);
 
                         echo $protocol->getValidateFailureResponse('INVALID_SERVICE', $message);
                     } else {
                         if ($serviceTicket['forceAuthn'] != $forceAuthn) {
                             $message = 'Ticket was issue from single sign on session';
 
-                            SimpleSAML\Logger::debug('casserver:' . $message);
+                            SimpleSAML\Logger::debug('casserver:'.$message);
 
                             echo $protocol->getValidateFailureResponse('INVALID_TICKET', $message);
                         } else {
-                            SimpleSAML\Logger::error('casserver:' . $method . ': internal server error.');
+                            SimpleSAML\Logger::error('casserver:'.$method.': internal server error.');
 
                             echo $protocol->getValidateFailureResponse('INTERNAL_ERROR', 'Unknown internal error');
                         }
@@ -123,23 +123,23 @@ 
             }
         } else {
             if (is_null($serviceTicket)) {
-                $message = 'Ticket ' . var_export($_GET['ticket'], true) . ' not recognized';
+                $message = 'Ticket '.var_export($_GET['ticket'], true).' not recognized';
 
-                SimpleSAML\Logger::debug('casserver:' . $message);
+                SimpleSAML\Logger::debug('casserver:'.$message);
 
                 echo $protocol->getValidateFailureResponse('INVALID_TICKET', $message);
             } else {
                 if ($ticketFactory->isProxyTicket($serviceTicket) && $method == 'serviceValidate') {
-                    $message = 'Ticket ' . var_export($_GET['ticket'], true)
+                    $message = 'Ticket '.var_export($_GET['ticket'], true)
                         . ' is a proxy ticket. Use proxyValidate instead.';
 
-                    SimpleSAML\Logger::debug('casserver:' . $message);
+                    SimpleSAML\Logger::debug('casserver:'.$message);
 
                     echo $protocol->getValidateFailureResponse('INVALID_TICKET', $message);
                 } else {
-                    $message = 'Ticket ' . var_export($_GET['ticket'], true) . ' is not a service ticket';
+                    $message = 'Ticket '.var_export($_GET['ticket'], true).' is not a service ticket';
 
-                    SimpleSAML\Logger::debug('casserver:' . $message);
+                    SimpleSAML\Logger::debug('casserver:'.$message);
 
                     echo $protocol->getValidateFailureResponse('INVALID_TICKET', $message);
                 }
@@ -156,13 +156,13 @@ 
     if (!array_key_exists('service', $_GET)) {
         $message = 'Missing service parameter: [service]';
 
-        SimpleSAML\Logger::debug('casserver:' . $message);
+        SimpleSAML\Logger::debug('casserver:'.$message);
 
         echo $protocol->getValidateFailureResponse('INVALID_REQUEST', $message);
     } else {
         $message = 'Missing ticket parameter: [ticket]';
 
-        SimpleSAML\Logger::debug('casserver:' . $message);
+        SimpleSAML\Logger::debug('casserver:'.$message);
 
         echo $protocol->getValidateFailureResponse('INVALID_REQUEST', $message);
     }

www/proxy.php

Spacing +9 added lines, -9 removed lines

@@ -63,42 +63,42 @@
 
             echo $protocol->getProxySuccessResponse($proxyTicket['id']);
         } else {
-            $message = 'Ticket ' . var_export($_GET['pgt'], true) . ' has expired';
+            $message = 'Ticket '.var_export($_GET['pgt'], true).' has expired';
 
-            SimpleSAML\Logger::debug('casserver:' . $message);
+            SimpleSAML\Logger::debug('casserver:'.$message);
 
             echo $protocol->getProxyFailureResponse('BAD_PGT', $message);
         }
     } elseif (!$ticketFactory->isProxyGrantingTicket($proxyGrantingTicket)) {
-        $message = 'Not a valid proxy granting ticket id: ' . var_export($_GET['pgt'], true);
+        $message = 'Not a valid proxy granting ticket id: '.var_export($_GET['pgt'], true);
 
-        SimpleSAML\Logger::debug('casserver:' . $message);
+        SimpleSAML\Logger::debug('casserver:'.$message);
 
         echo $protocol->getProxyFailureResponse('BAD_PGT', $message);
     } else {
-        $message = 'Ticket ' . var_export($_GET['pgt'], true) . ' not recognized';
+        $message = 'Ticket '.var_export($_GET['pgt'], true).' not recognized';
 
-        SimpleSAML\Logger::debug('casserver:' . $message);
+        SimpleSAML\Logger::debug('casserver:'.$message);
 
         echo $protocol->getProxyFailureResponse('BAD_PGT', $message);
     }
 } elseif (!array_key_exists('targetService', $_GET)) {
     $message = 'Missing target service parameter [targetService]';
 
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     echo $protocol->getProxyFailureResponse('INVALID_REQUEST', $message);
 } elseif (!checkServiceURL(sanitize($_GET['targetService']), $legal_target_service_urls)) {
     $message = 'Target service parameter not listed as a legal service: [targetService] = '
         . var_export($_GET['targetService'], true);
 
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     echo $protocol->getProxyFailureResponse('INVALID_REQUEST', $message);
 } else {
     $message = 'Missing proxy granting ticket parameter: [pgt]';
 
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     echo $protocol->getProxyFailureResponse('INVALID_REQUEST', $message);
 }

www/login.php

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 if (isset($_GET['service']) && !checkServiceURL(sanitize($_GET['service']), $legal_service_urls)) {
     $message = 'Service parameter provided to CAS server is not listed as a legal service: [service] = '
         . var_export($_GET['service'], true);
-    SimpleSAML\Logger::debug('casserver:' . $message);
+    SimpleSAML\Logger::debug('casserver:'.$message);
 
     throw new Exception($message);
 }
@@ -54,7 +54,7 @@ 
     } else {
         $message = 'Scope parameter provided to CAS server is not listed as legal scope: [scope] = '
             . var_export($_GET['scope'], true);
-        SimpleSAML\Logger::debug('casserver:' . $message);
+        SimpleSAML\Logger::debug('casserver:'.$message);
 
         throw new Exception($message);
     }
@@ -100,7 +100,7 @@ 
         $query['language'] = is_string($_GET['language']) ? $_GET['language'] : null;
     }
 
-    $returnUrl = SimpleSAML\Utils\HTTP::getSelfURLNoQuery() . '?' . http_build_query($query);
+    $returnUrl = SimpleSAML\Utils\HTTP::getSelfURLNoQuery().'?'.http_build_query($query);
 
     $params = array(
         'ForceAuthn' => $forceAuthn,