SimpleSAML\Module\authcrypt\Auth\Source\Htpasswd

Complexity

Total Complexity

9

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Importance

Changes	5
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	19	3
B	login()	0	41	6

<?php

/**
 * Authentication source for Apache 'htpasswd' files.
 *
 * @package SimpleSAMLphp
 */

declare(strict_types=1);

namespace SimpleSAML\Module\authcrypt\Auth\Source;

use Exception;
use SimpleSAML\{Error, Logger, Utils};
use SimpleSAML\Module\core\Auth\UserPassBase;
use WhiteHat101\Crypt\APR1_MD5;

use function array_merge;
use function crypt;
use function explode;
use function file_get_contents;
use function trim;

class Htpasswd extends UserPassBase
{
    /**
     * Our users, stored in an array, where each value is "<username>:<passwordhash>".
     *
     * @var array<int, mixed>
     */
    private array $users;

    /**
     * An array containing static attributes for our users.
     *
     * @var array<string, mixed>
     */
    private array $attributes = [];


    /**
     * Constructor for this authentication source.
     *
     * @param array<string, mixed> $info Information about this authentication source.
     * @param array<string, mixed> $config Configuration.
     *
     * @throws \Exception if the htpasswd file is not readable or the static_attributes array is invalid.
     */
    public function __construct(array $info, array $config)
    {
        // Call the parent constructor first, as required by the interface
        parent::__construct($info, $config);

        $this->users = [];

        if (!$htpasswd = file_get_contents($config['htpasswd_file'])) {
            throw new Exception('Could not read ' . $config['htpasswd_file']);
        }

        $this->users = explode("\n", trim($htpasswd));

        try {
            $attrUtils = new Utils\Attributes();
            $this->attributes = $attrUtils->normalizeAttributesArray($config['static_attributes']);
        } catch (Exception $e) {
            throw new Exception('Invalid static_attributes in authentication source ' .
                $this->authId . ': ' . $e->getMessage());
        }
    }


    /**
     * Attempt to log in using the given username and password.
     *
     * On a successful login, this function should return the username as 'uid' attribute,
     * and merged attributes from the configuration file.
     * On failure, it should throw an exception. A \SimpleSAML\Error\Error('WRONGUSERPASS')
     * should be thrown in case of a wrong username OR a wrong password, to prevent the
     * enumeration of usernames.
     *
     * @param string $username The username the user wrote.
     * @param string $password The password the user wrote.
     *
     * @return array<string, mixed> Associative array with the users attributes.
     *
     * @throws \SimpleSAML\Error\Error if authentication fails.
     */
    protected function login(
        string $username,
        #[\SensitiveParameter]
        string $password,
    ): array {
        $cryptoUtils = new Utils\Crypto();
        foreach ($this->users as $userpass) {
            $matches = explode(':', $userpass, 2);
            if ($matches[0] == $username) {
                $crypted = $matches[1];

                // This is about the only attribute we can add
                $attributes = array_merge(['uid' => [$username]], $this->attributes);

                // Traditional crypt(3)
                if ($cryptoUtils->secureCompare($crypted, crypt($password, $crypted))) {

The function SimpleSAML\Utils\Crypto::secureCompare() has been deprecated: Use hash_equals instead

                    Logger::debug('User ' . $username . ' authenticated successfully');
                    Logger::warning(
                        'CRYPT authentication is insecure. Please consider using something else.',
                    );
                    return $attributes;
                }

                // Apache's custom MD5
                if (APR1_MD5::check($password, $crypted)) {
                    Logger::debug('User ' . $username . ' authenticated successfully');
                    Logger::warning(
                        'APR1 authentication is insecure. Please consider using something else.',
                    );
                    return $attributes;
                }

                // PASSWORD_BCRYPT
                if ($cryptoUtils->pwValid($crypted, $password)) {

The function SimpleSAML\Utils\Crypto::pwValid() has been deprecated: Use Symfony NativePasswordHasher::verify instead

                    Logger::debug('User ' . $username . ' authenticated successfully');
                    return $attributes;
                }
                throw new Error\Error('WRONGUSERPASS');
            }
        }
        throw new Error\Error('WRONGUSERPASS');
    }
}