Completed
Push — master ( d809ff...b9c92c )
by Thijs
02:31
created
src/SAML2/Assertion.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 
278 278
         if ($xml->getAttribute('Version') !== '2.0') {
279 279
             /* Currently a very strict check. */
280
-            throw new \Exception('Unsupported version: ' . $xml->getAttribute('Version'));
280
+            throw new \Exception('Unsupported version: '.$xml->getAttribute('Version'));
281 281
         }
282 282
 
283 283
         $this->issueInstant = Utils::xsDateTimeToTimestamp($xml->getAttribute('IssueInstant'));
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
                 continue;
380 380
             }
381 381
             if ($node->namespaceURI !== Constants::NS_SAML) {
382
-                throw new \Exception('Unknown namespace of condition: ' . var_export($node->namespaceURI, true));
382
+                throw new \Exception('Unknown namespace of condition: '.var_export($node->namespaceURI, true));
383 383
             }
384 384
             switch ($node->localName) {
385 385
                 case 'AudienceRestriction':
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
                     /* Currently ignored. */
403 403
                     break;
404 404
                 default:
405
-                    throw new \Exception('Unknown condition: ' . var_export($node->localName, true));
405
+                    throw new \Exception('Unknown condition: '.var_export($node->localName, true));
406 406
             }
407 407
         }
408 408
     }
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
             }
590 590
             
591 591
             if ($type === 'xs:integer') {
592
-                $this->attributes[$attributeName][] = (int)$value->textContent;
592
+                $this->attributes[$attributeName][] = (int) $value->textContent;
593 593
             } else {
594 594
                 $this->attributes[$attributeName][] = trim($value->textContent);
595 595
             }
@@ -1367,7 +1367,7 @@  discard block
 block discarded – undo
1367 1367
             $document = $parentElement->ownerDocument;
1368 1368
         }
1369 1369
 
1370
-        $root = $document->createElementNS(Constants::NS_SAML, 'saml:' . 'Assertion');
1370
+        $root = $document->createElementNS(Constants::NS_SAML, 'saml:'.'Assertion');
1371 1371
         $parentElement->appendChild($root);
1372 1372
 
1373 1373
         /* Ugly hack to add another namespace declaration to the root element. */
@@ -1423,7 +1423,7 @@  discard block
 block discarded – undo
1423 1423
         if ($this->encryptedNameId === null) {
1424 1424
             $this->nameId->toXML($subject);
1425 1425
         } else {
1426
-            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:' . 'EncryptedID');
1426
+            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:'.'EncryptedID');
1427 1427
             $subject->appendChild($eid);
1428 1428
             $eid->appendChild($subject->ownerDocument->importNode($this->encryptedNameId, true));
1429 1429
         }
@@ -1575,7 +1575,7 @@  discard block
 block discarded – undo
1575 1575
             if (is_array($this->attributesValueTypes) && array_key_exists($name, $this->attributesValueTypes)) {
1576 1576
                 $valueTypes = $this->attributesValueTypes[$name];
1577 1577
                 if (is_array($valueTypes) && count($valueTypes) != count($values)) {
1578
-                    throw new \Exception('Array of value types and array of values have different size for attribute '. var_export($name, true));
1578
+                    throw new \Exception('Array of value types and array of values have different size for attribute '.var_export($name, true));
1579 1579
                 }
1580 1580
             } else {
1581 1581
                 // if no type(s), default behaviour
Please login to merge, or discard this patch.
src/SAML2/XML/md/EndpointType.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -52,12 +52,12 @@  discard block
 block discarded – undo
52 52
         }
53 53
 
54 54
         if (!$xml->hasAttribute('Binding')) {
55
-            throw new \Exception('Missing Binding on ' . $xml->tagName);
55
+            throw new \Exception('Missing Binding on '.$xml->tagName);
56 56
         }
57 57
         $this->Binding = $xml->getAttribute('Binding');
58 58
 
59 59
         if (!$xml->hasAttribute('Location')) {
60
-            throw new \Exception('Missing Location on ' . $xml->tagName);
60
+            throw new \Exception('Missing Location on '.$xml->tagName);
61 61
         }
62 62
         $this->Location = $xml->getAttribute('Location');
63 63
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
             if ($a->namespaceURI === null) {
70 70
                 continue; /* Not namespace-qualified -- skip. */
71 71
             }
72
-            $fullName = '{' . $a->namespaceURI . '}' . $a->localName;
72
+            $fullName = '{'.$a->namespaceURI.'}'.$a->localName;
73 73
             $this->attributes[$fullName] = array(
74 74
                 'qualifiedName' => $a->nodeName,
75 75
                 'namespaceURI' => $a->namespaceURI,
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         assert(is_string($namespaceURI));
91 91
         assert(is_string($localName));
92 92
 
93
-        $fullName = '{' . $namespaceURI . '}' . $localName;
93
+        $fullName = '{'.$namespaceURI.'}'.$localName;
94 94
 
95 95
         return isset($this->attributes[$fullName]);
96 96
     }
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         assert(is_string($namespaceURI));
108 108
         assert(is_string($localName));
109 109
 
110
-        $fullName = '{' . $namespaceURI . '}' . $localName;
110
+        $fullName = '{'.$namespaceURI.'}'.$localName;
111 111
         if (!isset($this->attributes[$fullName])) {
112 112
             return '';
113 113
         }
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         }
135 135
         $localName = $name[1];
136 136
 
137
-        $fullName = '{' . $namespaceURI . '}' . $localName;
137
+        $fullName = '{'.$namespaceURI.'}'.$localName;
138 138
         $this->attributes[$fullName] = array(
139 139
             'qualifiedName' => $qualifiedName,
140 140
             'namespaceURI' => $namespaceURI,
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         assert(is_string($namespaceURI));
154 154
         assert(is_string($localName));
155 155
 
156
-        $fullName = '{' . $namespaceURI . '}' . $localName;
156
+        $fullName = '{'.$namespaceURI.'}'.$localName;
157 157
         unset($this->attributes[$fullName]);
158 158
     }
159 159
 
Please login to merge, or discard this patch.
src/SAML2/XML/md/ContactPerson.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     {
116 116
         assert(is_string($name));
117 117
 
118
-        $e = Utils::xpQuery($parent, './saml_metadata:' . $name);
118
+        $e = Utils::xpQuery($parent, './saml_metadata:'.$name);
119 119
 
120 120
         $ret = array();
121 121
         foreach ($e as $i) {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
             return null;
143 143
         }
144 144
         if (count($e) > 1) {
145
-            throw new \Exception('More than one ' . $name . ' in ' . $parent->tagName);
145
+            throw new \Exception('More than one '.$name.' in '.$parent->tagName);
146 146
         }
147 147
 
148 148
         return $e[0];
Please login to merge, or discard this patch.
src/SAML2/Utils.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
         }
247 247
 
248 248
         foreach ($namespaces as $prefix => $uri) {
249
-            $newElement->setAttributeNS($uri, $prefix . ':__ns_workaround__', 'tmp');
249
+            $newElement->setAttributeNS($uri, $prefix.':__ns_workaround__', 'tmp');
250 250
             $newElement->removeAttributeNS($uri, '__ns_workaround__');
251 251
         }
252 252
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             case 'true':
280 280
                 return true;
281 281
             default:
282
-                throw new \Exception('Invalid value of boolean attribute ' . var_export($attributeName, true) . ': ' . var_export($value, true));
282
+                throw new \Exception('Invalid value of boolean attribute '.var_export($attributeName, true).': '.var_export($value, true));
283 283
         }
284 284
     }
285 285
 
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
             $symKeyInfoAlgo = $symmetricKeyInfo->getAlgorithm();
424 424
 
425 425
             if (in_array($symKeyInfoAlgo, $blacklist, true)) {
426
-                throw new \Exception('Algorithm disabled: ' . var_export($symKeyInfoAlgo, true));
426
+                throw new \Exception('Algorithm disabled: '.var_export($symKeyInfoAlgo, true));
427 427
             }
428 428
 
429 429
             if ($symKeyInfoAlgo === XMLSecurityKey::RSA_OAEP_MGF1P && $inputKeyAlgo === XMLSecurityKey::RSA_1_5) {
@@ -439,9 +439,9 @@  discard block
 block discarded – undo
439 439
             /* Make sure that the input key format is the same as the one used to encrypt the key. */
440 440
             if ($inputKeyAlgo !== $symKeyInfoAlgo) {
441 441
                 throw new \Exception(
442
-                    'Algorithm mismatch between input key and key used to encrypt ' .
443
-                    ' the symmetric key for the message. Key was: ' .
444
-                    var_export($inputKeyAlgo, true) . '; message was: ' .
442
+                    'Algorithm mismatch between input key and key used to encrypt '.
443
+                    ' the symmetric key for the message. Key was: '.
444
+                    var_export($inputKeyAlgo, true).'; message was: '.
445 445
                     var_export($symKeyInfoAlgo, true)
446 446
                 );
447 447
             }
@@ -455,20 +455,20 @@  discard block
 block discarded – undo
455 455
                 /* To protect against "key oracle" attacks, we need to be able to create a
456 456
                  * symmetric key, and for that we need to know the key size.
457 457
                  */
458
-                throw new \Exception('Unknown key size for encryption algorithm: ' . var_export($symmetricKey->type, true));
458
+                throw new \Exception('Unknown key size for encryption algorithm: '.var_export($symmetricKey->type, true));
459 459
             }
460 460
 
461 461
             try {
462 462
                 $key = $encKey->decryptKey($symmetricKeyInfo);
463 463
                 if (strlen($key) != $keySize) {
464 464
                     throw new \Exception(
465
-                        'Unexpected key size (' . strlen($key) * 8 . 'bits) for encryption algorithm: ' .
465
+                        'Unexpected key size ('.strlen($key)*8.'bits) for encryption algorithm: '.
466 466
                         var_export($symmetricKey->type, true)
467 467
                     );
468 468
                 }
469 469
             } catch (\Exception $e) {
470 470
                 /* We failed to decrypt this key. Log it, and substitute a "random" key. */
471
-                Utils::getContainer()->getLogger()->error('Failed to decrypt symmetric key: ' . $e->getMessage());
471
+                Utils::getContainer()->getLogger()->error('Failed to decrypt symmetric key: '.$e->getMessage());
472 472
                 /* Create a replacement key, so that it looks like we fail in the same way as if the key was correctly padded. */
473 473
 
474 474
                 /* We base the symmetric key on the encrypted key and private key, so that we always behave the
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
                 $encryptedKey = $encKey->getCipherValue();
478 478
                 $pkey = openssl_pkey_get_details($symmetricKeyInfo->key);
479 479
                 $pkey = sha1(serialize($pkey), true);
480
-                $key = sha1($encryptedKey . $pkey, true);
480
+                $key = sha1($encryptedKey.$pkey, true);
481 481
 
482 482
                 /* Make sure that the key has the correct length. */
483 483
                 if (strlen($key) > $keySize) {
@@ -492,8 +492,8 @@  discard block
 block discarded – undo
492 492
             /* Make sure that the input key has the correct format. */
493 493
             if ($inputKeyAlgo !== $symKeyAlgo) {
494 494
                 throw new \Exception(
495
-                    'Algorithm mismatch between input key and key in message. ' .
496
-                    'Key was: ' . var_export($inputKeyAlgo, true) . '; message was: ' .
495
+                    'Algorithm mismatch between input key and key in message. '.
496
+                    'Key was: '.var_export($inputKeyAlgo, true).'; message was: '.
497 497
                     var_export($symKeyAlgo, true)
498 498
                 );
499 499
             }
@@ -502,7 +502,7 @@  discard block
 block discarded – undo
502 502
 
503 503
         $algorithm = $symmetricKey->getAlgorithm();
504 504
         if (in_array($algorithm, $blacklist, true)) {
505
-            throw new \Exception('Algorithm disabled: ' . var_export($algorithm, true));
505
+            throw new \Exception('Algorithm disabled: '.var_export($algorithm, true));
506 506
         }
507 507
 
508 508
         /** @var string $decrypted */
@@ -514,8 +514,8 @@  discard block
 block discarded – undo
514 514
          * namespaces needed to parse the XML.
515 515
          */
516 516
         $xml = '<root xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" '.
517
-                     'xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">' .
518
-            $decrypted .
517
+                     'xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">'.
518
+            $decrypted.
519 519
             '</root>';
520 520
 
521 521
         try {
@@ -554,7 +554,7 @@  discard block
 block discarded – undo
554 554
              * Something went wrong during decryption, but for security
555 555
              * reasons we cannot tell the user what failed.
556 556
              */
557
-            Utils::getContainer()->getLogger()->error('Decryption failed: ' . $e->getMessage());
557
+            Utils::getContainer()->getLogger()->error('Decryption failed: '.$e->getMessage());
558 558
             throw new \Exception('Failed to decrypt XML element.', 0, $e);
559 559
         }
560 560
     }
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
716 716
         $regex = '/^(\\d\\d\\d\\d)-(\\d\\d)-(\\d\\d)T(\\d\\d):(\\d\\d):(\\d\\d)(?:\\.\\d{1,9})?Z$/D';
717 717
         if (preg_match($regex, $time, $matches) == 0) {
718 718
             throw new \Exception(
719
-                'Invalid SAML2 timestamp passed to xsDateTimeToTimestamp: ' . $time
719
+                'Invalid SAML2 timestamp passed to xsDateTimeToTimestamp: '.$time
720 720
             );
721 721
         }
722 722
 
Please login to merge, or discard this patch.