SubjectConfirmationNotOnOrAfter::validate() - Code Metrics - Inspection of "PSR-20 - Use a clock and replace integer timestamp..." - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#336)

by Tim

created 2023-05-27 20:55 UTC

SubjectConfirmationNotOnOrAfter::validate() A

↳ Parent: SubjectConfirmationNotOnOrAfter

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
c	0
b	0
f	0
nc	2
nop	2
dl	0
loc	12
rs	10

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML2\Assertion\Validation\ConstraintValidator;

use Beste\Clock;
use DateInterval;
use SimpleSAML\Assert\Assert;
use SimpleSAML\SAML2\Assertion\Validation\Result;
use SimpleSAML\SAML2\Assertion\Validation\SubjectConfirmationConstraintValidator;
use SimpleSAML\SAML2\XML\saml\SubjectConfirmation;
use SimpleSAML\SAML2\Utils;

class SubjectConfirmationNotOnOrAfter implements SubjectConfirmationConstraintValidator
{
    /** @var \Beste\Clock */
    private static Clock $clock;


    /**
     */
    public function __construct()
    {
        self::$clock = Utils::getContainer()->getClock();
    }


    /**
     * @param \SimpleSAML\SAML2\XML\saml\SubjectConfirmation $subjectConfirmation
     * @param \SimpleSAML\SAML2\Assertion\Validation\Result $result
     *
     * @throws \SimpleSAML\Assert\AssertionFailedException if assertions are false
     */
    public function validate(
        SubjectConfirmation $subjectConfirmation,
        Result $result,
    ): void {
        $data = $subjectConfirmation->getSubjectConfirmationData();
        Assert::notNull($data);

        /** @psalm-suppress PossiblyNullReference */
        $notOnOrAfter = $data->getNotOnOrAfter();
        $currentTime = self::$clock->now();
        if ($notOnOrAfter !== null && $notOnOrAfter <= ($currentTime->sub(new DateInterval('PT60S')))) {
            $result->addError('NotOnOrAfter in SubjectConfirmationData is in the past');
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\SAML2\Assertion\Validation\ConstraintValidator;
6
7			use Beste\Clock;
8			use DateInterval;
9			use SimpleSAML\Assert\Assert;
10			use SimpleSAML\SAML2\Assertion\Validation\Result;
11			use SimpleSAML\SAML2\Assertion\Validation\SubjectConfirmationConstraintValidator;
12			use SimpleSAML\SAML2\XML\saml\SubjectConfirmation;
13			use SimpleSAML\SAML2\Utils;
14
15			class SubjectConfirmationNotOnOrAfter implements SubjectConfirmationConstraintValidator
16			{
17			/** @var \Beste\Clock */
18			private static Clock $clock;
19
20
21			/**
22			*/
23			public function __construct()
24			{
25			self::$clock = Utils::getContainer()->getClock();
26			}
27
28
29			/**
30			* @param \SimpleSAML\SAML2\XML\saml\SubjectConfirmation $subjectConfirmation
31			* @param \SimpleSAML\SAML2\Assertion\Validation\Result $result
32			*
33			* @throws \SimpleSAML\Assert\AssertionFailedException if assertions are false
34			*/
35			public function validate(
36			SubjectConfirmation $subjectConfirmation,
37			Result $result,
38			): void {
39			$data = $subjectConfirmation->getSubjectConfirmationData();
40			Assert::notNull($data);
41
42			/** @psalm-suppress PossiblyNullReference */
43			$notOnOrAfter = $data->getNotOnOrAfter();
44			$currentTime = self::$clock->now();
45			if ($notOnOrAfter !== null && $notOnOrAfter <= ($currentTime->sub(new DateInterval('PT60S')))) {
46			$result->addError('NotOnOrAfter in SubjectConfirmationData is in the past');
47			}
48			}
49			}
50

simplesamlphp / saml2

Pull Request — master (#336)

SubjectConfirmationNotOnOrAfter::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like