NotBefore::validate() - Code Metrics - Inspection of "PSR-20 - Use a clock and replace integer timestamp..." - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#336)

by Tim

created 2023-05-27 20:55 UTC

NotBefore::validate() A

↳ Parent: NotBefore

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	3
nop	2
dl	0
loc	12
rs	9.9666
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML2\Assertion\Validation\ConstraintValidator;

use Beste\Clock;
use DateInterval;
use SimpleSAML\SAML2\XML\saml\Assertion;
use SimpleSAML\SAML2\Assertion\Validation\AssertionConstraintValidator;
use SimpleSAML\SAML2\Assertion\Validation\Result;
use SimpleSAML\SAML2\Utils;

class NotBefore implements AssertionConstraintValidator
{
    /** @var \Beste\Clock */
    private static Clock $clock;


    /**
     */
    public function __construct()
    {
        self::$clock = Utils::getContainer()->getClock();
    }


    /**
     * @param \SimpleSAML\SAML2\XML\saml\Assertion $assertion
     * @param \SimpleSAML\SAML2\Assertion\Validation\Result $result
     */
    public function validate(Assertion $assertion, Result $result): void
    {
        $conditions = $assertion->getConditions();
        if ($conditions !== null) {
            $notBeforeTimestamp = $conditions->getNotBefore();
            $currentTime = self::$clock->now();
            if (
                ($notBeforeTimestamp !== null) &&
                ($notBeforeTimestamp > ($currentTime->add(new DateInterval('PT60S'))))
            ) {
                $result->addError(
                    'Received an assertion that is valid in the future. Check clock synchronization on IdP and SP.',
                );
            }
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\SAML2\Assertion\Validation\ConstraintValidator;
6
7			use Beste\Clock;
8			use DateInterval;
9			use SimpleSAML\SAML2\XML\saml\Assertion;
10			use SimpleSAML\SAML2\Assertion\Validation\AssertionConstraintValidator;
11			use SimpleSAML\SAML2\Assertion\Validation\Result;
12			use SimpleSAML\SAML2\Utils;
13
14			class NotBefore implements AssertionConstraintValidator
15			{
16			/** @var \Beste\Clock */
17			private static Clock $clock;
18
19
20			/**
21			*/
22			public function __construct()
23			{
24			self::$clock = Utils::getContainer()->getClock();
25			}
26
27
28			/**
29			* @param \SimpleSAML\SAML2\XML\saml\Assertion $assertion
30			* @param \SimpleSAML\SAML2\Assertion\Validation\Result $result
31			*/
32			public function validate(Assertion $assertion, Result $result): void
33			{
34			$conditions = $assertion->getConditions();
35			if ($conditions !== null) {
36			$notBeforeTimestamp = $conditions->getNotBefore();
37			$currentTime = self::$clock->now();
38			if (
39			($notBeforeTimestamp !== null) &&
40			($notBeforeTimestamp > ($currentTime->add(new DateInterval('PT60S'))))
41			) {
42			$result->addError(
43			'Received an assertion that is valid in the future. Check clock synchronization on IdP and SP.',
44			);
45			}
46			}
47			}
48			}
49

simplesamlphp / saml2

Pull Request — master (#336)

NotBefore::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like