EntitiesDescriptor::__construct() - Code Metrics - Inspection of "Rewrite signed elements" - simplesamlphp/saml2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#280)

by Tim

created 2021-07-25 21:17 UTC

EntitiesDescriptor::__construct() A

↳ Parent: EntitiesDescriptor

Complexity

Conditions	2
Paths	1

Size

Total Lines	20
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	1
nop	8
dl	0
loc	20
rs	10
c	0
b	0
f	0

How to fix Many Parameters

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML2\XML\md;

use DOMElement;
use SimpleSAML\Assert\Assert;
use SimpleSAML\XML\Exception\InvalidDOMElementException;
use SimpleSAML\XML\Exception\TooManyElementsException;
use SimpleSAML\XML\Utils as XMLUtils;
use SimpleSAML\XMLSecurity\XML\ds\Signature;

/**
 * Class representing SAML 2 EntitiesDescriptor element.
 *
 * @package simplesamlphp/saml2
 */
final class EntitiesDescriptor extends AbstractMetadataDocument
{
    /**
     * The name of this entity collection.
     *
     * @var string|null
     */
    protected ?string $Name = null;

    /** @var \SimpleSAML\SAML2\XML\md\EntityDescriptor[] */
    protected array $entityDescriptors = [];

    /** @var \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] */
    protected array $entitiesDescriptors = [];


    /**
     * EntitiesDescriptor constructor.
     *
     * @param \SimpleSAML\SAML2\XML\md\EntityDescriptor[] $entityDescriptors
     * @param \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] $entitiesDescriptors
     * @param string|null $name
     * @param string|null $ID
     * @param int|null $validUntil
     * @param string|null $cacheDuration
     * @param \SimpleSAML\SAML2\XML\md\Extensions|null $extensions
     * @param \DOMAttr[] $namespacedAttributes
     */
    public function __construct(
        array $entityDescriptors = [],
        array $entitiesDescriptors = [],
        ?string $name = null,
        ?string $ID = null,
        ?int $validUntil = null,
        ?string $cacheDuration = null,
        ?Extensions $extensions = null,
        array $namespacedAttributes = []
    ) {
        Assert::true(
            !empty($entitiesDescriptors) || !empty($entityDescriptors),
            'At least one md:EntityDescriptor or md:EntitiesDescriptor element is required.'
        );

        parent::__construct($ID, $validUntil, $cacheDuration, $extensions, $namespacedAttributes);

        $this->setName($name);
        $this->setEntityDescriptors($entityDescriptors);
        $this->setEntitiesDescriptors($entitiesDescriptors);
    }


    /**
     * Initialize an EntitiesDescriptor from an existing XML document.
     *
     * @param \DOMElement $xml The XML element we should load.
     * @return \SimpleSAML\SAML2\XML\md\EntitiesDescriptor
     *
     * @throws \SimpleSAML\XML\Exception\InvalidDOMElementException if the qualified name of the supplied element is wrong
     * @throws \SimpleSAML\XML\Exception\TooManyElementsException if too many child-elements of a type are specified
     */
    public static function fromXML(DOMElement $xml): object
    {
        Assert::same($xml->localName, 'EntitiesDescriptor', InvalidDOMElementException::class);
        Assert::same($xml->namespaceURI, EntitiesDescriptor::NS, InvalidDOMElementException::class);

        $validUntil = self::getAttribute($xml, 'validUntil', null);
        $orgs = Organization::getChildrenOfClass($xml);
        Assert::maxCount($orgs, 1, 'More than one Organization found in this descriptor', TooManyElementsException::class);

        $extensions = Extensions::getChildrenOfClass($xml);
        Assert::maxCount($extensions, 1, 'Only one md:Extensions element is allowed.', TooManyElementsException::class);

        $signature = Signature::getChildrenOfClass($xml);
        Assert::maxCount($signature, 1, 'Only one ds:Signature element is allowed.', TooManyElementsException::class);

        $entities = new self(
            EntityDescriptor::getChildrenOfClass($xml),
            EntitiesDescriptor::getChildrenOfClass($xml),
            self::getAttribute($xml, 'Name', null),
            self::getAttribute($xml, 'ID', null),
            $validUntil !== null ? XMLUtils::xsDateTimeToTimestamp($validUntil) : null,
            self::getAttribute($xml, 'cacheDuration', null),
            !empty($extensions) ? $extensions[0] : null,
            self::getAttributesNSFromXML($xml)
        );

        if (!empty($signature)) {
            $entities->setSignature($signature[0]);
        }

        $entities->setXML($xml);

        return $entities;
    }


    /**
     * Get the EntitiesDescriptor children objects
     *
     * @return \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[]
     */
    public function getEntitiesDescriptors(): array
    {
        return $this->entitiesDescriptors;
    }


    /**
     * Set the EntitiesDescriptor children objects
     *
     * @param \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] $entitiesDescriptors
     */
    protected function setEntitiesDescriptors(array $entitiesDescriptors): void
    {
        Assert::allIsInstanceOf($entitiesDescriptors, EntitiesDescriptor::class);
        $this->entitiesDescriptors = $entitiesDescriptors;
    }


    /**
     * Get the EntityDescriptor children objects
     *
     * @return \SimpleSAML\SAML2\XML\md\EntityDescriptor[]
     */
    public function getEntityDescriptors(): array
    {
        return $this->entityDescriptors;
    }



    /**
     * Set the EntityDescriptor children objects
     *
     * @param \SimpleSAML\SAML2\XML\md\EntityDescriptor[] $entityDescriptors
     */
    protected function setEntityDescriptors(array $entityDescriptors): void
    {
        Assert::allIsInstanceOf($entityDescriptors, EntityDescriptor::class);
        $this->entityDescriptors = $entityDescriptors;
    }



    /**
     * Collect the value of the Name property.
     *
     * @return string|null
     */
    public function getName(): ?string
    {
        return $this->Name;
    }


    /**
     * Set the value of the Name property.
     *
     * @param string|null $name
     */
    protected function setName(?string $name = null): void
    {
        if ($name === null) {
            return;
        }
        $this->Name = $name;
    }


    /**
     * Convert this descriptor to an unsigned XML document.
     * This method does not sign the resulting XML document.
     *
     * @param \DOMElement|null $parent
     * @return \DOMElement The root element of the DOM tree
     */
    protected function toUnsignedXML(DOMElement $parent = null): DOMElement
    {
        $e = parent::toUnsignedXML($parent);

        foreach ($this->getAttributesNS() as $attr) {
            $e->setAttributeNS($attr['namespaceURI'], $attr['qualifiedName'], $attr['value']);
        }

        if ($this->Name !== null) {
            $e->setAttribute('Name', $this->Name);
        }

        foreach ($this->entitiesDescriptors as $entitiesDescriptor) {
            $entitiesDescriptor->toXML($e);
        }

        foreach ($this->entityDescriptors as $entityDescriptor) {
            $entityDescriptor->toXML($e);
        }

        return $e;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace SimpleSAML\SAML2\XML\md;
6
7			use DOMElement;
8			use SimpleSAML\Assert\Assert;
9			use SimpleSAML\XML\Exception\InvalidDOMElementException;
10			use SimpleSAML\XML\Exception\TooManyElementsException;
11			use SimpleSAML\XML\Utils as XMLUtils;
12			use SimpleSAML\XMLSecurity\XML\ds\Signature;
13
14			/**
15			* Class representing SAML 2 EntitiesDescriptor element.
16			*
17			* @package simplesamlphp/saml2
18			*/
19			final class EntitiesDescriptor extends AbstractMetadataDocument
20			{
21			/**
22			* The name of this entity collection.
23			*
24			* @var string\|null
25			*/
26			protected ?string $Name = null;
27
28			/** @var \SimpleSAML\SAML2\XML\md\EntityDescriptor[] */
29			protected array $entityDescriptors = [];
30
31			/** @var \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] */
32			protected array $entitiesDescriptors = [];
33
34
35			/**
36			* EntitiesDescriptor constructor.
37			*
38			* @param \SimpleSAML\SAML2\XML\md\EntityDescriptor[] $entityDescriptors
39			* @param \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] $entitiesDescriptors
40			* @param string\|null $name
41			* @param string\|null $ID
42			* @param int\|null $validUntil
43			* @param string\|null $cacheDuration
44			* @param \SimpleSAML\SAML2\XML\md\Extensions\|null $extensions
45			* @param \DOMAttr[] $namespacedAttributes
46			*/
47			public function __construct(
48			array $entityDescriptors = [],
49			array $entitiesDescriptors = [],
50			?string $name = null,
51			?string $ID = null,
52			?int $validUntil = null,
53			?string $cacheDuration = null,
54			?Extensions $extensions = null,
55			array $namespacedAttributes = []
56			) {
57			Assert::true(
58			!empty($entitiesDescriptors) \|\| !empty($entityDescriptors),
59			'At least one md:EntityDescriptor or md:EntitiesDescriptor element is required.'
60			);
61
62			parent::__construct($ID, $validUntil, $cacheDuration, $extensions, $namespacedAttributes);
63
64			$this->setName($name);
65			$this->setEntityDescriptors($entityDescriptors);
66			$this->setEntitiesDescriptors($entitiesDescriptors);
67			}
68
69
70			/**
71			* Initialize an EntitiesDescriptor from an existing XML document.
72			*
73			* @param \DOMElement $xml The XML element we should load.
74			* @return \SimpleSAML\SAML2\XML\md\EntitiesDescriptor
75			*
76			* @throws \SimpleSAML\XML\Exception\InvalidDOMElementException if the qualified name of the supplied element is wrong
77			* @throws \SimpleSAML\XML\Exception\TooManyElementsException if too many child-elements of a type are specified
78			*/
79			public static function fromXML(DOMElement $xml): object
80			{
81			Assert::same($xml->localName, 'EntitiesDescriptor', InvalidDOMElementException::class);
82			Assert::same($xml->namespaceURI, EntitiesDescriptor::NS, InvalidDOMElementException::class);
83
84			$validUntil = self::getAttribute($xml, 'validUntil', null);
85			$orgs = Organization::getChildrenOfClass($xml);
86			Assert::maxCount($orgs, 1, 'More than one Organization found in this descriptor', TooManyElementsException::class);
87
88			$extensions = Extensions::getChildrenOfClass($xml);
89			Assert::maxCount($extensions, 1, 'Only one md:Extensions element is allowed.', TooManyElementsException::class);
90
91			$signature = Signature::getChildrenOfClass($xml);
92			Assert::maxCount($signature, 1, 'Only one ds:Signature element is allowed.', TooManyElementsException::class);
93
94			$entities = new self(
95			EntityDescriptor::getChildrenOfClass($xml),
96			EntitiesDescriptor::getChildrenOfClass($xml),
97			self::getAttribute($xml, 'Name', null),
98			self::getAttribute($xml, 'ID', null),
99			$validUntil !== null ? XMLUtils::xsDateTimeToTimestamp($validUntil) : null,
100			self::getAttribute($xml, 'cacheDuration', null),
101			!empty($extensions) ? $extensions[0] : null,
102			self::getAttributesNSFromXML($xml)
103			);
104
105			if (!empty($signature)) {
106			$entities->setSignature($signature[0]);
107			}
108
109			$entities->setXML($xml);
110
111			return $entities;
112			}
113
114
115			/**
116			* Get the EntitiesDescriptor children objects
117			*
118			* @return \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[]
119			*/
120			public function getEntitiesDescriptors(): array
121			{
122			return $this->entitiesDescriptors;
123			}
124
125
126			/**
127			* Set the EntitiesDescriptor children objects
128			*
129			* @param \SimpleSAML\SAML2\XML\md\EntitiesDescriptor[] $entitiesDescriptors
130			*/
131			protected function setEntitiesDescriptors(array $entitiesDescriptors): void
132			{
133			Assert::allIsInstanceOf($entitiesDescriptors, EntitiesDescriptor::class);
134			$this->entitiesDescriptors = $entitiesDescriptors;
135			}
136
137
138			/**
139			* Get the EntityDescriptor children objects
140			*
141			* @return \SimpleSAML\SAML2\XML\md\EntityDescriptor[]
142			*/
143			public function getEntityDescriptors(): array
144			{
145			return $this->entityDescriptors;
146			}
147
148
149
150			/**
151			* Set the EntityDescriptor children objects
152			*
153			* @param \SimpleSAML\SAML2\XML\md\EntityDescriptor[] $entityDescriptors
154			*/
155			protected function setEntityDescriptors(array $entityDescriptors): void
156			{
157			Assert::allIsInstanceOf($entityDescriptors, EntityDescriptor::class);
158			$this->entityDescriptors = $entityDescriptors;
159			}
160
161
162
163			/**
164			* Collect the value of the Name property.
165			*
166			* @return string\|null
167			*/
168			public function getName(): ?string
169			{
170			return $this->Name;
171			}
172
173
174			/**
175			* Set the value of the Name property.
176			*
177			* @param string\|null $name
178			*/
179			protected function setName(?string $name = null): void
180			{
181			if ($name === null) {
182			return;
183			}
184			$this->Name = $name;
185			}
186
187
188			/**
189			* Convert this descriptor to an unsigned XML document.
190			* This method does not sign the resulting XML document.
191			*
192			* @param \DOMElement\|null $parent
193			* @return \DOMElement The root element of the DOM tree
194			*/
195			protected function toUnsignedXML(DOMElement $parent = null): DOMElement
196			{
197			$e = parent::toUnsignedXML($parent);
198
199			foreach ($this->getAttributesNS() as $attr) {
200			$e->setAttributeNS($attr['namespaceURI'], $attr['qualifiedName'], $attr['value']);
201			}
202
203			if ($this->Name !== null) {
204			$e->setAttribute('Name', $this->Name);
205			}
206
207			foreach ($this->entitiesDescriptors as $entitiesDescriptor) {
208			$entitiesDescriptor->toXML($e);
209			}
210
211			foreach ($this->entityDescriptors as $entityDescriptor) {
212			$entityDescriptor->toXML($e);
213			}
214
215			return $e;
216			}
217			}
218

simplesamlphp / saml2

Pull Request — master (#280)

EntitiesDescriptor::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like